~abcdw/rde-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
7 4

[PATCH rde 0/1] Nyxt API change

Details
Message ID
<168545980232.31479.15261334437482272614-0@git.sr.ht>
DKIM signature
missing
Download raw message
Without this patch the default configuration causes nyxt todisplay an
error, because the file structure of the nyxtv3 source code has changed.

Kabelo M'sobomvu Moiloa (1):
  rde: features: web-browsers: update naming convention.

 src/rde/features/web-browsers.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.38.4

[PATCH rde 1/1] rde: features: web-browsers: update naming convention.

Details
Message ID
<168545980232.31479.15261334437482272614-1@git.sr.ht>
In-Reply-To
<168545980232.31479.15261334437482272614-0@git.sr.ht> (view parent)
DKIM signature
missing
Download raw message
Patch: +2 -2
From: Kabelo M'sobomvu Moiloa <personal@kabelom.com>

---
 src/rde/features/web-browsers.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/rde/features/web-browsers.scm b/src/rde/features/web-browsers.scm
index e6b552b..c1ef8f9 100644
--- a/src/rde/features/web-browsers.scm
+++ b/src/rde/features/web-browsers.scm
@@ -246,8 +246,8 @@ functionalities."
                    `((default-new-buffer-url
                       (quri:uri ,default-new-buffer-url)))
                    '())))
           (define-configuration nyxt/hint-mode:hint-mode
             ((nyxt/hint-mode:hints-alphabet ,(match keyboard-variant
           (define-configuration nyxt/mode/hint:hint-mode
             ((nyxt/mode/hint:hints-alphabet ,(match keyboard-variant
                                                ("dvorak" "aoeuidhtns")
                                                (_ "asdfghjklqwertyuiop")))))
           ,@(if autostart-slynk?
-- 
2.38.4

[rde/patches/.build.yml] build success

builds.sr.ht <builds@sr.ht>
Details
Message ID
<CSZPW32TP7SI.1BPUT8RUBLDEQ@cirno2>
In-Reply-To
<168545980232.31479.15261334437482272614-1@git.sr.ht> (view parent)
DKIM signature
missing
Download raw message
rde/patches/.build.yml: SUCCESS in 11m58s

[Nyxt API change][0] from [~elevenkb][1]

[0]: https://lists.sr.ht/~abcdw/rde-devel/patches/41505
[1]: personal@kabelom.com

✓ #998545 SUCCESS rde/patches/.build.yml https://builds.sr.ht/~abcdw/job/998545

Re: [PATCH rde 1/1] rde: features: web-browsers: update naming convention.

Miguel Ángel Moreno <me@mianmoreno.com>
Details
Message ID
<86cz2h5z2n.fsf@mianmoreno.com>
In-Reply-To
<168545980232.31479.15261334437482272614-1@git.sr.ht> (view parent)
DKIM signature
missing
Download raw message
On 2023-05-10 22:59, ~elevenkb wrote:

> From: Kabelo M'sobomvu Moiloa <personal@kabelom.com>
>
> ---
>  src/rde/features/web-browsers.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/rde/features/web-browsers.scm b/src/rde/features/web-browsers.scm
> index e6b552b..c1ef8f9 100644
> --- a/src/rde/features/web-browsers.scm
> +++ b/src/rde/features/web-browsers.scm
> @@ -246,8 +246,8 @@ functionalities."
>                      `((default-new-buffer-url
>                         (quri:uri ,default-new-buffer-url)))
>                      '())))
> -           (define-configuration nyxt/hint-mode:hint-mode
> -             ((nyxt/hint-mode:hints-alphabet ,(match keyboard-variant
> +           (define-configuration nyxt/mode/hint:hint-mode
> +             ((nyxt/mode/hint:hints-alphabet ,(match keyboard-variant
>                                                  ("dvorak" "aoeuidhtns")
>                                                  (_ "asdfghjklqwertyuiop")))))
>             ,@(if autostart-slynk?

Hi Kabelo,

Thank you for the patch and the heads up on the new API.  I haven't
gotten around trying Nyxt 3.0 yet, but I'll make sure to give it a spin
and update the package in the feature as soon as we update to the latest
Guix checkout.  I'll hold off on applying this patch until then.

-- 
Best regards,
Miguel Ángel Moreno

Re: [PATCH rde 1/1] rde: features: web-browsers: update naming convention.

Details
Message ID
<875y7r3dty.fsf@trop.in>
In-Reply-To
<86cz2h5z2n.fsf@mianmoreno.com> (view parent)
DKIM signature
missing
Download raw message
On 2023-05-30 22:44, Miguel Ángel Moreno wrote:

> On 2023-05-10 22:59, ~elevenkb wrote:
>
>> From: Kabelo M'sobomvu Moiloa <personal@kabelom.com>
>>
>> ---
>>  src/rde/features/web-browsers.scm | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/rde/features/web-browsers.scm b/src/rde/features/web-browsers.scm
>> index e6b552b..c1ef8f9 100644
>> --- a/src/rde/features/web-browsers.scm
>> +++ b/src/rde/features/web-browsers.scm
>> @@ -246,8 +246,8 @@ functionalities."
>>                      `((default-new-buffer-url
>>                         (quri:uri ,default-new-buffer-url)))
>>                      '())))
>> -           (define-configuration nyxt/hint-mode:hint-mode
>> -             ((nyxt/hint-mode:hints-alphabet ,(match keyboard-variant
>> +           (define-configuration nyxt/mode/hint:hint-mode
>> +             ((nyxt/mode/hint:hints-alphabet ,(match keyboard-variant
>>                                                  ("dvorak" "aoeuidhtns")
>>                                                  (_ "asdfghjklqwertyuiop")))))
>>             ,@(if autostart-slynk?
>
> Hi Kabelo,
>
> Thank you for the patch and the heads up on the new API.  I haven't
> gotten around trying Nyxt 3.0 yet, but I'll make sure to give it a spin
> and update the package in the feature as soon as we update to the latest
> Guix checkout.  I'll hold off on applying this patch until then.

We updated guix revision in channels-lock, so feel free to proceed with
this patch.

-- 
Best regards,
Andrew Tropin

Re: [PATCH rde 1/1] rde: features: web-browsers: update naming convention.

Miguel Ángel Moreno <me@mianmoreno.com>
Details
Message ID
<86mt0t2iv4.fsf@mianmoreno.com>
In-Reply-To
<875y7r3dty.fsf@trop.in> (view parent)
DKIM signature
missing
Download raw message
On 2023-06-13 13:34, Andrew Tropin wrote:

> On 2023-05-30 22:44, Miguel Ángel Moreno wrote:
>
>> On 2023-05-10 22:59, ~elevenkb wrote:
>>
>>> From: Kabelo M'sobomvu Moiloa <personal@kabelom.com>
>>>
>>> ---
>>>  src/rde/features/web-browsers.scm | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/src/rde/features/web-browsers.scm b/src/rde/features/web-browsers.scm
>>> index e6b552b..c1ef8f9 100644
>>> --- a/src/rde/features/web-browsers.scm
>>> +++ b/src/rde/features/web-browsers.scm
>>> @@ -246,8 +246,8 @@ functionalities."
>>>                      `((default-new-buffer-url
>>>                         (quri:uri ,default-new-buffer-url)))
>>>                      '())))
>>> -           (define-configuration nyxt/hint-mode:hint-mode
>>> -             ((nyxt/hint-mode:hints-alphabet ,(match keyboard-variant
>>> +           (define-configuration nyxt/mode/hint:hint-mode
>>> +             ((nyxt/mode/hint:hints-alphabet ,(match keyboard-variant
>>>                                                  ("dvorak" "aoeuidhtns")
>>>                                                  (_ "asdfghjklqwertyuiop")))))
>>>             ,@(if autostart-slynk?
>>
>> Hi Kabelo,
>>
>> Thank you for the patch and the heads up on the new API.  I haven't
>> gotten around trying Nyxt 3.0 yet, but I'll make sure to give it a spin
>> and update the package in the feature as soon as we update to the latest
>> Guix checkout.  I'll hold off on applying this patch until then.
>
> We updated guix revision in channels-lock, so feel free to proceed with
> this patch.

Hi,

I tried to bump this to the latest Nyxt, but I faced lots of Nyxt
initialization errors with this configuration.  Will give it another
shot this weekend.

-- 
Best regards,
Miguel Ángel Moreno

Re: [PATCH rde 1/1] rde: features: web-browsers: update naming convention.

Miguel Ángel Moreno <me@mianmoreno.com>
Details
Message ID
<86zg4o0wan.fsf@mianmoreno.com>
In-Reply-To
<86mt0t2iv4.fsf@mianmoreno.com> (view parent)
DKIM signature
missing
Download raw message
On 2023-06-21 12:46, Miguel Ángel Moreno wrote:

> On 2023-06-13 13:34, Andrew Tropin wrote:
>
>> On 2023-05-30 22:44, Miguel Ángel Moreno wrote:
>>
>>> On 2023-05-10 22:59, ~elevenkb wrote:
>>>
>>>> From: Kabelo M'sobomvu Moiloa <personal@kabelom.com>
>>>>
>>>> ---
>>>>  src/rde/features/web-browsers.scm | 4 ++--
>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/src/rde/features/web-browsers.scm b/src/rde/features/web-browsers.scm
>>>> index e6b552b..c1ef8f9 100644
>>>> --- a/src/rde/features/web-browsers.scm
>>>> +++ b/src/rde/features/web-browsers.scm
>>>> @@ -246,8 +246,8 @@ functionalities."
>>>>                      `((default-new-buffer-url
>>>>                         (quri:uri ,default-new-buffer-url)))
>>>>                      '())))
>>>> -           (define-configuration nyxt/hint-mode:hint-mode
>>>> -             ((nyxt/hint-mode:hints-alphabet ,(match keyboard-variant
>>>> +           (define-configuration nyxt/mode/hint:hint-mode
>>>> +             ((nyxt/mode/hint:hints-alphabet ,(match keyboard-variant
>>>>                                                  ("dvorak" "aoeuidhtns")
>>>>                                                  (_ "asdfghjklqwertyuiop")))))
>>>>             ,@(if autostart-slynk?
>>>
>>> Hi Kabelo,
>>>
>>> Thank you for the patch and the heads up on the new API.  I haven't
>>> gotten around trying Nyxt 3.0 yet, but I'll make sure to give it a spin
>>> and update the package in the feature as soon as we update to the latest
>>> Guix checkout.  I'll hold off on applying this patch until then.
>>
>> We updated guix revision in channels-lock, so feel free to proceed with
>> this patch.
>
> Hi,
>
> I tried to bump this to the latest Nyxt, but I faced lots of Nyxt
> initialization errors with this configuration.  Will give it another
> shot this weekend.

Merged this along with other changes for the migration to Nyxt v3.
Marking it as APPLIED.

-- 
Best regards,
Miguel Ángel Moreno

Re: [PATCH rde 1/1] rde: features: web-browsers: update naming convention.

Details
Message ID
<87y1k6omda.fsf@trop.in>
In-Reply-To
<86zg4o0wan.fsf@mianmoreno.com> (view parent)
DKIM signature
missing
Download raw message
On 2023-06-25 10:40, Miguel Ángel Moreno wrote:

> On 2023-06-21 12:46, Miguel Ángel Moreno wrote:
>
>> On 2023-06-13 13:34, Andrew Tropin wrote:
>>
>>> On 2023-05-30 22:44, Miguel Ángel Moreno wrote:
>>>
>>>> On 2023-05-10 22:59, ~elevenkb wrote:
>>>>
>>>>> From: Kabelo M'sobomvu Moiloa <personal@kabelom.com>
>>>>>
>>>>> ---
>>>>>  src/rde/features/web-browsers.scm | 4 ++--
>>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/src/rde/features/web-browsers.scm b/src/rde/features/web-browsers.scm
>>>>> index e6b552b..c1ef8f9 100644
>>>>> --- a/src/rde/features/web-browsers.scm
>>>>> +++ b/src/rde/features/web-browsers.scm
>>>>> @@ -246,8 +246,8 @@ functionalities."
>>>>>                      `((default-new-buffer-url
>>>>>                         (quri:uri ,default-new-buffer-url)))
>>>>>                      '())))
>>>>> -           (define-configuration nyxt/hint-mode:hint-mode
>>>>> -             ((nyxt/hint-mode:hints-alphabet ,(match keyboard-variant
>>>>> +           (define-configuration nyxt/mode/hint:hint-mode
>>>>> +             ((nyxt/mode/hint:hints-alphabet ,(match keyboard-variant
>>>>>                                                  ("dvorak" "aoeuidhtns")
>>>>>                                                  (_ "asdfghjklqwertyuiop")))))
>>>>>             ,@(if autostart-slynk?
>>>>
>>>> Hi Kabelo,
>>>>
>>>> Thank you for the patch and the heads up on the new API.  I haven't
>>>> gotten around trying Nyxt 3.0 yet, but I'll make sure to give it a spin
>>>> and update the package in the feature as soon as we update to the latest
>>>> Guix checkout.  I'll hold off on applying this patch until then.
>>>
>>> We updated guix revision in channels-lock, so feel free to proceed with
>>> this patch.
>>
>> Hi,
>>
>> I tried to bump this to the latest Nyxt, but I faced lots of Nyxt
>> initialization errors with this configuration.  Will give it another
>> shot this weekend.
>
> Merged this along with other changes for the migration to Nyxt v3.
> Marking it as APPLIED.

Good!  Thank you! :)

-- 
Best regards,
Andrew Tropin
Reply to thread Export thread (mbox)