~abcdw/rde-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
5 3

[PATCH] contrib: emacs-xyz: Enable vim bindings in the minibuffer.

Details
Message ID
<20230410000206.22762-1-jgart@dismail.de>
DKIM signature
missing
Download raw message
Patch: +1 -0
---

Hi,

WDYT if we enable vim bindings in the minibuffer as well? Too evil?

all best,

jgart

 src/contrib/features/emacs-xyz.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/contrib/features/emacs-xyz.scm b/src/contrib/features/emacs-xyz.scm
index 577d1bd..75cd16a 100644
--- a/src/contrib/features/emacs-xyz.scm
+++ b/src/contrib/features/emacs-xyz.scm
@@ -79,6 +79,7 @@ recommended RDE experience is to rely on Emacs default keybindings."
        (setq evil-want-integration t)
        (setq evil-want-C-u-scroll t)
        (setq evil-want-C-i-jump nil)
        (setq evil-want-minibuffer t)
        (setq evil-respect-visual-line-mode t)
        (setq evil-undo-system 'undo-fu)

-- 
2.39.2
Details
Message ID
<87r0ssw8zg.fsf@trop.in>
In-Reply-To
<20230410000206.22762-1-jgart@dismail.de> (view parent)
DKIM signature
missing
Download raw message
On 2023-04-09 19:02, jgart@dismail.de wrote:

> ---
>
> Hi,
>
> WDYT if we enable vim bindings in the minibuffer as well? Too evil?
>
> all best,
>
> jgart
>
>  src/contrib/features/emacs-xyz.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/contrib/features/emacs-xyz.scm b/src/contrib/features/emacs-xyz.scm
> index 577d1bd..75cd16a 100644
> --- a/src/contrib/features/emacs-xyz.scm
> +++ b/src/contrib/features/emacs-xyz.scm
> @@ -79,6 +79,7 @@ recommended RDE experience is to rely on Emacs default keybindings."
>          (setq evil-want-integration t)
>          (setq evil-want-C-u-scroll t)
>          (setq evil-want-C-i-jump nil)
> +        (setq evil-want-minibuffer t)
>          (setq evil-respect-visual-line-mode t)
>          (setq evil-undo-system 'undo-fu)

CCed Demis.

-- 
Best regards,
Andrew Tropin
Details
Message ID
<907508ad7d7717d24472d00dfe41c5d4@dismail.de>
In-Reply-To
<87r0ssw8zg.fsf@trop.in> (view parent)
DKIM signature
missing
Download raw message
Hi,

Just following up on this patch.

I find this feature very useful for me to be able to use modal editing in the minibuffer as well.

What do you think?

Should we make it the default or add an optional argument to the feature so that users can choose whether evil-mode is enabled in the minibuffer as well or not?

all best,

jgart
Details
Message ID
<87r0sj6v1u.fsf@trop.in>
In-Reply-To
<907508ad7d7717d24472d00dfe41c5d4@dismail.de> (view parent)
DKIM signature
missing
Download raw message
On 2023-04-15 20:55, jgart@dismail.de wrote:

> Hi,
>
> Just following up on this patch.
>
> I find this feature very useful for me to be able to use modal editing in the minibuffer as well.
>
> What do you think?
>
> Should we make it the default or add an optional argument to the feature so that users can choose whether evil-mode is enabled in the minibuffer as well or not?
>
> all best,
>
> jgart

Sligthly reworded commit message, applied, thank you for the patch.

Let us know if it breaks someones workflow.

-- 
Best regards,
Andrew Tropin
Details
Message ID
<87jzx1ua22.fsf@engstrand.nu>
In-Reply-To
<87r0ssw8zg.fsf@trop.in> (view parent)
DKIM signature
missing
Download raw message
<#secure method=pgpmime mode=sign>

Hi,

It might actually be a little to evil for my taste :)

Usually I exit out of M-x (and most other things) with <escape>, as I
rarely use C-g out of old habits. It would be nice to have a toggle
for this.


Best regards,
Johan Engstrand
Details
Message ID
<b33dc4bad514a6a8b1f8938e9f95e664@dismail.de>
In-Reply-To
<87jzx1ua22.fsf@engstrand.nu> (view parent)
DKIM signature
missing
Download raw message
Hi Johan,

I agree that a toggle would be nice as well. Feel free to send a patch for it.

I'm not using feature-emacs-evil anymore as I'm lately using cute fluffy modal editing that is less evil:

https://github.com/meow-edit/meow
Reply to thread Export thread (mbox)