~abcdw/rde-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
3 2

[PATCH] rde: fonts: Add font-liberation by default.

Details
Message ID
<20230913053332.11317-1-andrew@trop.in>
DKIM signature
missing
Download raw message
Patch: +4 -1
--- 
I want to include font-liberation in the list of default fonts in
feature-fonts.  The pros are: proper rendering of some PDFs and some sites
using Times New Roman and other questionable fonts.  The cons are: some sites,
would pick Helevetica (or some other font) if available instead of user's
preffered font.

WDYT?

 src/rde/features/fontutils.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/rde/features/fontutils.scm b/src/rde/features/fontutils.scm
index 5250876e..f0b1c3e5 100644
--- a/src/rde/features/fontutils.scm
+++ b/src/rde/features/fontutils.scm
@@ -88,7 +88,10 @@
          (emacs-fontaine emacs-fontaine)
          (use-serif-for-variable-pitch? #t)
          (extra-fontaine-presets '())
          (extra-font-packages (list font-gnu-unifont)))
          ;; font-liberation needed for proper rendering of sites/pdfs using
          ;; Times, Helvetica, Nimbus.  Use pdffonts from poppler to check
          ;; what fonts are needed for pdf.
          (extra-font-packages (list font-gnu-unifont font-liberation)))
  "Configure fonts.  DEFAULT-FONT-SIZE will be used for making
font-monospace default value, and it will be ignored if
#:font-monospace argument is specified."
-- 
2.41.0

[PATCH v2] rde: fonts: Add font-liberation by default.

Details
Message ID
<20230913060350.15248-1-andrew@trop.in>
In-Reply-To
<20230913053332.11317-1-andrew@trop.in> (view parent)
DKIM signature
missing
Download raw message
Patch: +4 -1
---
Changes since v1:
Slightly updated comment.

 src/rde/features/fontutils.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/rde/features/fontutils.scm b/src/rde/features/fontutils.scm
index 5250876e..d6d41296 100644
--- a/src/rde/features/fontutils.scm
+++ b/src/rde/features/fontutils.scm
@@ -88,7 +88,10 @@
          (emacs-fontaine emacs-fontaine)
          (use-serif-for-variable-pitch? #t)
          (extra-fontaine-presets '())
          (extra-font-packages (list font-gnu-unifont)))
          ;; font-liberation needed for proper rendering of sites/pdfs using
          ;; Times, Helvetica, Nimbus.  Use pdffonts from poppler package to
          ;; check what fonts are needed for pdf.
          (extra-font-packages (list font-gnu-unifont font-liberation)))
  "Configure fonts.  DEFAULT-FONT-SIZE will be used for making
font-monospace default value, and it will be ignored if
#:font-monospace argument is specified."
-- 
2.41.0

Re: [PATCH v2] rde: fonts: Add font-liberation by default.

Details
Message ID
<875y4dneyo.fsf@ngraves.fr>
In-Reply-To
<20230913060350.15248-1-andrew@trop.in> (view parent)
DKIM signature
missing
Download raw message
IIUC, the choice is between usability and customizability / minimalism.

I haven't noticed any major problem with pdfs or sites, but if you do, I
think usability in this case is more important for now. 

-- 
Best regards,
Nicolas Graves

Re: [PATCH v2] rde: fonts: Add font-liberation by default.

Details
Message ID
<87led7hjcc.fsf@trop.in>
In-Reply-To
<875y4dneyo.fsf@ngraves.fr> (view parent)
DKIM signature
missing
Download raw message
On 2023-09-14 13:58, Nicolas Graves wrote:

> IIUC, the choice is between usability and customizability / minimalism.
>
> I haven't noticed any major problem with pdfs or sites, but if you do, I
> think usability in this case is more important for now. 

Thank you for your note!  Marking as APPLIED, will push it soon.

-- 
Best regards,
Andrew Tropin
Reply to thread Export thread (mbox)