~abcdw/rde-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2 2

[PATCH rde] rde: base: Add options to keep drvs and outputs of live profiles

Details
Message ID
<20240726095545.31386-1-ngraves@ngraves.fr>
DKIM signature
pass
Download raw message
Patch: +5 -1
The previous `guix gc` configuration used to clear out derivations and
outputs of live profiles, which makes it a lot less convenient when
using `guix gc` to clear out old files, since you often have to
download them repeatedly. Add `guix-daemon` options to use options to
keep derivations and outputs of live profiles.

`guix gc` will clear out less files. If you want to reclaim more
space, you'll have to first delete old profiles.
---
 src/rde/features/base.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/rde/features/base.scm b/src/rde/features/base.scm
index 720315e4..16b21831 100644
--- a/src/rde/features/base.scm
+++ b/src/rde/features/base.scm
@@ -193,12 +193,15 @@ be a symbol, which will be used to construct feature name."
          (default-authorized-guix-keys %rde-default-authorized-guix-keys)
          (guix-substitute-urls '())
          (guix-authorized-keys '())
          (guix-daemon-extra-options
           (list "--gc-keep-derivations=yes" "--gc-keep-outputs=yes"))
          (udev-rules '())
          (base-system-services %rde-base-system-services))
  "Provides base system services."
  (ensure-pred list-of-services? base-system-services)
  (ensure-pred list-of-strings? guix-substitute-urls)
  (ensure-pred list-of-file-likes? guix-authorized-keys)
  (ensure-pred list-of-strings? guix-daemon-extra-options)
  (ensure-pred list-of-file-likes? udev-rules)

  (define (get-base-system-services cfg)
@@ -220,7 +223,8 @@ be a symbol, which will be used to construct feature name."
                           default-substitute-urls))
         (authorized-keys (append
                           guix-authorized-keys
                           default-authorized-guix-keys))))
                           default-authorized-guix-keys))
         (extra-options guix-daemon-extra-options)))
       (greetd-service-type
        config =>
        (greetd-configuration
-- 
2.45.2

[rde/patches/.build.yml] build success

builds.sr.ht <builds@sr.ht>
Details
Message ID
<D2ZDS9TSHSNW.S8AXL32SZSBS@fra01>
In-Reply-To
<20240726095545.31386-1-ngraves@ngraves.fr> (view parent)
DKIM signature
missing
Download raw message
rde/patches/.build.yml: SUCCESS in 3m15s

[rde: base: Add options to keep drvs and outputs of live profiles][0] from [Nicolas Graves][1]

[0]: https://lists.sr.ht/~abcdw/rde-devel/patches/54103
[1]: ngraves@ngraves.fr

✓ #1285908 SUCCESS rde/patches/.build.yml https://builds.sr.ht/~abcdw/job/1285908
Details
Message ID
<874j8c8guf.fsf@trop.in>
In-Reply-To
<20240726095545.31386-1-ngraves@ngraves.fr> (view parent)
DKIM signature
pass
Download raw message
On 2024-07-26 11:54, Nicolas Graves wrote:

> The previous `guix gc` configuration used to clear out derivations and
> outputs of live profiles, which makes it a lot less convenient when
> using `guix gc` to clear out old files, since you often have to
> download them repeatedly. Add `guix-daemon` options to use options to
> keep derivations and outputs of live profiles.
>
> `guix gc` will clear out less files. If you want to reclaim more
> space, you'll have to first delete old profiles.
> ---
>  src/rde/features/base.scm | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/rde/features/base.scm b/src/rde/features/base.scm
> index 720315e4..16b21831 100644
> --- a/src/rde/features/base.scm
> +++ b/src/rde/features/base.scm
> @@ -193,12 +193,15 @@ be a symbol, which will be used to construct feature name."
>            (default-authorized-guix-keys %rde-default-authorized-guix-keys)
>            (guix-substitute-urls '())
>            (guix-authorized-keys '())
> +          (guix-daemon-extra-options
> +           (list "--gc-keep-derivations=yes" "--gc-keep-outputs=yes"))
>            (udev-rules '())
>            (base-system-services %rde-base-system-services))
>    "Provides base system services."
>    (ensure-pred list-of-services? base-system-services)
>    (ensure-pred list-of-strings? guix-substitute-urls)
>    (ensure-pred list-of-file-likes? guix-authorized-keys)
> +  (ensure-pred list-of-strings? guix-daemon-extra-options)
>    (ensure-pred list-of-file-likes? udev-rules)
>  
>    (define (get-base-system-services cfg)
> @@ -220,7 +223,8 @@ be a symbol, which will be used to construct feature name."
>                             default-substitute-urls))
>           (authorized-keys (append
>                             guix-authorized-keys
> -                           default-authorized-guix-keys))))
> +                           default-authorized-guix-keys))
> +         (extra-options guix-daemon-extra-options)))
>         (greetd-service-type
>          config =>
>          (greetd-configuration

It was on my mind for years!)  Also, I know a few people, who even
modified the feature locally to support this.  Thank you very much for
making it "official"! :)

Marking as APPLIED.

-- 
Best regards,
Andrew Tropin
Reply to thread Export thread (mbox)