~abcdw/rde-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
3 3

[PATCH rde 0/1] rde: mail: Allow unset values

Details
Message ID
<20240726142649.27630-1-ngraves@ngraves.fr>
DKIM signature
pass
Download raw message
The recent update to get-value broke my mail feature, here's a fix.

Nicolas Graves (1):
  rde: mail: Allow unset emacs-ednc and gpg-primary-key values

 src/rde/features/mail.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.45.2

[PATCH rde 1/1] rde: mail: Allow unset emacs-ednc and gpg-primary-key values

Details
Message ID
<20240726142649.27630-2-ngraves@ngraves.fr>
In-Reply-To
<20240726142649.27630-1-ngraves@ngraves.fr> (view parent)
DKIM signature
pass
Download raw message
Patch: +2 -2
---
 src/rde/features/mail.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/rde/features/mail.scm b/src/rde/features/mail.scm
index c4a580c7..6ef20ac6 100644
--- a/src/rde/features/mail.scm
+++ b/src/rde/features/mail.scm
@@ -220,7 +220,7 @@ function, which accepts config with rde values and returns a string."
    (require-value 'emacs-client-create-frame config)
    (require-value 'full-name config)
    (define emacs-cmd (get-value 'emacs-client-create-frame config))
    (define gpg-primary-key (get-value 'gpg-primary-key config))
    (define gpg-primary-key (get-value 'gpg-primary-key config #f))
    (define msmtp (get-value 'msmtp config))
    (define full-name (get-value 'full-name config))

@@ -986,7 +986,7 @@ control whether to NOTIFY? when new emails arrive."
                            '())
                      ,@(if notify?
                            (cond
                             ((get-value 'emacs-ednc config)
                             ((get-value 'emacs-ednc config #f)
                              (list
                               (cons 'onNewMailPost
                                     #~(format
-- 
2.45.2

[rde/patches/.build.yml] build success

builds.sr.ht <builds@sr.ht>
Details
Message ID
<D2ZJJMXNU9PO.3JZAYUA3A4M56@fra01>
In-Reply-To
<20240726142649.27630-2-ngraves@ngraves.fr> (view parent)
DKIM signature
missing
Download raw message
rde/patches/.build.yml: SUCCESS in 3m8s

[rde: mail: Allow unset values][0] from [Nicolas Graves][1]

[0]: https://lists.sr.ht/~abcdw/rde-devel/patches/54111
[1]: ngraves@ngraves.fr

✓ #1286064 SUCCESS rde/patches/.build.yml https://builds.sr.ht/~abcdw/job/1286064

Re: [PATCH rde 1/1] rde: mail: Allow unset emacs-ednc and gpg-primary-key values

Details
Message ID
<87jzh86t1a.fsf@trop.in>
In-Reply-To
<20240726142649.27630-2-ngraves@ngraves.fr> (view parent)
DKIM signature
pass
Download raw message
On 2024-07-26 16:25, Nicolas Graves wrote:

> ---
>  src/rde/features/mail.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/rde/features/mail.scm b/src/rde/features/mail.scm
> index c4a580c7..6ef20ac6 100644
> --- a/src/rde/features/mail.scm
> +++ b/src/rde/features/mail.scm
> @@ -220,7 +220,7 @@ function, which accepts config with rde values and returns a string."
>      (require-value 'emacs-client-create-frame config)
>      (require-value 'full-name config)
>      (define emacs-cmd (get-value 'emacs-client-create-frame config))
> -    (define gpg-primary-key (get-value 'gpg-primary-key config))
> +    (define gpg-primary-key (get-value 'gpg-primary-key config #f))
>      (define msmtp (get-value 'msmtp config))
>      (define full-name (get-value 'full-name config))
>  
> @@ -986,7 +986,7 @@ control whether to NOTIFY? when new emails arrive."
>                              '())
>                        ,@(if notify?
>                              (cond
> -                             ((get-value 'emacs-ednc config)
> +                             ((get-value 'emacs-ednc config #f)
>                                (list
>                                 (cons 'onNewMailPost
>                                       #~(format

Thank you for the fix!  Merged.

-- 
Best regards,
Andrew Tropin
Reply to thread Export thread (mbox)