[PATCH rde] rde: goimapnotify: Add configuration file in ~/.config

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch

2 2

[PATCH rde] rde: goimapnotify: Add configuration file in ~/.config

Nicolas Graves <ngraves@ngraves.fr>

Details

Message ID: <20240910093613.26346-1-ngraves@ngraves.fr>
DKIM signature: pass

Download raw message

2 months ago

Patch: +10 -8

---
 src/rde/home/services/mail.scm | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/src/rde/home/services/mail.scm b/src/rde/home/services/mail.scm
index f3c3a982b..39bf60474 100644
--- a/src/rde/home/services/mail.scm
+++ b/src/rde/home/services/mail.scm
@@ -43,10 +43,11 @@
    (json-config '())
    "Alist of pairs that make up the @code{goimapnotify} configuration."))
 
-(define (home-goimapnotify-file config)
-  (apply mixed-text-file "imapnotify.conf"
-         (serialize-json-config
-          (home-goimapnotify-configuration-config config))))
+(define (add-home-goimapnotify-file config)
+  `(("goimapnotify/goimapnotify.conf"
+     ,(apply mixed-text-file "goimapnotify.conf"
+             (serialize-json-config
+              (home-goimapnotify-configuration-config config))))))
 
 (define (home-goimapnotify-shepherd-service config)
   (list
@@ -56,9 +57,7 @@
               (list
                #$(file-append
                   (home-goimapnotify-configuration-goimapnotify config)
-                  "/bin/goimapnotify")
-               "-conf"
-               #$(home-goimapnotify-file config))
+                  "/bin/goimapnotify"))
               #:log-file (string-append
                           (getenv "XDG_STATE_HOME") "/log"
                           "/goimapnotify.log")))
@@ -77,7 +76,10 @@
       home-goimapnotify-profile-service)
      (service-extension
       home-shepherd-service-type
-      home-goimapnotify-shepherd-service)))
+      home-goimapnotify-shepherd-service)
+     (service-extension
+      home-xdg-configuration-files-service-type
+      add-home-goimapnotify-file)))
    (default-value (home-goimapnotify-configuration))
    (description "Configures the @code{goimapnotify} IMAP Mailbox notifier.")))
 
-- 
2.46.0

[rde/patches/.build.yml] build success

builds.sr.ht <builds@sr.ht>

Details

Message ID: <D42IEC2D9R1D.15IFHSBSJ5YCA@fra01>
In-Reply-To: <20240910093613.26346-1-ngraves@ngraves.fr> (view parent)
DKIM signature: missing

Download raw message

2 months ago

rde/patches/.build.yml: SUCCESS in 13m49s

[rde: goimapnotify: Add configuration file in ~/.config][0] from [Nicolas Graves][1]

[0]: https://lists.sr.ht/~abcdw/rde-devel/patches/54973
[1]: ngraves@ngraves.fr

✓ #1324154 SUCCESS rde/patches/.build.yml https://builds.sr.ht/~abcdw/job/1324154

Andrew Tropin <andrew@trop.in>

Details

Message ID: <87zfodw26v.fsf@trop.in>
In-Reply-To: <20240910093613.26346-1-ngraves@ngraves.fr> (view parent)
DKIM signature: pass

Download raw message

2 months ago

On 2024-09-10 11:36, Nicolas Graves wrote:

> ---
>  src/rde/home/services/mail.scm | 18 ++++++++++--------
>  1 file changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/src/rde/home/services/mail.scm b/src/rde/home/services/mail.scm
> index f3c3a982b..39bf60474 100644
> --- a/src/rde/home/services/mail.scm
> +++ b/src/rde/home/services/mail.scm
> @@ -43,10 +43,11 @@
>     (json-config '())
>     "Alist of pairs that make up the @code{goimapnotify} configuration."))
>  
> -(define (home-goimapnotify-file config)
> -  (apply mixed-text-file "imapnotify.conf"
> -         (serialize-json-config
> -          (home-goimapnotify-configuration-config config))))
> +(define (add-home-goimapnotify-file config)
> +  `(("goimapnotify/goimapnotify.conf"
> +     ,(apply mixed-text-file "goimapnotify.conf"
> +             (serialize-json-config
> +              (home-goimapnotify-configuration-config config))))))
>  
>  (define (home-goimapnotify-shepherd-service config)
>    (list
> @@ -56,9 +57,7 @@
>                (list
>                 #$(file-append
>                    (home-goimapnotify-configuration-goimapnotify config)
> -                  "/bin/goimapnotify")
> -               "-conf"
> -               #$(home-goimapnotify-file config))
> +                  "/bin/goimapnotify"))
>                #:log-file (string-append
>                            (getenv "XDG_STATE_HOME") "/log"
>                            "/goimapnotify.log")))
> @@ -77,7 +76,10 @@
>        home-goimapnotify-profile-service)
>       (service-extension
>        home-shepherd-service-type
> -      home-goimapnotify-shepherd-service)))
> +      home-goimapnotify-shepherd-service)
> +     (service-extension
> +      home-xdg-configuration-files-service-type
> +      add-home-goimapnotify-file)))
>     (default-value (home-goimapnotify-configuration))
>     (description "Configures the @code{goimapnotify} IMAP Mailbox notifier.")))

Done, thank you!

-- 
Best regards,
Andrew Tropin