~abcdw/rde-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2 2

[PATCH rde] rde: Add feature-emacs-devdocs

Details
Message ID
<20240910135239.26929-1-ngraves@ngraves.fr>
DKIM signature
pass
Download raw message
Patch: +31 -1
---
 src/rde/features/emacs-xyz.scm | 32 +++++++++++++++++++++++++++++++-
 1 file changed, 31 insertions(+), 1 deletion(-)

diff --git a/src/rde/features/emacs-xyz.scm b/src/rde/features/emacs-xyz.scm
index b52f1e46c..5bf2fa5f6 100644
--- a/src/rde/features/emacs-xyz.scm
+++ b/src/rde/features/emacs-xyz.scm
@@ -3,7 +3,7 @@
;;; Copyright © 2022, 2023, 2024 Andrew Tropin <andrew@trop.in>
;;; Copyright © 2022 Samuel Culpepper <samuel@samuelculpepper.com>
;;; Copyright © 2022 Demis Balbach <db@minikn.xyz>
;;; Copyright © 2022, 2023 Nicolas Graves <ngraves@ngraves.fr>
;;; Copyright © 2022, 2023, 2024 Nicolas Graves <ngraves@ngraves.fr>
;;; Copyright © 2022, 2023 Miguel Ángel Moreno <me@mianmoreno.com>
;;; Copyright © 2023 Benoit Joly <benoit@benoitj.ca>
;;;
@@ -107,6 +107,7 @@
            feature-emacs-nov-el
            feature-emacs-elfeed
            feature-emacs-info
            feature-emacs-devdocs

            ;; Notetaking
            feature-emacs-org
@@ -4027,6 +4028,35 @@ built-in help that provides much more contextual information."
   (values `((,f-name . ,emacs-info-plus)))
   (home-services-getter get-home-services)))

(define* (feature-emacs-devdocs
          #:key
          (emacs-devdocs emacs-devdocs))
  "Configure Info-like documentation viewer for reading various
DevDocs documentations."
  (ensure-pred file-like? emacs-devdocs)

  (define emacs-f-name 'devdocs)
  (define f-name (symbol-append 'emacs- emacs-f-name))

  (define (get-home-services config)
    "Return home services related to DevDocs."
    (list
     (rde-elisp-configuration-service
      emacs-f-name
      config
      `((global-set-key (kbd "C-h D") 'devdocs-lookup)
        (autoload 'devdocs-lookup "devdocs")
        (with-eval-after-load 'devdocs
          (setq devdocs-data-dir
                (concat (getenv "XDG_STATE_HOME")
                        "/devdocs"))))
      #:elisp-packages (list emacs-devdocs))))

  (feature
   (name f-name)
   (values `((,f-name . ,emacs-devdocs)))
   (home-services-getter get-home-services)))


;;;
;;; Notetaking.
-- 
2.46.0

[rde/patches/.build.yml] build success

builds.sr.ht <builds@sr.ht>
Details
Message ID
<D42NT83J46D9.EPECSSXFQJJA@fra01>
In-Reply-To
<20240910135239.26929-1-ngraves@ngraves.fr> (view parent)
DKIM signature
missing
Download raw message
rde/patches/.build.yml: SUCCESS in 11m55s

[rde: Add feature-emacs-devdocs][0] from [Nicolas Graves][1]

[0]: https://lists.sr.ht/~abcdw/rde-devel/patches/54979
[1]: ngraves@ngraves.fr

✓ #1324305 SUCCESS rde/patches/.build.yml https://builds.sr.ht/~abcdw/job/1324305
Details
Message ID
<87ttelw1oz.fsf@trop.in>
In-Reply-To
<20240910135239.26929-1-ngraves@ngraves.fr> (view parent)
DKIM signature
fail
Download raw message
DKIM signature: fail
On 2024-09-10 15:52, Nicolas Graves wrote:

> ---
>  src/rde/features/emacs-xyz.scm | 32 +++++++++++++++++++++++++++++++-
>  1 file changed, 31 insertions(+), 1 deletion(-)
>
> diff --git a/src/rde/features/emacs-xyz.scm b/src/rde/features/emacs-xyz.scm
> index b52f1e46c..5bf2fa5f6 100644
> --- a/src/rde/features/emacs-xyz.scm
> +++ b/src/rde/features/emacs-xyz.scm
> @@ -3,7 +3,7 @@
>  ;;; Copyright © 2022, 2023, 2024 Andrew Tropin <andrew@trop.in>
>  ;;; Copyright © 2022 Samuel Culpepper <samuel@samuelculpepper.com>
>  ;;; Copyright © 2022 Demis Balbach <db@minikn.xyz>
> -;;; Copyright © 2022, 2023 Nicolas Graves <ngraves@ngraves.fr>
> +;;; Copyright © 2022, 2023, 2024 Nicolas Graves <ngraves@ngraves.fr>
>  ;;; Copyright © 2022, 2023 Miguel Ángel Moreno <me@mianmoreno.com>
>  ;;; Copyright © 2023 Benoit Joly <benoit@benoitj.ca>
>  ;;;
> @@ -107,6 +107,7 @@
>              feature-emacs-nov-el
>              feature-emacs-elfeed
>              feature-emacs-info
> +            feature-emacs-devdocs
>  
>              ;; Notetaking
>              feature-emacs-org
> @@ -4027,6 +4028,35 @@ built-in help that provides much more contextual information."
>     (values `((,f-name . ,emacs-info-plus)))
>     (home-services-getter get-home-services)))
>  
> +(define* (feature-emacs-devdocs
> +          #:key
> +          (emacs-devdocs emacs-devdocs))
> +  "Configure Info-like documentation viewer for reading various
> +DevDocs documentations."
> +  (ensure-pred file-like? emacs-devdocs)
> +
> +  (define emacs-f-name 'devdocs)
> +  (define f-name (symbol-append 'emacs- emacs-f-name))
> +
> +  (define (get-home-services config)
> +    "Return home services related to DevDocs."
> +    (list
> +     (rde-elisp-configuration-service
> +      emacs-f-name
> +      config
> +      `((global-set-key (kbd "C-h D") 'devdocs-lookup)
> +        (autoload 'devdocs-lookup "devdocs")
> +        (with-eval-after-load 'devdocs
> +          (setq devdocs-data-dir
> +                (concat (getenv "XDG_STATE_HOME")
> +                        "/devdocs"))))
> +      #:elisp-packages (list emacs-devdocs))))
> +
> +  (feature
> +   (name f-name)
> +   (values `((,f-name . ,emacs-devdocs)))
> +   (home-services-getter get-home-services)))
> +
>  
>  ;;;
>  ;;; Notetaking.

Applied, thank you!

-- 
Best regards,
Andrew Tropin
Reply to thread Export thread (mbox)