~abcdw/rde-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2 2

[PATCH] rde: postgresql: Add extension-packages option

Nicolas Graves <ngraves@ngraves.fr>
Details
Message ID
<20241019093010.22546-1-ngraves@ngraves.fr>
DKIM signature
pass
Download raw message
a month ago
Patch: +5 -2 
---
 src/rde/features/databases.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/rde/features/databases.scm b/src/rde/features/databases.scm
index cd339297..b7e19b47 100644
--- a/src/rde/features/databases.scm
+++ b/src/rde/features/databases.scm
@@ -42,9 +42,11 @@
(define* (feature-postgresql
          #:key
          (postgresql postgresql)
          (extension-packages extension-packages)
          (postgresql-roles #f))
  "Configure the PostgreSQL relational database."
  (ensure-pred any-package? postgresql)
  (ensure-pred file-like? postgresql)
  (ensure-pred list-of-file-likes? extension-packages)
  (ensure-pred maybe-list-of-postgresql-roles? postgresql-roles)

  (define f-name 'postgresql)
@@ -55,7 +57,8 @@
     (list
      (service postgresql-service-type
               (postgresql-configuration
                (postgresql postgresql))))
                (postgresql postgresql)
                (extension-packages extension-packages))))
     (if postgresql-roles
         (list
          (service postgresql-role-service-type
-- 
2.46.0

[PATCH v2] rde: postgresql: Add extension-packages option

Nicolas Graves <ngraves@ngraves.fr>
Details
Message ID
<20241021103656.21322-1-ngraves@ngraves.fr>
In-Reply-To
<20241019093010.22546-1-ngraves@ngraves.fr> (view parent)
DKIM signature
pass
Download raw message
a month ago
Patch: +5 -2 
---
 src/rde/features/databases.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/rde/features/databases.scm b/src/rde/features/databases.scm
index cd339297..ce5244d0 100644
--- a/src/rde/features/databases.scm
+++ b/src/rde/features/databases.scm
@@ -42,9 +42,11 @@
(define* (feature-postgresql
          #:key
          (postgresql postgresql)
          (extension-packages '())
          (postgresql-roles #f))
  "Configure the PostgreSQL relational database."
  (ensure-pred any-package? postgresql)
  (ensure-pred file-like? postgresql)
  (ensure-pred list-of-file-likes? extension-packages)
  (ensure-pred maybe-list-of-postgresql-roles? postgresql-roles)

  (define f-name 'postgresql)
@@ -55,7 +57,8 @@
     (list
      (service postgresql-service-type
               (postgresql-configuration
                (postgresql postgresql))))
                (postgresql postgresql)
                (extension-packages extension-packages))))
     (if postgresql-roles
         (list
          (service postgresql-role-service-type
-- 
2.46.0

Re: [PATCH v2] rde: postgresql: Add extension-packages option

Andrew Tropin <andrew@trop.in>
Details
Message ID
<87msirb7rv.fsf@trop.in>
In-Reply-To
<20241021103656.21322-1-ngraves@ngraves.fr> (view parent)
DKIM signature
pass
Download raw message
a month ago 
On 2024-10-21 12:36, Nicolas Graves wrote:

> ---
>  src/rde/features/databases.scm | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/src/rde/features/databases.scm b/src/rde/features/databases.scm
> index cd339297..ce5244d0 100644
> --- a/src/rde/features/databases.scm
> +++ b/src/rde/features/databases.scm
> @@ -42,9 +42,11 @@
>  (define* (feature-postgresql
>            #:key
>            (postgresql postgresql)
> +          (extension-packages '())
>            (postgresql-roles #f))
>    "Configure the PostgreSQL relational database."
> -  (ensure-pred any-package? postgresql)
> +  (ensure-pred file-like? postgresql)
> +  (ensure-pred list-of-file-likes? extension-packages)
>    (ensure-pred maybe-list-of-postgresql-roles? postgresql-roles)
>  
>    (define f-name 'postgresql)
> @@ -55,7 +57,8 @@
>       (list
>        (service postgresql-service-type
>                 (postgresql-configuration
> -                (postgresql postgresql))))
> +                (postgresql postgresql)
> +                (extension-packages extension-packages))))
>       (if postgresql-roles
>           (list
>            (service postgresql-role-service-type

Applied, thank you! 

-- 
Best regards,
Andrew Tropin
Reply to thread Export thread (mbox)