~abcdw/rde-devel

4 2

Typo in (ares-extension ares extension) module

Details
Message ID
<871q3ictht.fsf@disroot.org>
DKIM signature
pass
Download raw message
Hi,

There's a typo in the line
https://git.sr.ht/~abcdw/guile-ares-rs/tree/master/src/guile/ares-extension/ares/extension.scm#L85,
it should be (assoc-ref operations operation)

-- 
Best regards,
Aleksandr Vityazev
Details
Message ID
<877cd9tshj.fsf@disroot.org>
In-Reply-To
<871q3ictht.fsf@disroot.org> (view parent)
DKIM signature
pass
Download raw message
Also on the line
https://git.sr.ht/~abcdw/guile-ares-rs/tree/master/src/guile/ares-extension/ares/extension.scm#L45
should be (extensions-atom (assoc-ref state 'extensions))

-- 
Best regards,
Aleksandr Vityazev
Details
Message ID
<87ttgcvfy0.fsf@trop.in>
In-Reply-To
<877cd9tshj.fsf@disroot.org> (view parent)
DKIM signature
pass
Download raw message
On 2024-07-25 18:13, Aleksandr Vityazev wrote:

> Also on the line
> https://git.sr.ht/~abcdw/guile-ares-rs/tree/master/src/guile/ares-extension/ares/extension.scm#L45
> should be (extensions-atom (assoc-ref state 'extensions))

Thank you for reports, I forgot to commit updates :)
It should be fixed in https://git.sr.ht/~abcdw/guile-ares-rs/commit/ed1d0a2

Let me know if you find any other problems!

-- 
Best regards,
Andrew Tropin
Details
Message ID
<87zfq4wctc.fsf@disroot.org>
In-Reply-To
<87ttgcvfy0.fsf@trop.in> (view parent)
DKIM signature
pass
Download raw message
On 2024-07-26 10:13, Andrew Tropin wrote:

> On 2024-07-25 18:13, Aleksandr Vityazev wrote:
>
>> Also on the line
>> https://git.sr.ht/~abcdw/guile-ares-rs/tree/master/src/guile/ares-extension/ares/extension.scm#L45
>> should be (extensions-atom (assoc-ref state 'extensions))
>
> Thank you for reports, I forgot to commit updates :)
> It should be fixed in https://git.sr.ht/~abcdw/guile-ares-rs/commit/ed1d0a2
>
> Let me know if you find any other problems!
Thanks for the fixes.

In the previous describe version I can get ops, but in the current one I
always get nil. Am I missing something?

#+begin_src elisp
(arei-client-send-sync-request
 (arei-nrepl-dict "op" "describe")
 (arei--tooling-session-id))
#+end_src

Result: (dict "id" "60" "session" "e83f37c7-3b04-424d-82d3-5e882ffec79f"
"ops" nil "extensions" ("ares.logging" "ares.guile.macroexpansion"
"ares.core" "ares.bencode" "ares.extension" "ares.guile.utils"
"nrepl.completion" "nrepl.evaluation" "nrepl.lookup" "nrepl.session")
"status" ("done"))

If you remove list->vector from ("ops" . ,(list->vector
(get-operations-directory extensions))), everything will be fine

-- 
Best regards,
Aleksandr Vityazev
Details
Message ID
<87msm46uov.fsf@trop.in>
In-Reply-To
<87zfq4wctc.fsf@disroot.org> (view parent)
DKIM signature
pass
Download raw message
On 2024-07-26 15:35, Aleksandr Vityazev wrote:

> On 2024-07-26 10:13, Andrew Tropin wrote:
>
>> On 2024-07-25 18:13, Aleksandr Vityazev wrote:
>>
>>> Also on the line
>>> https://git.sr.ht/~abcdw/guile-ares-rs/tree/master/src/guile/ares-extension/ares/extension.scm#L45
>>> should be (extensions-atom (assoc-ref state 'extensions))
>>
>> Thank you for reports, I forgot to commit updates :)
>> It should be fixed in https://git.sr.ht/~abcdw/guile-ares-rs/commit/ed1d0a2
>>
>> Let me know if you find any other problems!
> Thanks for the fixes.
>
> In the previous describe version I can get ops, but in the current one I
> always get nil. Am I missing something?
>
> #+begin_src elisp
> (arei-client-send-sync-request
>  (arei-nrepl-dict "op" "describe")
>  (arei--tooling-session-id))
> #+end_src
>
> Result: (dict "id" "60" "session" "e83f37c7-3b04-424d-82d3-5e882ffec79f"
> "ops" nil "extensions" ("ares.logging" "ares.guile.macroexpansion"
> "ares.core" "ares.bencode" "ares.extension" "ares.guile.utils"
> "nrepl.completion" "nrepl.evaluation" "nrepl.lookup" "nrepl.session")
> "status" ("done"))
>
> If you remove list->vector from ("ops" . ,(list->vector
> (get-operations-directory extensions))), everything will be fine

Woops, fixed in https://git.sr.ht/~abcdw/guile-ares-rs/commit/a11f745

-- 
Best regards,
Andrew Tropin
Reply to thread Export thread (mbox)