Hi Miguel,

I have a question about the following funtction
https://git.sr.ht/~abcdw/rde/tree/master/src/rde/features/emacs-xyz.scm#L1552.
Should it work from M-x or should it be called via embark? As it does
not work from M-x at the moment.

Also about this line:
https://git.sr.ht/~abcdw/rde/tree/master/src/rde/features/emacs-xyz.scm#L1560

As of emacs 27.1, return is deprecated, so you have to use either
cl-return or just finally return (string-join ...).

-- 
Best regards,
Aleksandr Vityazev

On 2023-12-09 11:42, Aleksandr Vityazev wrote:

> Hi Miguel,
>
> I have a question about the following funtction
> https://git.sr.ht/~abcdw/rde/tree/master/src/rde/features/emacs-xyz.scm#L1552.
> Should it work from M-x or should it be called via embark? As it does
> not work from M-x at the moment.
>
> Also about this line:
> https://git.sr.ht/~abcdw/rde/tree/master/src/rde/features/emacs-xyz.scm#L1560
>
> As of emacs 27.1, return is deprecated, so you have to use either
> cl-return or just finally return (string-join ...).

Wanted to check it out, but it seems that lines number have been
changed.

BTW, there is rde-get-link, which generates urls with commit in it.

-- 
Best regards,
Andrew Tropin

On 2024-07-26 17:02, Andrew Tropin wrote:

> On 2023-12-09 11:42, Aleksandr Vityazev wrote:
>
>> Hi Miguel,
>>
>> I have a question about the following funtction
>> https://git.sr.ht/~abcdw/rde/tree/master/src/rde/features/emacs-xyz.scm#L1552.
>> Should it work from M-x or should it be called via embark? As it does
>> not work from M-x at the moment.
>>
>> Also about this line:
>> https://git.sr.ht/~abcdw/rde/tree/master/src/rde/features/emacs-xyz.scm#L1560
>>
>> As of emacs 27.1, return is deprecated, so you have to use either
>> cl-return or just finally return (string-join ...).
>
> Wanted to check it out, but it seems that lines number have been
> changed.
>
> BTW, there is rde-get-link, which generates urls with commit in it.
I tried rde-git-link, but it generated a broken link:
https://git.sr.ht/~abcdw/rde/tree/69e92e2c92a29d04add42429b7c7b6d9e898a292/src/rde/features/emacs-xyz.scm#L1490

Currently function rde-browse-url-open-with-cookies
on line:
https://git.sr.ht/~abcdw/rde/tree/master/src/rde/features/emacs-xyz.scm#L1489

wrong finally clause:
https://git.sr.ht/~abcdw/rde/tree/master/src/rde/features/emacs-xyz.scm#L1498

-- 
Best regards,
Aleksandr Vityazev

On 2024-07-26 16:19, Aleksandr Vityazev wrote:

> On 2024-07-26 17:02, Andrew Tropin wrote:
>
>> On 2023-12-09 11:42, Aleksandr Vityazev wrote:
>>
>>> Hi Miguel,
>>>
>>> I have a question about the following funtction
>>> https://git.sr.ht/~abcdw/rde/tree/master/src/rde/features/emacs-xyz.scm#L1552.
>>> Should it work from M-x or should it be called via embark? As it does
>>> not work from M-x at the moment.
>>>
>>> Also about this line:
>>> https://git.sr.ht/~abcdw/rde/tree/master/src/rde/features/emacs-xyz.scm#L1560
>>>
>>> As of emacs 27.1, return is deprecated, so you have to use either
>>> cl-return or just finally return (string-join ...).
>>
>> Wanted to check it out, but it seems that lines number have been
>> changed.
>>
>> BTW, there is rde-get-link, which generates urls with commit in it.
> I tried rde-git-link, but it generated a broken link:
> https://git.sr.ht/~abcdw/rde/tree/69e92e2c92a29d04add42429b7c7b6d9e898a292/src/rde/features/emacs-xyz.scm#L1490

It's probably used the commit from local branch.

>
> Currently function rde-browse-url-open-with-cookies
> on line:
> https://git.sr.ht/~abcdw/rde/tree/master/src/rde/features/emacs-xyz.scm#L1489
>
> wrong finally clause:
> https://git.sr.ht/~abcdw/rde/tree/master/src/rde/features/emacs-xyz.scm#L1498

I don't use this feature at the moment, but feel free to send a patch
adjusting it.  I think Miguel will chime in case something is wrong with
it, also we always can roll it back.

-- 
Best regards,
Andrew Tropin