~abcdw/rde-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
1

[PATCH] feature-database: Export postgresql-role.

Details
Message ID
<87bke34aq1.fsf@ngraves.fr>
DKIM signature
missing
Download raw message
Patch: +2 -1
User experience is more simple if we don't have to add other modules than the
one provided with the feature in user configuration. Re-export postgresl-role
to avoid the need to load another module.
---
 src/rde/features/databases.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/rde/features/databases.scm b/src/rde/features/databases.scm
index 8ce16dd2..4a261fbe 100644
--- a/src/rde/features/databases.scm
+++ b/src/rde/features/databases.scm
@@ -29,7 +29,8 @@
  #:use-module (gnu services databases)
  #:use-module (srfi srfi-1)
  #:export (feature-postgresql
            feature-sqlite))
            feature-sqlite)
  #:re-export (postgresql-role))

(define-public (list-of-postgresql-roles? lst)
  (and (list? lst) (every postgresql-role? lst)))
-- 
2.41.0



-- 
Best regards,
Nicolas Graves
Details
Message ID
<87edixmdx7.fsf@trop.in>
In-Reply-To
<87bke34aq1.fsf@ngraves.fr> (view parent)
DKIM signature
missing
Download raw message
On 2023-09-15 19:17, Nicolas Graves wrote:

> User experience is more simple if we don't have to add other modules than the
> one provided with the feature in user configuration. Re-export postgresl-role
> to avoid the need to load another module.
> ---
>  src/rde/features/databases.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/rde/features/databases.scm b/src/rde/features/databases.scm
> index 8ce16dd2..4a261fbe 100644
> --- a/src/rde/features/databases.scm
> +++ b/src/rde/features/databases.scm
> @@ -29,7 +29,8 @@
>    #:use-module (gnu services databases)
>    #:use-module (srfi srfi-1)
>    #:export (feature-postgresql
> -            feature-sqlite))
> +            feature-sqlite)
> +  #:re-export (postgresql-role))
>  
>  (define-public (list-of-postgresql-roles? lst)
>    (and (list? lst) (every postgresql-role? lst)))
> -- 
> 2.41.0

Thank you for the patch and explanation!  Applied, reworded, pushed.

-- 
Best regards,
Andrew Tropin
Reply to thread Export thread (mbox)