~abcdw/rde-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
6 2

denote-link-buttonize-buffer not found

jgart <jgart@dismail.de>
Details
Message ID
<87ttafwt8m.fsf@dismail.de>
DKIM signature
pass
Download raw message
2 months ago 
Hi,

Just wanted to report a bug.

The following code path fails because:

run-hooks: Symbol’s function definition is void: denote-link-buttonize-buffer

https://git.sr.ht/~abcdw/rde/tree/master/item/src/rde/features/emacs-xyz.scm#L5229

I'll try to fix the issue when I find the time.

I had enabled feature-emacs-denote like this:

(feature-emacs-denote
     #:denote-directory "~/Documents/notes"
     #:denote-file-type 'text)
-- 
all the best,
jgart
jgart <jgart@dismail.de>
Details
Message ID
<87sepztwnu.fsf@dismail.de>
In-Reply-To
<87ttafwt8m.fsf@dismail.de> (view parent)
DKIM signature
pass
Download raw message
2 months ago 
Found the issue:

https://github.com/protesilaos/denote/blob/13eee398731f7da94ce5938e4e087a1a6203d2b1/denote.el#L4760

denote-link-buttonize-buffer is deprecated.

We should be using denote-fontify-links-mode instead.

-- 
all the best,
jgart

[PATCH] rde: features: emacs-xyz: Update deprecated denote API

jgart <jgart@dismail.de>
Details
Message ID
<20250103222734.64438-1-jgart@dismail.de>
In-Reply-To
<87sepztwnu.fsf@dismail.de> (view parent)
DKIM signature
pass
Download raw message
2 months ago
Patch: +12 -6 
---
 src/rde/features/emacs-xyz.scm | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/src/rde/features/emacs-xyz.scm b/src/rde/features/emacs-xyz.scm
index 2f076de0..c7515ca9 100644
--- a/src/rde/features/emacs-xyz.scm
+++ b/src/rde/features/emacs-xyz.scm
@@ -5225,11 +5225,6 @@ SPELLING-DICTIONARIES inside buffers of modes defined in FLYSPELL-HOOKS
              '((setq denote-date-prompt-use-org-read-date t))
              '((setq denote-date-prompt-use-org-read-date nil)))


        ,@(if (member denote-file-type '(text markdown-toml markdown-yaml))
              '((add-hook 'find-file-hook 'denote-link-buttonize-buffer))
              '())

        (setq denote-dired-directories (list denote-directory))

        (with-eval-after-load 'dired
@@ -5281,7 +5276,18 @@ stored in directory understood by project.el."
            (define-key map (kbd "C-c C-d C-i")
              'denote-link-dired-marked-notes)
            (define-key map (kbd "C-c C-d C-r")
              'denote-dired-rename-marked-files))))
              'denote-dired-rename-marked-files)))

        ,@(match denote-file-type
            ('text
             '((add-hook 'text-mode-hook 'denote-fontify-links-mode-maybe)))
            ((and (or 'markdown-toml 'markdown-yaml)
                  (get-value 'markdown config))
             '((add-hook 'markdown-mode-hook 'denote-fontify-links-mode-maybe)))
            (else '()))

        (with-eval-after-load 'denote
          (denote-fontify-links-mode-maybe)))

      #:keywords '(convenience)
      #:elisp-packages (list emacs-denote))))
-- 
2.47.1
jgart <jgart@dismail.de>
Details
Message ID
<87h66fr0qf.fsf@dismail.de>
In-Reply-To
<87sepztwnu.fsf@dismail.de> (view parent)
DKIM signature
pass
Download raw message
2 months ago 
Hi, this last patch fixes the issue.

I'll wait for Andrew to review it.
-- 
all the best,
jgart

[PATCH v2] rde: features: emacs-xyz: Update deprecated denote API

jgart <jgart@dismail.de>
Details
Message ID
<20250103223328.67191-1-jgart@dismail.de>
In-Reply-To
<87sepztwnu.fsf@dismail.de> (view parent)
DKIM signature
pass
Download raw message
2 months ago
Patch: +11 -8 
---
 src/rde/features/emacs-xyz.scm | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/src/rde/features/emacs-xyz.scm b/src/rde/features/emacs-xyz.scm
index 2f076de0..a3437ca3 100644
--- a/src/rde/features/emacs-xyz.scm
+++ b/src/rde/features/emacs-xyz.scm
@@ -5225,10 +5225,13 @@ SPELLING-DICTIONARIES inside buffers of modes defined in FLYSPELL-HOOKS
              '((setq denote-date-prompt-use-org-read-date t))
              '((setq denote-date-prompt-use-org-read-date nil)))


        ,@(if (member denote-file-type '(text markdown-toml markdown-yaml))
              '((add-hook 'find-file-hook 'denote-link-buttonize-buffer))
              '())
        ,@(match denote-file-type
            ('text
             '((add-hook 'text-mode-hook 'denote-fontify-links-mode-maybe)))
            ((and (or 'markdown-toml 'markdown-yaml)
                  (get-value 'markdown config))
             '((add-hook 'markdown-mode-hook 'denote-fontify-links-mode-maybe)))
            (else '()))

        (setq denote-dired-directories (list denote-directory))

@@ -5286,10 +5289,10 @@ stored in directory understood by project.el."
      #:keywords '(convenience)
      #:elisp-packages (list emacs-denote))))

    (feature
     (name f-name)
     (values `((,f-name . ,emacs-denote)))
     (home-services-getter get-home-services)))
  (feature
   (name f-name)
   (values `((,f-name . ,emacs-denote)))
   (home-services-getter get-home-services)))


;;;
-- 
2.47.1

Re: [PATCH v2] rde: features: emacs-xyz: Update deprecated denote API

Andrew Tropin <andrew@trop.in>
Details
Message ID
<871pwvrwqu.fsf@trop.in>
In-Reply-To
<20250103223328.67191-1-jgart@dismail.de> (view parent)
Sender timestamp
1737554617
DKIM signature
fail
Download raw message
2 months ago
DKIM signature: fail 
On 2025-01-03 16:33, jgart wrote:

> ---
>  src/rde/features/emacs-xyz.scm | 19 +++++++++++--------
>  1 file changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/src/rde/features/emacs-xyz.scm b/src/rde/features/emacs-xyz.scm
> index 2f076de0..a3437ca3 100644
> --- a/src/rde/features/emacs-xyz.scm
> +++ b/src/rde/features/emacs-xyz.scm
> @@ -5225,10 +5225,13 @@ SPELLING-DICTIONARIES inside buffers of modes defined in FLYSPELL-HOOKS
>                '((setq denote-date-prompt-use-org-read-date t))
>                '((setq denote-date-prompt-use-org-read-date nil)))
>  
> -
> -        ,@(if (member denote-file-type '(text markdown-toml markdown-yaml))
> -              '((add-hook 'find-file-hook 'denote-link-buttonize-buffer))
> -              '())
> +        ,@(match denote-file-type
> +            ('text
> +             '((add-hook 'text-mode-hook 'denote-fontify-links-mode-maybe)))
> +            ((and (or 'markdown-toml 'markdown-yaml)
> +                  (get-value 'markdown config))
> +             '((add-hook 'markdown-mode-hook 'denote-fontify-links-mode-maybe)))
> +            (else '()))
>  
>          (setq denote-dired-directories (list denote-directory))
>  
> @@ -5286,10 +5289,10 @@ stored in directory understood by project.el."
>        #:keywords '(convenience)
>        #:elisp-packages (list emacs-denote))))
>  
> -    (feature
> -     (name f-name)
> -     (values `((,f-name . ,emacs-denote)))
> -     (home-services-getter get-home-services)))
> +  (feature
> +   (name f-name)
> +   (values `((,f-name . ,emacs-denote)))
> +   (home-services-getter get-home-services)))
>  
>

Re: [PATCH v2] rde: features: emacs-xyz: Update deprecated denote API

Andrew Tropin <andrew@trop.in>
Details
Message ID
<87zfjjqi5q.fsf@trop.in>
In-Reply-To
<20250103223328.67191-1-jgart@dismail.de> (view parent)
Sender timestamp
1737554641
DKIM signature
fail
Download raw message
2 months ago
DKIM signature: fail 
On 2025-01-03 16:33, jgart wrote:

> ---
>  src/rde/features/emacs-xyz.scm | 19 +++++++++++--------
>  1 file changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/src/rde/features/emacs-xyz.scm b/src/rde/features/emacs-xyz.scm
> index 2f076de0..a3437ca3 100644
> --- a/src/rde/features/emacs-xyz.scm
> +++ b/src/rde/features/emacs-xyz.scm
> @@ -5225,10 +5225,13 @@ SPELLING-DICTIONARIES inside buffers of modes defined in FLYSPELL-HOOKS
>                '((setq denote-date-prompt-use-org-read-date t))
>                '((setq denote-date-prompt-use-org-read-date nil)))
>  
> -
> -        ,@(if (member denote-file-type '(text markdown-toml markdown-yaml))
> -              '((add-hook 'find-file-hook 'denote-link-buttonize-buffer))
> -              '())
> +        ,@(match denote-file-type
> +            ('text
> +             '((add-hook 'text-mode-hook 'denote-fontify-links-mode-maybe)))
> +            ((and (or 'markdown-toml 'markdown-yaml)
> +                  (get-value 'markdown config))
> +             '((add-hook 'markdown-mode-hook 'denote-fontify-links-mode-maybe)))
> +            (else '()))
>  
>          (setq denote-dired-directories (list denote-directory))
>  
> @@ -5286,10 +5289,10 @@ stored in directory understood by project.el."
>        #:keywords '(convenience)
>        #:elisp-packages (list emacs-denote))))
>  
> -    (feature
> -     (name f-name)
> -     (values `((,f-name . ,emacs-denote)))
> -     (home-services-getter get-home-services)))
> +  (feature
> +   (name f-name)
> +   (values `((,f-name . ,emacs-denote)))
> +   (home-services-getter get-home-services)))
>  
>
Reply to thread Export thread (mbox)