~abcdw/rde-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
1

[PATCH] rde: feature rofi: add option font.

Details
Message ID
<87y1u940wa.fsf@ngraves.fr>
DKIM signature
missing
Download raw message
Patch: +4 -1
---
 rde/features/xdisorg.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/rde/features/xdisorg.scm b/rde/features/xdisorg.scm
index 5125c7c..3f09b0e 100644
--- a/rde/features/xdisorg.scm
+++ b/rde/features/xdisorg.scm
@@ -18,12 +18,14 @@
          #:key
          (rofi rofi-wayland)
          (theme "Arc")
          (font "Iosevka Term 14")
          (show-icons? #t)
          (show-actions? #t)
          (default-application-launcher? #t))
  "Configure rofi."
  (ensure-pred any-package? rofi)
  (ensure-pred file-like-or-path? theme)
  (ensure-pred string? font)

  (define (get-home-services config)
    (list
@@ -43,7 +45,8 @@
            (kb-remove-word-back . "Control+w,Control+BackSpace")
            (kb-clear-line . "Control+slash")
            (kb-page-next . "Control+v")
            (kb-page-prev . "Alt+v")))
            (kb-page-prev . "Alt+v")
            (font . ,font)))
          ,#~(format #f "@theme \"~a\"" #$theme)))))))

  (feature
--
2.37.3

--
Best regards,
Nicolas Graves
Details
Message ID
<87tu4h36h5.fsf@trop.in>
In-Reply-To
<87y1u940wa.fsf@ngraves.fr> (view parent)
DKIM signature
pass
Download raw message
On 2022-09-24 10:44, Nicolas Graves wrote:

> ---
>  rde/features/xdisorg.scm | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/rde/features/xdisorg.scm b/rde/features/xdisorg.scm
> index 5125c7c..3f09b0e 100644
> --- a/rde/features/xdisorg.scm
> +++ b/rde/features/xdisorg.scm
> @@ -18,12 +18,14 @@
>            #:key
>            (rofi rofi-wayland)
>            (theme "Arc")
> +          (font "Iosevka Term 14")
>            (show-icons? #t)
>            (show-actions? #t)
>            (default-application-launcher? #t))
>    "Configure rofi."
>    (ensure-pred any-package? rofi)
>    (ensure-pred file-like-or-path? theme)
> +  (ensure-pred string? font)
>
>    (define (get-home-services config)
>      (list
> @@ -43,7 +45,8 @@
>              (kb-remove-word-back . "Control+w,Control+BackSpace")
>              (kb-clear-line . "Control+slash")
>              (kb-page-next . "Control+v")
> -            (kb-page-prev . "Alt+v")))
> +            (kb-page-prev . "Alt+v")
> +            (font . ,font)))
>            ,#~(format #f "@theme \"~a\"" #$theme)))))))
>
>    (feature
> --
> 2.37.3
>
> --
> Best regards,
> Nicolas Graves

Hi Nicolas,

good idea, but I implemented it slightly other way:
https://git.sr.ht/~abcdw/rde/commit/253118d

It just uses font-monospace if it available in rde values, it seems good
for consistency, but later we can provide something like (custom-font
#f), if it's really necessary to allow to change it to value different
from font-monospace.

-- 
Best regards,
Andrew Tropin
Reply to thread Export thread (mbox)