rde: git: Add switch for signoff. v1 NEEDS REVISION

jgart: 1
 rde: git: Add switch for signoff.

 1 files changed, 6 insertions(+), 0 deletions(-)
This just adds a switch to add signoff to the git config to make commits like here:


This patch hasn't been tested yet.

I was mostly proposing the idea.

I'll label my patches that are untested as DRAFT or untested in the future.

all best,

Export patchset (mbox)
How do I use this?

Copy & paste the following snippet into your terminal to import this patchset into git:

curl -s https://lists.sr.ht/~abcdw/rde-devel/patches/41399/mbox | git am -3
Learn more about email & git

[PATCH] rde: git: Add switch for signoff. Export this patch


hi, let me know if this is too happy path

 src/rde/features/version-control.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/rde/features/version-control.scm b/src/rde/features/version-control.scm
index 638394c..51b1008 100644
--- a/src/rde/features/version-control.scm
+++ b/src/rde/features/version-control.scm
@@ -13,6 +13,7 @@
(define* (feature-git
          (git git)
          (signoff-commits? #f)
          (sign-commits? #t)
          (git-gpg-sign-key #f)
          (git-send-email? #f)
@@ -20,6 +21,7 @@
  "Setup and configure Git."
  (ensure-pred any-package? git)
  (ensure-pred maybe-string? git-gpg-sign-key)
  (ensure-pred boolean? signoff-commits?)
  (ensure-pred boolean? sign-commits?)
  (ensure-pred boolean? git-send-email?)
  (ensure-pred list? extra-config)
@@ -54,6 +56,10 @@
              ,@(if sign-commits?
                    `((signingkey . ,gpg-sign-key))
             (,@(if signoff-commits?
                    '((signoff . #t))
             ;; diff3 makes it easier to solve conflicts with smerge, zdiff3
             ;; should make a conflict scope smaller, but guile-git fails if