rde: git: Add switch for signoff. v1 PROPOSED

jgart: 1
 rde: git: Add switch for signoff.

 1 files changed, 6 insertions(+), 0 deletions(-)

This just adds a switch to add signoff to the git config to make commits like here:

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=6ee8b5316cad2fb960227e42f1379b895a6caf5f

Hi,

This patch hasn't been tested yet.

I was mostly proposing the idea.

I'll label my patches that are untested as DRAFT or untested in the future.

all best,

jgart

[PATCH] rde: git: Add switch for signoff. Export this patch

---

hi, let me know if this is too happy path

 src/rde/features/version-control.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/rde/features/version-control.scm b/src/rde/features/version-control.scm
index 638394c..51b1008 100644
--- a/src/rde/features/version-control.scm
+++ b/src/rde/features/version-control.scm
@@ -13,6 +13,7 @@
 (define* (feature-git
           #:key
           (git git)
+          (signoff-commits? #f)
           (sign-commits? #t)
           (git-gpg-sign-key #f)
           (git-send-email? #f)
@@ -20,6 +21,7 @@
   "Setup and configure Git."
   (ensure-pred any-package? git)
   (ensure-pred maybe-string? git-gpg-sign-key)
+  (ensure-pred boolean? signoff-commits?)
   (ensure-pred boolean? sign-commits?)
   (ensure-pred boolean? git-send-email?)
   (ensure-pred list? extra-config)
@@ -54,6 +56,10 @@
               ,@(if sign-commits?
                     `((signingkey . ,gpg-sign-key))
                     '())))
+            (format
+             (,@(if signoff-commits?
+                    '((signoff . #t))
+                    '())))
             (merge
              ;; diff3 makes it easier to solve conflicts with smerge, zdiff3
              ;; should make a conflict scope smaller, but guile-git fails if

Andrew Tropin <andrew@trop.in>

3 months ago

Hi jgart,

Can you elaborate a little bit on the workflow this feature argument
needed in?

-- 
2.40.1