From Adnan Maolood to ~adnano/astronaut-devel
Thanks! To git@git.sr.ht:~adnano/astronaut 762f8a6..aa744e6 master -> master
From Adnan Maolood to ~adnano/astronaut-devel
On Thu May 26, 2022 at 2:41 PM EDT, phoebos wrote: > On Thu, May 26, 2022 at 13:15:25 -0400, Adnan Maolood wrote: > > I was not aware that there are strictly POSIX-compliant implementations > > of make. Do you have any examples? > > https://frippery.org/make is a nice one. But even if an extension is > supported by the two most popular implementations of make (GNU and > FreeBSD), that doesn't mean anything about support on other systems > (it's not standardised). Cool, thanks for the link.
From Adnan Maolood to ~sircmpwn/sr.ht-dev
Also update listssrht/process.py to trigger EMAIL_RECEIVED and PATCHSET_RECEIVED webhook events. --- api/graph/model/webhooks.go | 107 ++++++++ api/graph/schema.graphqls | 37 +++ api/graph/schema.resolvers.go | 252 ++++++++++++++++++ api/webhooks/webhooks.go | 79 ++++++ ...add_graphql_mailing_list_webhook_tables.py | 66 +++++ listssrht/process.py | 7 + 6 files changed, 548 insertions(+) create mode 100644 listssrht/alembic/versions/6deff4db061c_add_graphql_mailing_list_webhook_tables.py diff --git a/api/graph/model/webhooks.go b/api/graph/model/webhooks.go index 8bd08d1..d6dcc52 100644 [message trimmed]
From Adnan Maolood to ~adnano/astronaut-devel
On Wed May 25, 2022 at 10:42 PM EDT, phoebos wrote: > I previously sent a patch which claimed to make the Makefile > POSIX-compliant, but it didn't. Without this proposed patch, the Makefile > doesn't work for strictly POSIX-compliant implementations (which do > exist). However, you'd obviously not be alone in using non-standard > extensions. I was not aware that there are strictly POSIX-compliant implementations of make. Do you have any examples?
From Adnan Maolood to ~adnano/astronaut-devel
On Tue May 24, 2022 at 1:36 PM EDT, phoebos wrote: > A suffix in .SUFFIXES cannot contain more than one period itself, so the > rule for the manpage must be written explicitly rather than with > inference rules. Does this change improve the portability of the Makefile to other systems or implementations of make? I'm not sure I see the value of pursuing full POSIX compliance if we can instead make sure that the Makefile works on all/most systems.
From Adnan Maolood to ~sircmpwn/sr.ht-dev
Ensure that the user has access to the ticket/tracker when creating ticket/tracker webhooks. --- api/graph/schema.resolvers.go | 26 +++++++++++++++++++------- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/api/graph/schema.resolvers.go b/api/graph/schema.resolvers.go index 1d78707..3db67fb 100644 --- a/api/graph/schema.resolvers.go +++ b/api/graph/schema.resolvers.go @@ -2149,6 +2149,13 @@ func (r *mutationResolver) CreateTrackerWebhook(ctx context.Context, trackerID i return nil, fmt.Errorf("Cannot use non-HTTP or HTTPS URL") } [message trimmed]
From Adnan Maolood to ~sircmpwn/sr.ht-dev
Previously, we would only deliver tracker/ticket webhooks where the user ID matched the currently authenticated user, which meant that tracker/ticket webhooks for other users would not be delivered. This updates the tracker/ticket webhook filters to allow other users to receive webhook events while also ensuring that they have access to the tracker. --- api/webhooks/webhooks.go | 26 +++++++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/api/webhooks/webhooks.go b/api/webhooks/webhooks.go index 2608662..573b3e6 100644 --- a/api/webhooks/webhooks.go +++ b/api/webhooks/webhooks.go [message trimmed]
From Adnan Maolood to ~sircmpwn/sr.ht-dev
--- api/graph/schema.resolvers.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/graph/schema.resolvers.go b/api/graph/schema.resolvers.go index e4aa3ae..0886c89 100644 --- a/api/graph/schema.resolvers.go +++ b/api/graph/schema.resolvers.go @@ -1317,7 +1317,7 @@ func (r *userWebhookSubscriptionResolver) Deliveries(ctx context.Context, obj *m ReadOnly: true, }, func(tx *sql.Tx) error { d := (&model.WebhookDelivery{}). WithName(`profile`). WithName(`user`).[message trimmed]
From Adnan Maolood to ~sircmpwn/sr.ht-dev
--- v2: better commit message api/graph/schema.resolvers.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/graph/schema.resolvers.go b/api/graph/schema.resolvers.go index b9a52e7..1d78707 100644 --- a/api/graph/schema.resolvers.go +++ b/api/graph/schema.resolvers.go @@ -3266,7 +3266,7 @@ func (r *userWebhookSubscriptionResolver) Deliveries(ctx context.Context, obj *m ReadOnly: true, }, func(tx *sql.Tx) error { d := (&model.WebhookDelivery{}). [message trimmed]
From Adnan Maolood to ~sircmpwn/sr.ht-dev
--- api/graph/schema.resolvers.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/graph/schema.resolvers.go b/api/graph/schema.resolvers.go index b9a52e7..1d78707 100644 --- a/api/graph/schema.resolvers.go +++ b/api/graph/schema.resolvers.go @@ -3266,7 +3266,7 @@ func (r *userWebhookSubscriptionResolver) Deliveries(ctx context.Context, obj *m ReadOnly: true, }, func(tx *sql.Tx) error { d := (&model.WebhookDelivery{}). WithName(`profile`). WithName(`user`).[message trimmed]