~adnano/astronaut-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
5 2

[PATCH astronaut 0/1] Vim-familiar scrolling feature

Details
Message ID
<160495950073.15813.14935779136067873315-0@git.sr.ht>
DKIM signature
missing
Download raw message
Hi,

I really like your client. I'm not sure what your plans are for
keybindings, but since the Vim keys for scrolling up and down weren't
allocated and that's the way I like to operate terminal clients, I added
them in. In case you wanted to incorporate those, here's the patchset.
There weren't any tests so I didn't add any.

Thanks for this. I'll
probably keep using this until I finish my own client.

I have noticed
a bug where certificates aren't being saved. I think the path is wrong
for me:

`open /home/exastencil/.local/share/gemini/known_hosts: no
such file or directory`

I'll see if I can figure it out.

Regards,
Exa

Exa Stencil (1):
  Vim-familiar keybindings for line scrolling

 ui/context.go | 11 +++++++++++
 1 file changed, 11 insertions(+)

-- 
2.26.2

[PATCH astronaut 1/1] Vim-familiar keybindings for line scrolling

Details
Message ID
<160495950073.15813.14935779136067873315-1@git.sr.ht>
In-Reply-To
<160495950073.15813.14935779136067873315-0@git.sr.ht> (view parent)
DKIM signature
missing
Download raw message
Patch: +11 -0
From: Exa Stencil <git@exastencil.com>

---
 ui/context.go | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/ui/context.go b/ui/context.go
index 93e3a49..70106c1 100644
--- a/ui/context.go
+++ b/ui/context.go
@@ -166,6 +166,17 @@ func (c Context) HandleScrollEvent(event tcell.Event) bool {
			c.PgUp()
			c.Invalidate()
			return true
		case tcell.KeyRune:
			switch event.Rune() {
			case 'j':
				c.ScrollDown(1)
				c.Invalidate()
				return true
			case 'k':
				c.ScrollUp(1)
				c.Invalidate()
				return true
			}
		}
	case *tcell.EventMouse:
		if !c.Contains(event.Position()) {
-- 
2.26.2
Details
Message ID
<C6Z2YXTUNPY4.2R5VIQMUDMTVY@nitro>
In-Reply-To
<160495950073.15813.14935779136067873315-0@git.sr.ht> (view parent)
DKIM signature
missing
Download raw message
On Mon Nov 9, 2020 at 5:05 PM EST, ~exastencil wrote:
> Hi,
>
> I really like your client. I'm not sure what your plans are for
> keybindings, but since the Vim keys for scrolling up and down weren't
> allocated and that's the way I like to operate terminal clients, I added
> them in. In case you wanted to incorporate those, here's the patchset.
> There weren't any tests so I didn't add any.

I'll probably add these keybindings for now.
Eventually I want to make the keybindings configurable.

> I have noticed
> a bug where certificates aren't being saved. I think the path is wrong
> for me:
>
> `open /home/exastencil/.local/share/gemini/known_hosts: no
> such file or directory`

Fixed in the latest commit.

Re: [PATCH astronaut 1/1] Vim-familiar keybindings for line scrolling

Details
Message ID
<C6Z33XI0NKHK.2SVN7OLQE8ZJF@nitro>
In-Reply-To
<160495950073.15813.14935779136067873315-1@git.sr.ht> (view parent)
DKIM signature
missing
Download raw message
Thanks!

To git.sr.ht:/~adnano/astronaut
   593409f..6385168  master -> master

Re: [PATCH astronaut 1/1] Vim-familiar keybindings for line scrolling

Details
Message ID
<C6ZAOWJ01VZ7.24H9BCWLIP00P@nitro>
In-Reply-To
<160495950073.15813.14935779136067873315-1@git.sr.ht> (view parent)
DKIM signature
missing
Download raw message
I implemented configurable keybindings and added an example
configuration in binds/binds.conf.

You can put this in ~/.local/share/astronaut/binds.conf and change it to
suit your tastes.

Re: [PATCH astronaut 1/1] Vim-familiar keybindings for line scrolling

Details
Message ID
<C6ZB400BBK2N.ID0VK9UGJ2PM@nitro>
In-Reply-To
<C6ZAOWJ01VZ7.24H9BCWLIP00P@nitro> (view parent)
DKIM signature
missing
Download raw message
On Mon Nov 9, 2020 at 6:22 PM EST, Adnan Maolood wrote:
> You can put this in ~/.local/share/astronaut/binds.conf and change it to
> suit your tastes.

Sorry, that should be ~/.config/astronaut/binds.conf
Reply to thread Export thread (mbox)