~adnano/astronaut-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
5 2

[PATCH 1/2] doc: Correct scroll description

Details
Message ID
<20211103214637.1228117-1-b@torresjrjr.com>
DKIM signature
pass
Download raw message
Patch: +1 -1
---
 doc/astronaut.1.scd | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/astronaut.1.scd b/doc/astronaut.1.scd
index 579e29e..2c5d72d 100644
--- a/doc/astronaut.1.scd
+++ b/doc/astronaut.1.scd
@@ -71,7 +71,7 @@ The following commands are supported:
	If _top_ or _bottom_ is specified, moves to the top or bottom of the page
	respectively.

	If specified as a number, the page is moved by that number of columns. If
	If specified as a number, the page is moved by that number of lines. If
	specified as a percentage, the page is moved by that percentage of the
	visible page height. Positive values scroll down and negative values scroll
	up.
-- 
2.33.1

[PATCH 2/2] config: Add scroll bindings u and d

Details
Message ID
<20211103214637.1228117-2-b@torresjrjr.com>
In-Reply-To
<20211103214637.1228117-1-b@torresjrjr.com> (view parent)
DKIM signature
pass
Download raw message
Patch: +3 -1
---
A subjective patch. I found u and d unused, so:

- In vi/vim, ^U and ^D are used for full-page scrolling,
  typically a nuisance, and already purposed by PGUP and PGDN.
  I often `8^D^D^D...` or `8^U^U^U...`
  (my middle finger reaches 8 the easiest).

- In browser plugins like vimium-C,
  u and d are used for "fast scrolling",
  which I personally use extensively.
  Perhaps others are used to this too.

So I thought is would be sensible to make these defaults.


 config/astronaut.conf | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/config/astronaut.conf b/config/astronaut.conf
index 8cdd7c8..d12d0b8 100644
--- a/config/astronaut.conf
+++ b/config/astronaut.conf
@@ -32,10 +32,12 @@ bind J tab prev
bind K tab next
bind pgup scroll -100%
bind pgdn scroll 100%
bind u scroll -8
bind d scroll 8
bind up scroll -1
bind j scroll 1
bind down scroll 1
bind k scroll -1
bind j scroll 1
bind g scroll top
bind G scroll bottom
bind b bookmark
-- 
2.33.1
Details
Message ID
<CFH9D8NRB806.3TWE0H9WBKQEK@nitro>
In-Reply-To
<20211103214637.1228117-1-b@torresjrjr.com> (view parent)
DKIM signature
pass
Download raw message
Thanks!

To git@git.sr.ht:~adnano/astronaut
   947cfac..76965cd  master -> master

Re: [PATCH 2/2] config: Add scroll bindings u and d

Details
Message ID
<CFH9GJJYYKNK.16GSR4NMMR1ZY@nitro>
In-Reply-To
<20211103214637.1228117-2-b@torresjrjr.com> (view parent)
DKIM signature
pass
Download raw message
On Wed Nov 3, 2021 at 5:46 PM EDT, Byron Torres wrote:
> A subjective patch. I found u and d unused, so:
>
> - In vi/vim, ^U and ^D are used for full-page scrolling,
> typically a nuisance, and already purposed by PGUP and PGDN.
> I often `8^D^D^D...` or `8^U^U^U...`
> (my middle finger reaches 8 the easiest).
>
> - In browser plugins like vimium-C,
> u and d are used for "fast scrolling",
> which I personally use extensively.
> Perhaps others are used to this too.
>
> So I thought is would be sensible to make these defaults.

I'm not sure if these should be in the default configuration. I'm
leaving them out for now.

Re: [PATCH 2/2] config: Add scroll bindings u and d

Details
Message ID
<CFHCHQ41KEIP.ASWP8YPHFKAC@ace>
In-Reply-To
<CFH9GJJYYKNK.16GSR4NMMR1ZY@nitro> (view parent)
DKIM signature
pass
Download raw message
On Thu Nov 4, 2021 at 8:00 PM GMT, Adnan Maolood wrote:
> On Wed Nov 3, 2021 at 5:46 PM EDT, Byron Torres wrote:
> > A subjective patch. I found u and d unused, so:
> >
> > 	bind u scroll -8
> > 	bind d scroll 8
>
> I'm not sure if these should be in the default configuration. I'm
> leaving them out for now.

Would you mind saying explicitly why? I don't want to leave it to
assumption. Any reason why u and d are special? Or is it something else?

Re: [PATCH 2/2] config: Add scroll bindings u and d

Details
Message ID
<CFLO1CFMLIVF.395X7DIR181RC@nitro>
In-Reply-To
<CFHCHQ41KEIP.ASWP8YPHFKAC@ace> (view parent)
DKIM signature
pass
Download raw message
On Thu Nov 4, 2021 at 6:23 PM EDT, Byron Torres wrote:
> On Thu Nov 4, 2021 at 8:00 PM GMT, Adnan Maolood wrote:
> > On Wed Nov 3, 2021 at 5:46 PM EDT, Byron Torres wrote:
> > > A subjective patch. I found u and d unused, so:
> > >
> > > 	bind u scroll -8
> > > 	bind d scroll 8
> >
> > I'm not sure if these should be in the default configuration. I'm
> > leaving them out for now.
>
> Would you mind saying explicitly why? I don't want to leave it to
> assumption. Any reason why u and d are special? Or is it something else?

I think that the default configuration should be viewed more like a
template, and that users should be encouraged to customize it to their
taste. I also want to be conservative in adding keybindings in case new
commands are added in the future (e.g. go to root, go to parent
directory, etc.)
Reply to thread Export thread (mbox)