~adnano/astronaut-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
6 2

[PATCH] browser: Fix follow mode freeze on enter

Details
Message ID
<20211125161207.163164-1-b@torresjrjr.com>
DKIM signature
pass
Download raw message
Patch: +6 -8
astronaut would freeze indefinitely when the user would press Enter in
hint/follow mode.
---

Not sure if this is a correct solution, but it seems to work.


 browser.go | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/browser.go b/browser.go
index e933dbc..14ab72a 100644
--- a/browser.go
@@ -320,14 +320,12 @@ func (b *Browser) Event(event tcell.Event) {

		switch event := event.(type) {
		case *ui.EventTextInput:
			if event.NoInput() {
				b.mode = ModeNormal
				b.hint = ""
				b.hints = nil
				b.hintlen = 0
				b.view.Invalidate()
				return
			}
			b.mode = ModeNormal
			b.hint = ""
			b.hints = nil
			b.hintlen = 0
			b.view.Invalidate()
			return

		case *ui.EventTextEdit:
			s := event.Text()
-- 
2.34.0
Details
Message ID
<CFYZZG3XGJG3.220E9O4L3K24N@nitro>
In-Reply-To
<20211125161207.163164-1-b@torresjrjr.com> (view parent)
DKIM signature
pass
Download raw message
Thanks!

To git@git.sr.ht:~adnano/astronaut
   c36219a..c854ee4  master -> master

On Thu Nov 25, 2021 at 11:12 AM EST, Byron Torres wrote:
> Not sure if this is a correct solution, but it seems to work.

The input handling design probably needs to be overhauled someday, but
this will work for now.
Details
Message ID
<CFZ013EQ047Z.2OKN69WUXZBWN@ace>
In-Reply-To
<CFYZZG3XGJG3.220E9O4L3K24N@nitro> (view parent)
DKIM signature
pass
Download raw message
On Thu Nov 25, 2021 at 4:22 PM GMT, Adnan Maolood wrote:
> Thanks!
>
> To git@git.sr.ht:~adnano/astronaut
> c36219a..c854ee4 master -> master
>
> On Thu Nov 25, 2021 at 11:12 AM EST, Byron Torres wrote:
> > Not sure if this is a correct solution, but it seems to work.
>
> The input handling design probably needs to be overhauled someday, but
> this will work for now.

I can't help but think you originally wanted this browser to be simple
and minimal, and now it's inching towards becoming turing complete with
it's own key command syntax. Blink once more and it'll have an entire
plugin ecosystem :P

Emacsification is real.
Details
Message ID
<CFZ05XAX5LNU.116UWN10OG842@nitro>
In-Reply-To
<CFZ013EQ047Z.2OKN69WUXZBWN@ace> (view parent)
DKIM signature
pass
Download raw message
On Thu Nov 25, 2021 at 11:25 AM EST, Byron Torres wrote:
> I can't help but think you originally wanted this browser to be simple
> and minimal, and now it's inching towards becoming turing complete with
> it's own key command syntax. Blink once more and it'll have an entire
> plugin ecosystem :P
>
> Emacsification is real.

Ha, I hope not! :P

At this point I think I am just going to polish the existing features
and release version 0.1.0.
Details
Message ID
<CFZ0AOBNSZUZ.BED5MOMZQMGI@ace>
In-Reply-To
<CFZ05XAX5LNU.116UWN10OG842@nitro> (view parent)
DKIM signature
pass
Download raw message
On Thu Nov 25, 2021 at 4:31 PM GMT, Adnan Maolood wrote:
> At this point I think I am just going to polish the existing features
> and release version 0.1.0.

fwiw, I think astronaut is a great Gemini browser (my favourite).

So I agree with your release plan. I personally think astronaut is
complete as it is. No "missing" features, especially with the
introduction of hints and the URL cli parameter. Perfect in the
Aristotelian sense.

Though, I disliked the removal of the ':' colon in the prompt (99ef06b
and elsewhere). Why the choice? Would you reconsider?
Details
Message ID
<CFZ0MBNANV6L.3ADUPKC9CHIG7@nitro>
In-Reply-To
<CFZ0AOBNSZUZ.BED5MOMZQMGI@ace> (view parent)
DKIM signature
pass
Download raw message
On Thu Nov 25, 2021 at 11:37 AM EST, Byron Torres wrote:
> Though, I disliked the removal of the ':' colon in the prompt (99ef06b
> and elsewhere). Why the choice? Would you reconsider?

I believe the original reason was to keep the message intact for 1X
server responses. I am willing to reconsider, though. The native browser
prompts can be changed.
Details
Message ID
<CFZ0UDK0EG2C.1EOQULILDJPC7@ace>
In-Reply-To
<CFZ0MBNANV6L.3ADUPKC9CHIG7@nitro> (view parent)
DKIM signature
pass
Download raw message
On Thu Nov 25, 2021 at 4:52 PM GMT, Adnan Maolood wrote:
> On Thu Nov 25, 2021 at 11:37 AM EST, Byron Torres wrote:
> > Though, I disliked the removal of the ':' colon in the prompt (99ef06b
> > and elsewhere). Why the choice? Would you reconsider?
>
> I believe the original reason was to keep the message intact for 1X
> server responses. I am willing to reconsider, though. The native browser
> prompts can be changed.

That makes sense. Perhaps we shouldn't change it then. I've also just
realised astronaut make the prompt message bold instead.

I've got other potential modifications in mind which deserve their own
thought out thread. Will write when ready.
Reply to thread Export thread (mbox)