Message-ID: <168f40100869c8be973256d404fc207b577a7ab3.camel@wetterberg.nu>
Subject: Re: Seeking feedback for version v0.1.15
From: Hugo Wetterberg <hugo@wetterberg.nu>
To: Adnan Maolood <me@adnano.co>, ~adnano/go-gemini-devel@lists.sr.ht
Cc: sir@cmpwn.com
Date: Mon, 22 Feb 2021 09:01:22 +0100
In-Reply-To: <C9F8NLU4P0RV.2LZR2635CQTFU@nitro>
References: <C9F8NLU4P0RV.2LZR2635CQTFU@nitro>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.4 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Great work! I haven't had time to kick the tires as much as Drew, but I
looked through the changes yesterday. Big thumbs up on adding contexts
to the handlers, I have been missing that. I also look forward to being
able to use the nice new embedding feature whenever resources need to be
bundled with the binary.

I understand Drews more measured approach to upgrades and new features,
but I think that in the case of Go it's mitigated by two things: the
language isn't volatile (unlike something like Rust) so upgrading in
itself isn't that much of a burden; and it's compiled so there are no
new runtimes with potential system-wide effects that need to be deployed
to production servers, the effect is limited to workstations & build
servers (that usally employs some container tech to create stable build
envs). There shouldn't be any kind of quasi-religious "move fast"
principle to adopting new Go releases, but in this case I think that
it's worth it to adopt the interfaces of the new fs package.

I'm luke-warm on the sub-packageification of the module, in small
projects like this it's usually not necessary, and just adds extra
imports for faux modularisation. Though that is probably primarily a
matter of personal taste and aesthetics, so ¯\_(ツ)_/¯

Most of all: thank you for your continued work on the project!