MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Sun, 21 Feb 2021 08:41:00 -0500
Message-Id: <C9F92JK69JJ7.9EHPJB5FIYNK@taiga>
Subject: Re: Seeking feedback for version v0.1.15
From: "Drew DeVault" <sir@cmpwn.com>
To: "Adnan Maolood" <me@adnano.co>, <~adnano/go-gemini-devel@lists.sr.ht>
Cc: <hugo@wetterberg.nu>
References: <C9F8NLU4P0RV.2LZR2635CQTFU@nitro>
In-Reply-To: <C9F8NLU4P0RV.2LZR2635CQTFU@nitro>

I love it. I based gemini://srht.pages on this WIP stuff. I'm looking
forward to updating it with contexts as well once you release those.

On Sun Feb 21, 2021 at 8:21 AM EST, Adnan Maolood wrote:
> The context provided to Handler.ServeGemini by the server will terminate
> when the request is terminated. This should make dealing with contexts
> much easier, at the cost of some verbosity and a long function
> signature.

You could also consider mimicking the net/http approach by stashing the
context in the Request type.

> - FileSystem replaced with io/fs.FS. This means we now require Go 1.16.

Already noticed this and worked around it, but I would like to humbly
request that in the future you take care with rushing in to adopt new Go
features. We run the latest Alpine stable in production and I prefer not
to pull down newer versions of packages unless it's strictly necessary.
They release biannually so the wait isn't too terribly long.

Anyway, nice work! I like the changes very much.