MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
From: "Adnan Maolood" <me@adnano.co>
To: "Drew DeVault" <sir@cmpwn.com>, <~adnano/go-gemini-devel@lists.sr.ht>
Cc: <hugo@wetterberg.nu>
Subject: Re: Seeking feedback for version v0.1.15
Date: Sun, 21 Feb 2021 08:45:11 -0500
Message-Id: <C9F95QSF7ERT.3FKWA5DJDO5XJ@nitro>
In-Reply-To: <C9F92JK69JJ7.9EHPJB5FIYNK@taiga>

On Sun Feb 21, 2021 at 8:41 AM EST, Drew DeVault wrote:
> I love it. I based gemini://srht.pages on this WIP stuff. I'm looking
> forward to updating it with contexts as well once you release those.

Thanks! You can try the new API in version v0.1.15-alpha.

> You could also consider mimicking the net/http approach by stashing the
> context in the Request type.

I could, however this makes creating derivative contexts more difficult.
One must call Request.Context(), and then call Request.WithContext with
the derived context, which must copy the request. Also note that the http
Handler API was in use before the introduction of contexts, so they had
to implement that API for backwards compatibility. Since we don't have
to worry about that yet, I think we can come up with a better approach.

Also, the documentation for the context package says:

	Do not store Contexts inside a struct type; instead, pass a Context
	explicitly to each function that needs it. The Context should be the
	first parameter, typically named ctx.

Another possible aproach would be to combine the ResponseWriter and
Request arguments into one.

> > - FileSystem replaced with io/fs.FS. This means we now require Go 1.16.
>
> Already noticed this and worked around it, but I would like to humbly
> request that in the future you take care with rushing in to adopt new Go
> features. We run the latest Alpine stable in production and I prefer not
> to pull down newer versions of packages unless it's strictly necessary.
> They release biannually so the wait isn't too terribly long.

I'll keep that in mind. I don't expect to adopt any new Go features
anytime soon.