~adnano/wmenu-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
7 2

[PATCH 1/2] README: add example how to use wmenu in sway

Details
Message ID
<20220415085045.36937-1-lemontree@subnet.email>
DKIM signature
missing
Download raw message
Patch: +9 -0
---
 README.md | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/README.md b/README.md
index 8ec32e64fe8e..0e03949037c8 100644
--- a/README.md
+++ b/README.md
@@ -23,6 +23,15 @@ $ ninja -C build

See wmenu(1)

after building and installing wmenu, you can configure your sway config like this:

```
# pass the final command to swaymsg so that window is opened on the
# original workspace that the command was run on.
set $menu dmenu_path | wmenu -p "Run:" -l 10 | xargs swaymsg exec
bindsym $mod+p exec $menu
```

## Credits

This project started as a fork of [dmenu-wl](https://github.com/nyyManni/dmenu-wayland).
-- 
2.35.2

[PATCH 2/2] README: add contributing section

Details
Message ID
<20220415085045.36937-2-lemontree@subnet.email>
In-Reply-To
<20220415085045.36937-1-lemontree@subnet.email> (view parent)
DKIM signature
missing
Download raw message
Patch: +11 -0
---
 README.md | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/README.md b/README.md
index 0e03949037c8..0ad0f8ddc424 100644
--- a/README.md
+++ b/README.md
@@ -32,6 +32,17 @@ set $menu dmenu_path | wmenu -p "Run:" -l 10 | xargs swaymsg exec
bindsym $mod+p exec $menu
```

## Contributing

Send patches and questions to [~adnano/wmenu-devel](https://lists.sr.ht/~adnano/wmenu-devel).

You can setup your git repo like so:
```
git config sendemail.to ~adnano/wmenu-devel@lists.sr.ht
```

Subscribe to release announcements on [~adnano/wmenu-announce](https://lists.sr.ht/~adnano/wmenu-announce).

## Credits

This project started as a fork of [dmenu-wl](https://github.com/nyyManni/dmenu-wayland).
-- 
2.35.2
Details
Message ID
<CJBL1EI3J0BT.V8SWOEGW1YU2@nitro>
In-Reply-To
<20220415085045.36937-1-lemontree@subnet.email> (view parent)
DKIM signature
missing
Download raw message
Hi, thanks for the patch!

On Fri Apr 15, 2022 at 4:50 AM EDT, lemontree wrote:
> ---
>  README.md | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/README.md b/README.md
> index 8ec32e64fe8e..0e03949037c8 100644
> --- a/README.md
> +++ b/README.md
> @@ -23,6 +23,15 @@ $ ninja -C build
>  
>  See wmenu(1)
>  
> +after building and installing wmenu, you can configure your sway config like this:
> +
> +```
> +# pass the final command to swaymsg so that window is opened on the
> +# original workspace that the command was run on.
> +set $menu dmenu_path | wmenu -p "Run:" -l 10 | xargs swaymsg exec
> +bindsym $mod+p exec $menu
> +```

I don't like this example very much, since the -l flag is currently
unimplemented. I might add my own example.

> +
>  ## Credits
>  
>  This project started as a fork of [dmenu-wl](https://github.com/nyyManni/dmenu-wayland).
> -- 
> 2.35.2

Re: [PATCH 2/2] README: add contributing section

Details
Message ID
<CJBL2TKVITN2.CJ0U0BYGX13H@nitro>
In-Reply-To
<20220415085045.36937-2-lemontree@subnet.email> (view parent)
DKIM signature
missing
Download raw message
On Fri Apr 15, 2022 at 4:50 AM EDT, lemontree wrote:
> ---
>  README.md | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/README.md b/README.md
> index 0e03949037c8..0ad0f8ddc424 100644
> --- a/README.md
> +++ b/README.md
> @@ -32,6 +32,17 @@ set $menu dmenu_path | wmenu -p "Run:" -l 10 | xargs swaymsg exec
>  bindsym $mod+p exec $menu
>  ```
>  
> +## Contributing
> +
> +Send patches and questions to [~adnano/wmenu-devel](https://lists.sr.ht/~adnano/wmenu-devel).
> +
> +You can setup your git repo like so:
> +```
> +git config sendemail.to ~adnano/wmenu-devel@lists.sr.ht
> +```

I don't think we should include this information here, as it is a
somewhat standard procedure, and repeating it in every project README
would be tiresome.

> +
> +Subscribe to release announcements on [~adnano/wmenu-announce](https://lists.sr.ht/~adnano/wmenu-announce).
> +
>  ## Credits
>  
>  This project started as a fork of [dmenu-wl](https://github.com/nyyManni/dmenu-wayland).
> -- 
> 2.35.2

Re: [PATCH 2/2] README: add contributing section

Details
Message ID
<CJBLXDED1V8D.1BXH14NBRZ1YS@debian-t400>
In-Reply-To
<CJBL2TKVITN2.CJ0U0BYGX13H@nitro> (view parent)
DKIM signature
missing
Download raw message
Hey,

On Sat Apr 16, 2022 at 12:14 PM CEST, Adnan Maolood wrote:
> > +## Contributing
> > +
> > +Send patches and questions to [~adnano/wmenu-devel](https://lists.sr.ht/~adnano/wmenu-devel).
> > +
> > +You can setup your git repo like so:
> > +```
> > +git config sendemail.to ~adnano/wmenu-devel@lists.sr.ht
> > +```
>
> I don't think we should include this information here, as it is a
> somewhat standard procedure, and repeating it in every project README
> would be tiresome.
>

I agree that this is a stnadard procedure and it is cumbersome. My
inspiration for writing this was emersion's projects. I liked it because
i search for such things to copy paste/click on stuff. It is faster
compared to searching it yourself.

So now, i have scripts which makes this configuration for the
contribution easier, but before that i searched always for the git
config lines i remembered from emersion's projects. So i think,
especially for people who are new to sourcehut/email driven development,
this might make sense.

And btw, wmenu is now included in the "i3 migration guide" on the sway
wiki:

* dmenu → wmenu, bemenu, fuzzel, gmenu, wldash

https://github.com/swaywm/sway/wiki/i3-Migration-Guide#common-x11-apps-used-on-i3-with-wayland-alternatives

Regards,
lemontree

Re: [PATCH 2/2] README: add contributing section

Details
Message ID
<CJBNDD02OZDX.TJUWDC89FID@nitro>
In-Reply-To
<CJBLXDED1V8D.1BXH14NBRZ1YS@debian-t400> (view parent)
DKIM signature
missing
Download raw message
On Sat Apr 16, 2022 at 6:54 AM EDT, lemontree wrote:
> I agree that this is a stnadard procedure and it is cumbersome. My
> inspiration for writing this was emersion's projects. I liked it because
> i search for such things to copy paste/click on stuff. It is faster
> compared to searching it yourself.
>
> So now, i have scripts which makes this configuration for the
> contribution easier, but before that i searched always for the git
> config lines i remembered from emersion's projects. So i think,
> especially for people who are new to sourcehut/email driven development,
> this might make sense.

It looks like emersion was placing this information in the mailing list
description, which seems like a more fitting place than the README.

>
> And btw, wmenu is now included in the "i3 migration guide" on the sway
> wiki:
>
> * dmenu → wmenu, bemenu, fuzzel, gmenu, wldash
>
> https://github.com/swaywm/sway/wiki/i3-Migration-Guide#common-x11-apps-used-on-i3-with-wayland-alternatives

Cool, thanks for letting me know!

Re: [PATCH 2/2] README: add contributing section

Details
Message ID
<CJBO7VNZ4GZ2.212XBO8375D0O@debian-t400>
In-Reply-To
<CJBNDD02OZDX.TJUWDC89FID@nitro> (view parent)
DKIM signature
missing
Download raw message
Hey,

On Sat Apr 16, 2022 at 2:02 PM CEST, Adnan Maolood wrote:
> > And btw, wmenu is now included in the "i3 migration guide" on the sway
> > wiki:
> >
> > * dmenu → wmenu, bemenu, fuzzel, gmenu, wldash
> >
> > https://github.com/swaywm/sway/wiki/i3-Migration-Guide#common-x11-apps-used-on-i3-with-wayland-alternatives
>
> Cool, thanks for letting me know!

i just noticed: wmenu is now also listed on https://arewewaylandyet.com/

Re: [PATCH 2/2] README: add contributing section

Details
Message ID
<CJCPEE4PJ7JD.16NTOGYCQDFRT@nitro>
In-Reply-To
<20220415085045.36937-2-lemontree@subnet.email> (view parent)
DKIM signature
missing
Download raw message
I've pushed a modified version of the second patch. I've also added the
git config command to the list description.

I will update the README with Sway-specific details in a separate
commit.

Thanks!

To git@git.sr.ht:~adnano/wmenu
   f40a473..ad11289  master -> master
Reply to thread Export thread (mbox)