~adnano/wmenu-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
3 2

[PATCH] add wmenu_run script, similar to dmenu_run script

Details
Message ID
<20240221173924.32099-1-sewn@disroot.org>
DKIM signature
pass
Download raw message
Patch: +10 -0
---
 meson.build | 2 ++
 wmenu_run   | 8 ++++++++
 2 files changed, 10 insertions(+)
 create mode 100755 wmenu_run

diff --git a/meson.build b/meson.build
index 2350694..951369a 100644
--- a/meson.build
+++ b/meson.build
@@ -33,6 +33,8 @@ rt = cc.find_library('rt')
subdir('protocols')
subdir('docs')

install_data('wmenu_run', install_dir: get_option('bindir'))

executable(
	'wmenu',
	files(
diff --git a/wmenu_run b/wmenu_run
new file mode 100755
index 0000000..16a2d3f
--- /dev/null
+++ b/wmenu_run
@@ -0,0 +1,8 @@
#!/bin/sh

IFS=:
for p in $PATH; do
	for e in $p/*; do
		[ -x $e ] && echo ${e##*/}
	done
done | sort -u | wmenu "$@" | ${SHELL:-"/bin/sh"} &
\ No newline at end of file
-- 
2.43.2
Details
Message ID
<CZJ9AKNT92PW.NZ4Y5CB334R1@maolood.com>
In-Reply-To
<20240221173924.32099-1-sewn@disroot.org> (view parent)
DKIM signature
pass
Download raw message
Hi, thanks for the patch! I'll have to hold back on applying this patch for a
bit. I'm still unsure about which approach I want to use to implement this.

See also previous discussion: https://lists.sr.ht/~adnano/wmenu-devel/patches/39820
Details
Message ID
<f8c84b2a8d8540c8775daa0d4b6c6415@disroot.org>
In-Reply-To
<CZJ9AKNT92PW.NZ4Y5CB334R1@maolood.com> (view parent)
DKIM signature
pass
Download raw message
On 2024-03-02 13:17, Adnan Maolood wrote:

> Hi, thanks for the patch! I'll have to hold back on applying this patch 
> for a
> bit. I'm still unsure about which approach I want to use to implement 
> this.
> 
> See also previous discussion: 
> https://lists.sr.ht/~adnano/wmenu-devel/patches/39820

I made this patch without knowing that a patch had already been made for 
implementing
wmenu_run.

Please instead merge this patch:
https://lists.sr.ht/~adnano/wmenu-devel/patches/39820

I have noticed a few things that aren't written concisely or simple 
enough so i will
just suggest some changes to the author.
Details
Message ID
<CZQ1ESK8MP7K.3EYHVHV2WZ8RM@maolood.com>
In-Reply-To
<f8c84b2a8d8540c8775daa0d4b6c6415@disroot.org> (view parent)
DKIM signature
pass
Download raw message
On Sat Mar 2, 2024 at 7:31 AM EST, sewn wrote:
> I have noticed a few things that aren't written concisely or simple 
> enough so i will
> just suggest some changes to the author.

Could you reply to that message with your suggestions? You could also send an
updated patch with the original author listed as a coauthor.
Reply to thread Export thread (mbox)