Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by mail-b.sr.ht (Postfix) with ESMTPS id C33CBFF0E1 for <~akarle/public-inbox@lists.sr.ht>; Mon, 3 Aug 2020 02:02:53 +0000 (UTC) Authentication-Results: mail-b.sr.ht; dkim=fail reason="key not found in DNS" (0-bit key) header.d=pswhite.org header.i=@pswhite.org header.b=Nr2w6Dxx Date: Sun, 2 Aug 2020 22:02:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pswhite.org; s=key1; t=1596420172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=e4/dUO00LnmFPdYwpQEIubB2PruB4rsj9YjuL80AiMs=; b=Nr2w6DxxXn8S0ms1hwhOsEijqb4vjC8jInDmaGGv3IDzaMzxKzuLpamSBLqEWOFgD67GAS hY15SNXZjMrmNfxpBPgibtSnjahtqfQCyubqFhrwWFqZd3hqvHrwZTm1LkQh/0YKX+v8k6 AikjVS1mKB/D4yPquASpPfdIOLObC6SqoOOhZUv6+UhJ/AFNeGZak0Fl9q8a1fZ+DkW0NR UYDMSSasz6Xy3OH3nWtnMzRlxoW5sWxTXwoE2Cplg2OBro19I1U+mi9LXWQO7stX+S/obw DPbW00Jz4lygK4IU2cNxt2oHGLhWanlKyyX7rBuDe4DfNeDUgRO4rxEGOUzEwA== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Philip White To: ~akarle/public-inbox@lists.sr.ht Subject: Thanks and feedback for euchre-live Message-ID: <20200802220248.38b69efe@mordor> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: 0.40 Hi, I just used http://euchre.live this evening. Thanks for making it! Overall I thought it worked pretty well. The one bug we ran into very frequently while playing was that the page would stop updating and could not perform any actions. I opened dev-tools in my browser while playing so that I could see if it would say anything when I got disconnected. Sure enough, the issue appears to be that the WebSocket got closed somehow, and that any messages sent over the wire could not be sent. To fix this, I believe you can add a callback whenever the websocket gets closed; in the callback, you can just try to reconnect. To make the user-experience better as well, you could show an indication on the page that the client is currently disconnected. Would you be interested in a patch to fix this? It might be better if you fixed it yourself, since you already have the dev environment setup and know how the project is structured (I've never used Perl before). Let me know which you would rather. As a counterpoint to this bug, we were still able to finish both of our games, since we could just refresh the page and join the game again. Thanks, Philip