From Aleksei Bavshin to ~kennylevinsen/greetd-devel
On Tue, Mar 5, 2024 at 3:25 PM Kenny Levinsen <kl@kl.wtf> wrote: > > On 3/5/24 11:55, Sertonix wrote: > > See https://www.shellcheck.net/wiki/SC2068 > > --- > > I forgot to add the patch in the last mail. > The blank mail was confusing indeed. :) > > > > index.md | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/index.md b/index.md > > index 931ea52..d27207f 100644 > > --- a/index.md
From Aleksei Bavshin to ~exec64/imv-devel
On Thu, Oct 19, 2023 at 8:19 AM Matěj Cepl <mcepl@cepl.eu> wrote: > > Hi, when trying to build imv package on openSUSE/Tumbleweed > (current version 4.4.0), I get tons of undefined references erros > when linking while files > > /usr/lib64/libfreeimage-3.19.0.so > /usr/lib64/libfreeimage.so.3 > /usr/lib64/libfreeimage.so > > are clearly present in the build system. > > Any idea what’s going on, please?
From Aleksei Bavshin to ~kennylevinsen/greetd-devel
Link the LICENSE file into the greetd_ipc crate to ensure that it appears in the crates.io archive. --- agreety/Cargo.toml | 2 +- fakegreet/Cargo.toml | 2 +- greetd/Cargo.toml | 2 +- greetd_ipc/Cargo.toml | 2 +- greetd_ipc/LICENSE | 1 + inish/Cargo.toml | 2 +- 6 files changed, 6 insertions(+), 5 deletions(-) create mode 120000 greetd_ipc/LICENSE diff --git a/agreety/Cargo.toml b/agreety/Cargo.toml index 2a27bed..075605c 100644 [message trimmed]
From Aleksei Bavshin to ~exec64/imv-devel
On 6/2/23 00:58, builds.sr.ht wrote: > imv/patches: FAILED in 4m50s > > [libheif: run library init/deinit routines.][0] from [Aleksei Bavshin][1] > > [0]: https://lists.sr.ht/~exec64/imv-devel/patches/41580 > [1]: alebastr89@gmail.com > > ✓ #1000071 SUCCESS imv/patches/debian.yml https://builds.sr.ht/~exec64/job/1000071 > ✓ #1000069 SUCCESS imv/patches/freebsd.yml https://builds.sr.ht/~exec64/job/1000069 > ✓ #1000072 SUCCESS imv/patches/archlinux.yml https://builds.sr.ht/~exec64/job/1000072 > ✗ #1000070 FAILED imv/patches/ubuntu.yml https://builds.sr.ht/~exec64/job/1000070 Hm, I haven't checked the release date for 1.13.0. Apparently, it's too
From Aleksei Bavshin to ~exec64/imv-devel
HEIC requires image sizes to be a multiple of 2 and AVIF wants the sizes
to be a multiple of 8, 16 or 32. libheif addresses that by rounding up
the stride and reporting a cropped box with actual image size that does
not reflect the internal plane layout.
As a result, imv reads few extra pixels for each line and renders a
distorted image (see odd-width cases in the test set).
The naive approach implemented here copies the bitmap line by line,
using the image width and taking stride into account.
A more correct solution would be storing stride for the imv_bitmap and
using it to calculate the value for `GL_UNPACK_ROW_LENGTH`, but it
requires more changes across the whole codebase than I'm willing to do.
Tested with libheif 1.16.1 and <https://github.com/link-u/avif-sample-images>.
[message trimmed]
From Aleksei Bavshin to ~exec64/imv-devel
A plugin interface[1] added in libheif 1.14.0 requires running `heif_init` to discover and load the plugins and `heif_deinit` for a proper cleanup. To support that, we need to extend the imv_backend structure with init/uninit callbacks and invoke them when necessary. Fixes discovery of libheif codecs shipped as dynamic plugins. [1]: https://github.com/strukturag/libheif#codec-plugins --- meson.build | 2 +- src/backend.h | 8 ++++++++ src/backend_libheif.c | 24 ++++++++++++++++++++++++ src/imv.c | 18 ++++++++++++++++-- [message trimmed]
From Aleksei Bavshin to ~kennylevinsen/greetd-devel
Some greeters were sending CancelSession in response to Error, likely because it was necessary for a consistent internal state of fakegreet. Change fakegreet to comply with the protocol doc, which states that the sessions are automatically cancelled on error, and remove the need for the redundant CancelSession. --- fakegreet/src/main.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/fakegreet/src/main.rs b/fakegreet/src/main.rs index 187551e..89aa05b 100644 --- a/fakegreet/src/main.rs +++ b/fakegreet/src/main.rs [message trimmed]
From Aleksei Bavshin to ~kennylevinsen/greetd-devel
Set the variables coming from a greeter first to ensure that the duplicates will be overwritten by the values from greetd worker. --- greetd/src/session/worker.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/greetd/src/session/worker.rs b/greetd/src/session/worker.rs index 9e691fa..20432a1 100644 --- a/greetd/src/session/worker.rs +++ b/greetd/src/session/worker.rs @@ -201,7 +201,7 @@ fn worker(sock: &UnixDatagram) -> Result<(), Error> { ), ]; [message trimmed]
From Aleksei Bavshin to ~kennylevinsen/greetd-devel
If the client was compiled with the previous version of the protocol, initialize StartSession.env with the default value instead of failing to deserialize the message. --- greetd_ipc/src/lib.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/greetd_ipc/src/lib.rs b/greetd_ipc/src/lib.rs index 970e6e8..c20c00f 100644 --- a/greetd_ipc/src/lib.rs +++ b/greetd_ipc/src/lib.rs @@ -75,7 +75,11 @@ pub enum Request { /// Start a successfully logged in session. This will fail if the session [message trimmed]
From Aleksei Bavshin to ~kennylevinsen/greetd-devel
This reverts commit 1bc6ddbf67397494b7097e92a901344782d394ae. --- agreety/src/main.rs | 1 + fakegreet/src/main.rs | 2 +- greetd/src/context.rs | 6 +++--- greetd/src/server.rs | 2 +- greetd/src/session/interface.rs | 4 ++-- greetd/src/session/worker.rs | 7 ++++--- greetd_ipc/src/lib.rs | 2 +- man/greetd-ipc-7.scd | 4 ++-- 8 files changed, 15 insertions(+), 13 deletions(-) diff --git a/agreety/src/main.rs b/agreety/src/main.rs index d0c2806..0168a71 100644 [message trimmed]