~alextee/zrythm-devel

1

[PATCH] fix compile error with -Dcarla=disabled option

Details
Message ID
<f3cd6d9d837b8cf64a90d6ca2b8eaaa5@vivaldi.net>
DKIM signature
pass
Download raw message
Signed-off-by: Igor Gushchin <igorg9863@vivaldi.net>
---
  src/gui/widgets/preferences.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gui/widgets/preferences.c 
b/src/gui/widgets/preferences.c
index 9a4619f4f..d7b03bd6d 100644
--- a/src/gui/widgets/preferences.c
+++ b/src/gui/widgets/preferences.c
@@ -241,7 +241,7 @@ should_be_hidden (
  #endif
  #ifndef HAVE_CARLA
      KEY_IS ("Plugins", "Paths", "sfz-search-paths")
-    || KEY_IS ("Plugins", "Paths", "sf2-search-paths") ||
+    || KEY_IS ("Plugins", "Paths", "sf2-search-paths")
      || KEY_IS ("Plugins", "Paths", "jsfx-search-paths") ||
  #endif
      (audio_backend != AUDIO_BACKEND_SDL
-- 
2.38.1
Details
Message ID
<4e54cb338c604ebd0d7e60dac12fe882727fb538.camel@zrythm.org>
In-Reply-To
<f3cd6d9d837b8cf64a90d6ca2b8eaaa5@vivaldi.net> (view parent)
DKIM signature
missing
Download raw message
Hi,

> Signed-off-by: Igor Gushchin <igorg9863@vivaldi.net>
> ---
>   src/gui/widgets/preferences.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gui/widgets/preferences.c 
> b/src/gui/widgets/preferences.c
> index 9a4619f4f..d7b03bd6d 100644
> --- a/src/gui/widgets/preferences.c
> +++ b/src/gui/widgets/preferences.c
> @@ -241,7 +241,7 @@ should_be_hidden (
>   #endif
>   #ifndef HAVE_CARLA
>       KEY_IS ("Plugins", "Paths", "sfz-search-paths")
> -    || KEY_IS ("Plugins", "Paths", "sf2-search-paths") ||
> +    || KEY_IS ("Plugins", "Paths", "sf2-search-paths")
>       || KEY_IS ("Plugins", "Paths", "jsfx-search-paths") ||
>   #endif
>       (audio_backend != AUDIO_BACKEND_SDL

Thanks for the patch. However Zrythm is currently unusable without
Carla (that option to disable it is from older times when Zrythm had
native LV2 support). I will most likely remove that option soon or make
it throw an error when you try to build with it disabled.

Thanks,
Alex
Reply to thread Export thread (mbox)