~amk/public-inbox

2 2

Subsonic fails because id is number, not string.

festerdam@posteo.net <festerdam@posteo.net>
Details
Message ID
<648f4238-b4a9-6eed-c81f-1861e6014a21@posteo.net>
DKIM signature
missing
Download raw message
Subsonic raises an error whenever expand-file-name with id as argument 
is used, as string is expected. Workaround is to pass id through 
number-to-string.

Unrelated to this, I think, error (wrong-type-argument consp nil) occurs 
when attempting toggle play:

   tq-queue-add(nil nil "" nil (closure ((args "cycle" "pause") 
url-http-end-of-headers t) (_x _y)))
   tq-enqueue(nil "{\"command\":[\"cycle\",\"pause\"]}\n" "" nil 
(closure ((args "cycle" "pause") url-http-end-of-headers t) (_x _y)))
   subsonic-mpv-command("cycle" "pause")
   subsonic-toggle-playing()
   funcall-interactively(subsonic-toggle-playing)
   call-interactively(subsonic-toggle-playing nil nil)
   command-execute(subsonic-toggle-playing)
Details
Message ID
<87czmjf651.fsf@amk.ie>
In-Reply-To
<648f4238-b4a9-6eed-c81f-1861e6014a21@posteo.net> (view parent)
DKIM signature
missing
Download raw message
"festerdam@posteo.net" <festerdam@posteo.net> writes:

> Subsonic raises an error whenever expand-file-name with id as argument 
> is used, as string is expected. Workaround is to pass id through 
> number-to-string.
>
> Unrelated to this, I think, error (wrong-type-argument consp nil) occurs 
> when attempting toggle play:
>
>    tq-queue-add(nil nil "" nil (closure ((args "cycle" "pause") 
> url-http-end-of-headers t) (_x _y)))
>    tq-enqueue(nil "{\"command\":[\"cycle\",\"pause\"]}\n" "" nil 
> (closure ((args "cycle" "pause") url-http-end-of-headers t) (_x _y)))
>    subsonic-mpv-command("cycle" "pause")
>    subsonic-toggle-playing()
>    funcall-interactively(subsonic-toggle-playing)
>    call-interactively(subsonic-toggle-playing nil nil)
>    command-execute(subsonic-toggle-playing)

Hi,

I've pushed a fix for  the ids being incorrect, can you let me know if
it helps? Also what subsonic server are you using? I've only really
tested with gonic.

Thanks,
Alex
festerdam@posteo.net <festerdam@posteo.net>
Details
Message ID
<d2ed2803-ca69-5e30-3d36-b5eec0518be1@posteo.net>
In-Reply-To
<87czmjf651.fsf@amk.ie> (view parent)
DKIM signature
missing
Download raw message
On 29/11/21 13:22, Alex McGrath wrote:
> "festerdam@posteo.net" <festerdam@posteo.net> writes:
> 
>> Subsonic raises an error whenever expand-file-name with id as argument
>> is used, as string is expected. Workaround is to pass id through
>> number-to-string.
>>
>> Unrelated to this, I think, error (wrong-type-argument consp nil) occurs
>> when attempting toggle play:
>>
>>     tq-queue-add(nil nil "" nil (closure ((args "cycle" "pause")
>> url-http-end-of-headers t) (_x _y)))
>>     tq-enqueue(nil "{\"command\":[\"cycle\",\"pause\"]}\n" "" nil
>> (closure ((args "cycle" "pause") url-http-end-of-headers t) (_x _y)))
>>     subsonic-mpv-command("cycle" "pause")
>>     subsonic-toggle-playing()
>>     funcall-interactively(subsonic-toggle-playing)
>>     call-interactively(subsonic-toggle-playing nil nil)
>>     command-execute(subsonic-toggle-playing)
> 
> Hi,
> 
> I've pushed a fix for  the ids being incorrect, can you let me know if
> it helps? Also what subsonic server are you using? I've only really
> tested with gonic.
> 
> Thanks,
> Alex
> 

Ids are fixed now (playing however doesn't, but that's probably an 
unrelated issue). I'm using funkwhale.juniorjpdj.pl, which is a 
funkwhale instance (which also support subsonic). The server should be 
working as I'm using a subsonic client on a device connected to that server.
Reply to thread Export thread (mbox)