~ancarda/tls-redirector

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2 2

[PATCH] Add gitignore

Details
Message ID
<b5e1c66e5e4b5bf930a46fe1860719b2@somini.xyz>
DKIM signature
missing
Download raw message
Patch: +3 -0
Ignore:
- Built binary
- Generated code
---
  .gitignore | 3 +++
  1 file changed, 3 insertions(+)
  create mode 100644 .gitignore

diff --git a/.gitignore b/.gitignore
new file mode 100644
index 0000000..f4a249f
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,3 @@
/tls-redirector
# Autogenerated
fancy/templates.go
-- 
2.29.2
Details
Message ID
<d54e3a57cf400e7669d647630191ba63@markdain.net>
In-Reply-To
<b5e1c66e5e4b5bf930a46fe1860719b2@somini.xyz> (view parent)
DKIM signature
missing
Download raw message
Hi,

I removed the gitignore file in this commit:
https://git.sr.ht/~ancarda/tls-redirector/commit/227f60114868

I think it's better to catch these mistakes on the mailing list / in
pull requests -- which is a good opportunity to teach people about
`git rebase'.

If you want to be able to do `git add .', keep the file. Just include
the ignore file itself so it doesn't get checked in, like so:

    .gitignore
    tls-redirector
    fancy/templates.go

I'll admit fancy/templates.go could probably be renamed to make it more
clear you're not meant to check it in.

-Mark



December 21, 2020 3:42 PM, me@somini.xyz wrote:

> Ignore:
> - Built binary
> - Generated code
> ---
> .gitignore | 3 +++
> 1 file changed, 3 insertions(+)
> create mode 100644 .gitignore
> 
> diff --git a/.gitignore b/.gitignore
> new file mode 100644
> index 0000000..f4a249f
> --- /dev/null
> +++ b/.gitignore
> @@ -0,0 +1,3 @@
> +/tls-redirector
> +# Autogenerated
> +fancy/templates.go
> -- 2.29.2
Details
Message ID
<ce829238062e8742547c9428a1ddec80@somini.xyz>
In-Reply-To
<d54e3a57cf400e7669d647630191ba63@markdain.net> (view parent)
DKIM signature
missing
Download raw message
I understand that you will avoid merging patches that touch these files, 
this .gitignore also helps when developing. You can make changes, build 
and test, and then `git add -A .` will not include those generated 
files. I was particularly bitten by that fancy template.

It's a standardize message that those files are built, not to be 
committed.

It's your call to make. :)
Reply to thread Export thread (mbox)