~andersjohansson

Recent activity

Re: 'make-obsolete' should be 'make-obsolete-variable' in some cases in the version-4 branch 11 months ago

From Anders Johansson to ~protesilaos/modus-themes


/Anders Johansson

> 7 dec. 2022 kl. 04:09 skrev Protesilaos Stavrou <info@protesilaos.com>:

[…]
> 
> Hello again Anders,
> 
> Just a quick follow-up on adding palette overrides.  The diff further
> below achieves the desired effect (subject to further refinements).
> 
> We can change colour values but also colour mappings.  For example:

'make-obsolete' should be 'make-obsolete-variable' in some cases in the version-4 branch 11 months ago

From Anders Johansson to ~protesilaos/modus-themes

Hi,
I checked out the updates in version-4 and noted that some earlier
customization variables were removed (as expected). However, they were
not defined as obsolete variables. I found that you used
`make-obsolete' (which is for functions) also for variables.

I see where you are going with simplifying this. Great work!
Personally, I think I will need to tweak back some of the subtler grey
backgrounds for the screens I use. Would there be a possibility to
customize the base colors in the themes in how you envision the future
design? I would for example be happy to use the old lighter
'bg-active' colour (#d7d7d7).

Best,