~andir/nixpkgs-dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2 2

[PATCH] hoogle: set the host to bind on

Details
Message ID
<20201230032048.32626-1-ben@bsima.me>
DKIM signature
pass
Download raw message
Patch: +6 -1
---
 nixos/modules/services/development/hoogle.nix | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/nixos/modules/services/development/hoogle.nix b/nixos/modules/services/development/hoogle.nix
index cbf13f027de..a661e3acae3 100644
--- a/nixos/modules/services/development/hoogle.nix
+++ b/nixos/modules/services/development/hoogle.nix
@@ -49,6 +49,11 @@ in {
      default = "https://hoogle.haskell.org";
    };

    host = mkOption {
      type = types.str;
      description = "Set the host to bind on.";
      default = "127.0.0.1";
    };
  };

  config = mkIf cfg.enable {
@@ -59,7 +64,7 @@ in {

      serviceConfig = {
        Restart = "always";
        ExecStart = ''${hoogleEnv}/bin/hoogle server --local --port ${toString cfg.port} --home ${cfg.home}'';
        ExecStart = ''${hoogleEnv}/bin/hoogle server --local --port ${toString cfg.port} --home ${cfg.home} --host ${cfg.host}'';

        DynamicUser = true;

-- 
2.28.0
Details
Message ID
<20201230033648.c5atazo4zvvxpinw@wrt>
In-Reply-To
<20201230032048.32626-1-ben@bsima.me> (view parent)
DKIM signature
pass
Download raw message
Thanks, forwarded as https://github.com/NixOS/nixpkgs/pull/107936

On 22:20 29.12.20, Ben Sima wrote:
> ---
>  nixos/modules/services/development/hoogle.nix | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/nixos/modules/services/development/hoogle.nix b/nixos/modules/services/development/hoogle.nix
> index cbf13f027de..a661e3acae3 100644
> --- a/nixos/modules/services/development/hoogle.nix
> +++ b/nixos/modules/services/development/hoogle.nix
> @@ -49,6 +49,11 @@ in {
>        default = "https://hoogle.haskell.org";
>      };
>  
> +    host = mkOption {
> +      type = types.str;
> +      description = "Set the host to bind on.";
> +      default = "127.0.0.1";
> +    };
>    };
>  
>    config = mkIf cfg.enable {
> @@ -59,7 +64,7 @@ in {
>  
>        serviceConfig = {
>          Restart = "always";
> -        ExecStart = ''${hoogleEnv}/bin/hoogle server --local --port ${toString cfg.port} --home ${cfg.home}'';
> +        ExecStart = ''${hoogleEnv}/bin/hoogle server --local --port ${toString cfg.port} --home ${cfg.home} --host ${cfg.host}'';
>  
>          DynamicUser = true;
>  
> -- 
> 2.28.0
> 
Details
Message ID
<20210106113307.72vkgnhktkd3tvkk@wrt>
In-Reply-To
<20201230033648.c5atazo4zvvxpinw@wrt> (view parent)
DKIM signature
missing
Download raw message
Merged as https://github.com/NixOS/nixpkgs/commit/f41f0643f851ce2454958802a21bc48fdd463012
Reply to thread Export thread (mbox)