~andir/nixpkgs-dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
19 4

[PATCH nixpkgs] taskwarrior-tui: 0.9.10 -> 0.9.15

Details
Message ID
<20210211164652.9352-1-mail@beyermatthias.de>
DKIM signature
missing
Download raw message
Patch: +3 -3
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
---
 pkgs/applications/misc/taskwarrior-tui/default.nix | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/pkgs/applications/misc/taskwarrior-tui/default.nix b/pkgs/applications/misc/taskwarrior-tui/default.nix
index 530d60c7631..ace76016115 100644
--- a/pkgs/applications/misc/taskwarrior-tui/default.nix
+++ b/pkgs/applications/misc/taskwarrior-tui/default.nix
@@ -5,19 +5,19 @@

rustPlatform.buildRustPackage rec {
  pname = "taskwarrior-tui";
  version = "0.9.10";
  version = "0.9.15";

  src = fetchFromGitHub {
    owner = "kdheepak";
    repo = "taskwarrior-tui";
    rev = "v${version}";
    sha256 = "sha256-NQzZhWoLeDF7iTgIljbVi0ULAe7DeIn45Cu6bgFCfKQ=";
    sha256 = "0jcqla93f4akmf05afdppv5cma346ci6nmwn4wkyxi53jx49x4n7";
  };

  # Because there's a test that requires terminal access
  doCheck = false;

  cargoSha256 = "sha256-9qfqQ7zFw+EwY7o35Y6RhBJ8h5eXnTAsdbqo/w0zO5w=";
  cargoSha256 = "1izzb0x1m0yni7861p99zs5ayxy9r72ad1mbrji42gqw3vx8c75p";

  meta = with lib; {
    description = "A terminal user interface for taskwarrior ";
-- 
2.29.2
Details
Message ID
<20210211175816.gcl5u6w456x2pqoy@monad>
In-Reply-To
<20210211164652.9352-1-mail@beyermatthias.de> (view parent)
DKIM signature
missing
Download raw message
Built but haven't tested since it looks like I need another piece of
software that I don't have installed:

> [taskwarrior-tui error]: Unable to find executable `task`: No such file
> or directory (os error 2). Check that taskwarrior is installed correctly
> and try again.

Reviewed-by: William Casarin <jb55@jb55.com>
Details
Message ID
<20210211180047.73jh5lxvd6ytt243@hoshi>
In-Reply-To
<20210211175816.gcl5u6w456x2pqoy@monad> (view parent)
DKIM signature
missing
Download raw message
On 11-02-2021 09:58:16, William Casarin wrote:
> Built but haven't tested since it looks like I need another piece of
> software that I don't have installed:
> 
> > [taskwarrior-tui error]: Unable to find executable `task`: No such file
> > or directory (os error 2). Check that taskwarrior is installed correctly
> > and try again.

Yep, that's taskwarrior missing. Taskwarrior is a runtime dependency of this
package, but is not included in the dependencies of the package.

I'm open for discussion (or patches!) whether this would be an idea, but I'd
submit such a change in a new patchset.
Details
Message ID
<20210211185548.pybezr44yk6dsj5c@monad>
In-Reply-To
<20210211180047.73jh5lxvd6ytt243@hoshi> (view parent)
DKIM signature
missing
Download raw message
On Thu, Feb 11, 2021 at 07:00:47PM +0100, Matthias Beyer wrote:
> On 11-02-2021 09:58:16, William Casarin wrote:
> > Built but haven't tested since it looks like I need another piece of
> > software that I don't have installed:
> > 
> > > [taskwarrior-tui error]: Unable to find executable `task`: No such file
> > > or directory (os error 2). Check that taskwarrior is installed correctly
> > > and try again.
> 
> Yep, that's taskwarrior missing. Taskwarrior is a runtime dependency of this
> package, but is not included in the dependencies of the package.
> 
> I'm open for discussion (or patches!) whether this would be an idea, but I'd
> submit such a change in a new patchset.

It's not a problem, no change needed
Details
Message ID
<87ft22i9pu.fsf@yoctocell.xyz>
In-Reply-To
<20210211164652.9352-1-mail@beyermatthias.de> (view parent)
DKIM signature
pass
Download raw message
Reviewed-by: Xinglu Chen <public@yoctocell.xyz>

[PATCH nixpkgs v2 0/2] taskwarrior-tui update

Details
Message ID
<20210216160815.26268-1-mail@beyermatthias.de>
In-Reply-To
<20210211164652.9352-1-mail@beyermatthias.de> (view parent)
DKIM signature
missing
Download raw message
Hi,

this is v2 of that patchset as it didn't land yet.
Rebased to latest master.

Closes #112536


Matthias Beyer (2):
  taskwarrior-tui: 0.9.10 -> 0.9.15
  taskwarrior-tui: 0.9.15 -> 0.10.3

 pkgs/applications/misc/taskwarrior-tui/default.nix | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
2.29.2

[PATCH nixpkgs v2 1/2] taskwarrior-tui: 0.9.10 -> 0.9.15

Details
Message ID
<20210216160815.26268-2-mail@beyermatthias.de>
In-Reply-To
<20210211164652.9352-1-mail@beyermatthias.de> (view parent)
DKIM signature
missing
Download raw message
Patch: +3 -3
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
---
 pkgs/applications/misc/taskwarrior-tui/default.nix | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/pkgs/applications/misc/taskwarrior-tui/default.nix b/pkgs/applications/misc/taskwarrior-tui/default.nix
index 530d60c7631..ace76016115 100644
--- a/pkgs/applications/misc/taskwarrior-tui/default.nix
+++ b/pkgs/applications/misc/taskwarrior-tui/default.nix
@@ -5,19 +5,19 @@

rustPlatform.buildRustPackage rec {
  pname = "taskwarrior-tui";
  version = "0.9.10";
  version = "0.9.15";

  src = fetchFromGitHub {
    owner = "kdheepak";
    repo = "taskwarrior-tui";
    rev = "v${version}";
    sha256 = "sha256-NQzZhWoLeDF7iTgIljbVi0ULAe7DeIn45Cu6bgFCfKQ=";
    sha256 = "0jcqla93f4akmf05afdppv5cma346ci6nmwn4wkyxi53jx49x4n7";
  };

  # Because there's a test that requires terminal access
  doCheck = false;

  cargoSha256 = "sha256-9qfqQ7zFw+EwY7o35Y6RhBJ8h5eXnTAsdbqo/w0zO5w=";
  cargoSha256 = "1izzb0x1m0yni7861p99zs5ayxy9r72ad1mbrji42gqw3vx8c75p";

  meta = with lib; {
    description = "A terminal user interface for taskwarrior ";
-- 
2.29.2

[PATCH nixpkgs v2 2/2] taskwarrior-tui: 0.9.15 -> 0.10.3

Details
Message ID
<20210216160815.26268-3-mail@beyermatthias.de>
In-Reply-To
<20210211164652.9352-1-mail@beyermatthias.de> (view parent)
DKIM signature
missing
Download raw message
Patch: +3 -3
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
---
 pkgs/applications/misc/taskwarrior-tui/default.nix | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/pkgs/applications/misc/taskwarrior-tui/default.nix b/pkgs/applications/misc/taskwarrior-tui/default.nix
index ace76016115..5deb68f07eb 100644
--- a/pkgs/applications/misc/taskwarrior-tui/default.nix
+++ b/pkgs/applications/misc/taskwarrior-tui/default.nix
@@ -5,19 +5,19 @@

rustPlatform.buildRustPackage rec {
  pname = "taskwarrior-tui";
  version = "0.9.15";
  version = "0.10.3";

  src = fetchFromGitHub {
    owner = "kdheepak";
    repo = "taskwarrior-tui";
    rev = "v${version}";
    sha256 = "0jcqla93f4akmf05afdppv5cma346ci6nmwn4wkyxi53jx49x4n7";
    sha256 = "03fsvhxah6bcyip7b8m8cna4frv7vr4js9d7fl1l8f2yq2il1ysf";
  };

  # Because there's a test that requires terminal access
  doCheck = false;

  cargoSha256 = "1izzb0x1m0yni7861p99zs5ayxy9r72ad1mbrji42gqw3vx8c75p";
  cargoSha256 = "0dfw0n6g56qxv899s6hg14sgvnyjaxzi9h4sg5mhfwxn696npv5r";

  meta = with lib; {
    description = "A terminal user interface for taskwarrior ";
-- 
2.29.2

Re: [PATCH nixpkgs v2 0/2] taskwarrior-tui update

Details
Message ID
<20210216165217.g6fx5kfudnlgdgwu@monad>
In-Reply-To
<20210216160815.26268-1-mail@beyermatthias.de> (view parent)
DKIM signature
missing
Download raw message
Hey Matthias,

On Tue, Feb 16, 2021 at 05:08:13PM +0100, Matthias Beyer wrote:
> Hi,
> 
> this is v2 of that patchset as it didn't land yet.
> Rebased to latest master.
> 
> Closes #112536
> 
> 
> Matthias Beyer (2):
>   taskwarrior-tui: 0.9.10 -> 0.9.15
>   taskwarrior-tui: 0.9.15 -> 0.10.3

This might be an older cover letter since this looks wrong, I'm guessing
it should be:

    taskwarrior-tui: 0.9.15 -> 0.10.3
    taskwarrior-tui: 0.9.10 -> 0.9.15

Could we just fixup these into?:

    taskwarrior-tui: 0.9.10 -> 0.10.3

Cheers,
Will

Re: [PATCH nixpkgs v2 0/2] taskwarrior-tui update

Details
Message ID
<F11F5AD1-0474-496D-A701-FDFED292931F@beyermatthias.de>
In-Reply-To
<20210216165217.g6fx5kfudnlgdgwu@monad> (view parent)
DKIM signature
missing
Download raw message

Am 16. Februar 2021 17:52:17 MEZ schrieb William Casarin <jb55@jb55.com>:
>
>On Tue, Feb 16, 2021 at 05:08:13PM +0100, Matthias Beyer wrote:
>> Matthias Beyer (2):
>>   taskwarrior-tui: 0.9.10 -> 0.9.15
>>   taskwarrior-tui: 0.9.15 -> 0.10.3
>
>This might be an older cover letter since this looks wrong, I'm
>guessing
>it should be:
>
>    taskwarrior-tui: 0.9.15 -> 0.10.3
>    taskwarrior-tui: 0.9.10 -> 0.9.15

Um, No? This is completely right, as I provided two patches. One to update to 0.9.15 and one from there to 0.10.3

>Could we just fixup these into?:
>
>    taskwarrior-tui: 0.9.10 -> 0.10.3

You mean squash the commits into one? I don't see why...

Re: [PATCH nixpkgs v2 0/2] taskwarrior-tui update

Details
Message ID
<20210216170039.ks4olpqll2p4f7nu@monad>
In-Reply-To
<F11F5AD1-0474-496D-A701-FDFED292931F@beyermatthias.de> (view parent)
DKIM signature
missing
Download raw message
On Tue, Feb 16, 2021 at 05:58:12PM +0100, Matthias Beyer wrote:
> Am 16. Februar 2021 17:52:17 MEZ schrieb William Casarin <jb55@jb55.com>:
> >
> >On Tue, Feb 16, 2021 at 05:08:13PM +0100, Matthias Beyer wrote:
> >> Matthias Beyer (2):
> >>   taskwarrior-tui: 0.9.10 -> 0.9.15
> >>   taskwarrior-tui: 0.9.15 -> 0.10.3
> >
> >This might be an older cover letter since this looks wrong, I'm
> >guessing
> >it should be:
> >
> >    taskwarrior-tui: 0.9.15 -> 0.10.3
> >    taskwarrior-tui: 0.9.10 -> 0.9.15
> 
> Um, No? This is completely right, as I provided two patches. One to update to 0.9.15 and one from there to 0.10.3

uhhh I think it's because I didn't have my coffee yet and my brain isn't
working. I misread it

> >Could we just fixup these into?:
> >
> >    taskwarrior-tui: 0.9.10 -> 0.10.3
> 
> You mean squash the commits into one? I don't see why...

I don't know what standard practice is here but if it's normal to do
this than ok.

Re: [PATCH nixpkgs v2 1/2] taskwarrior-tui: 0.9.10 -> 0.9.15

Details
Message ID
<20210216170616.2yyjhja4psroqdfw@monad>
In-Reply-To
<20210216160815.26268-2-mail@beyermatthias.de> (view parent)
DKIM signature
missing
Download raw message
Tested-by: William Casarin <jb55@jb55.com>

Re: [PATCH nixpkgs v2 2/2] taskwarrior-tui: 0.9.15 -> 0.10.3

Details
Message ID
<20210216170637.vkk5yyp63i2i3cc7@monad>
In-Reply-To
<20210216160815.26268-3-mail@beyermatthias.de> (view parent)
DKIM signature
missing
Download raw message
Tested-by: William Casarin <jb55@jb55.com>

Re: [PATCH nixpkgs v2 0/2] taskwarrior-tui update

Details
Message ID
<3F623D61-A40A-4EB5-A87D-778A927D8E47@beyermatthias.de>
In-Reply-To
<20210216170039.ks4olpqll2p4f7nu@monad> (view parent)
DKIM signature
missing
Download raw message

>> >Could we just fixup these into?:
>> >
>> >    taskwarrior-tui: 0.9.10 -> 0.10.3
>> 
>> You mean squash the commits into one? I don't see why...
>
>I don't know what standard practice is here but if it's normal to do this than ok.

Well, I think it is better to keep this separate.

Reasoning is that this represents the actual changes I made and if someone wants to downgrade from 0.10 to 0.9, they downgrade to the latest 0.9 and not to some previous 0.9, which might contain bugs that are solved in the later 0.9 release.
This is why I think that's the right strategy.

Patches not submitted, do we need better tooling? [was: taskwarrior-tui update]

Details
Message ID
<20210221083815.poztwo4az44fzimd@hoshi>
In-Reply-To
<20210216160815.26268-1-mail@beyermatthias.de> (view parent)
DKIM signature
missing
Download raw message
Hi,

On 16-02-2021 17:08:13, Matthias Beyer wrote:
> this is v2 of that patchset as it didn't land yet.
> Rebased to latest master.

It seems that this is not yet submitted to nixpkgs.

I'm not blaming anyone here, but maybe this is an indicator that we need better
tooling? :-P

Matthias

Re: [PATCH nixpkgs v2 0/2] taskwarrior-tui update

sternenseemann
Details
Message ID
<a5fb4560-be6d-2827-6b79-3876c5ea9bd7@systemli.org>
In-Reply-To
<20210216160815.26268-1-mail@beyermatthias.de> (view parent)
DKIM signature
pass
Download raw message
https://github.com/NixOS/nixpkgs/pull/113895

On 2/16/21 5:08 PM, Matthias Beyer wrote:
> Hi,
> 
> this is v2 of that patchset as it didn't land yet.
> Rebased to latest master.
> 
> Closes #112536
> 
> 
> Matthias Beyer (2):
>   taskwarrior-tui: 0.9.10 -> 0.9.15
>   taskwarrior-tui: 0.9.15 -> 0.10.3
> 
>  pkgs/applications/misc/taskwarrior-tui/default.nix | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

Re: Patches not submitted, do we need better tooling? [was: taskwarrior-tui update]

Details
Message ID
<20210221164826.s3kugxqwggp2d4k7@quiver>
In-Reply-To
<20210221083815.poztwo4az44fzimd@hoshi> (view parent)
DKIM signature
missing
Download raw message
On Sun, Feb 21, 2021 at 09:38:15AM +0100, Matthias Beyer wrote:
> Hi,
> 
> On 16-02-2021 17:08:13, Matthias Beyer wrote:
> > this is v2 of that patchset as it didn't land yet.
> > Rebased to latest master.
> 
> It seems that this is not yet submitted to nixpkgs.
> 
> I'm not blaming anyone here, but maybe this is an indicator that we need better
> tooling? :-P

I purposely didn't submit it this time since I didn't want to be the
bottleneck for all future patches and to give others the chance to do
so, which I was happy to see someone did eventually. 

But yes there is still no standard procedure for *when* PRs get
submitted or *who* does it, or how to prevent race conditions. Perhaps a
user could signal their intent to submit after review. It makes sense
there will be delays until we have more people contributing, and until
we have more of these procedures worked out and documented.

Cheers,
Will

Re: Patches not submitted, do we need better tooling? [was: taskwarrior-tui update]

Details
Message ID
<20210221183749.lc6f4g22pidc3qnc@hoshi>
In-Reply-To
<20210221164826.s3kugxqwggp2d4k7@quiver> (view parent)
DKIM signature
missing
Download raw message
On 21-02-2021 08:48:26, William Casarin wrote:
> On Sun, Feb 21, 2021 at 09:38:15AM +0100, Matthias Beyer wrote:
> > we need better tooling? 
> 
> [...]
> 
> Perhaps a
> user could signal their intent to submit after review. It makes sense
> there will be delays until we have more people contributing, and until
> we have more of these procedures worked out and documented.

Yeah, maybe we can do weekly rollups? That might be a short-term fix, so that
someone does a rollup on friday, for example, writes a quick note to the ML that
they start the rollup now (for synchronization with others), then submit PRs for
each patchset and reply to the patchset with some message where the set was
submitted?

Of course this does not scale very good, but it would be a short-term solution
for the problem.

Long-term, we'd rather need some kind of bot, I guess? But then we would need to
have some way to mark patches to be read for upstream submission and so on ...
I'm not confident that this is the way to go there.

Matthias

[PATCH nixpkgs 3/3] taskwarrior-tui: 0.10.3 -> 0.10.4

Details
Message ID
<20210221183940.30049-1-mail@beyermatthias.de>
In-Reply-To
<a5fb4560-be6d-2827-6b79-3876c5ea9bd7@systemli.org> (view parent)
DKIM signature
missing
Download raw message
Patch: +3 -3
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
---
 pkgs/applications/misc/taskwarrior-tui/default.nix | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/pkgs/applications/misc/taskwarrior-tui/default.nix b/pkgs/applications/misc/taskwarrior-tui/default.nix
index 5deb68f07eb..9c1e778bdf3 100644
--- a/pkgs/applications/misc/taskwarrior-tui/default.nix
+++ b/pkgs/applications/misc/taskwarrior-tui/default.nix
@@ -5,19 +5,19 @@

rustPlatform.buildRustPackage rec {
  pname = "taskwarrior-tui";
  version = "0.10.3";
  version = "0.10.4";

  src = fetchFromGitHub {
    owner = "kdheepak";
    repo = "taskwarrior-tui";
    rev = "v${version}";
    sha256 = "03fsvhxah6bcyip7b8m8cna4frv7vr4js9d7fl1l8f2yq2il1ysf";
    sha256 = "1rs6xpnmqzp45jkdzi8x06i8764gk7zl86sp6s0hiirbfqf7vwsy";
  };

  # Because there's a test that requires terminal access
  doCheck = false;

  cargoSha256 = "0dfw0n6g56qxv899s6hg14sgvnyjaxzi9h4sg5mhfwxn696npv5r";
  cargoSha256 = "0xblxsp7jgqbb3kr5k7yy6ziz18a8wlkrhls0vz9ak2n0ngddg3r";

  meta = with lib; {
    description = "A terminal user interface for taskwarrior ";
-- 
2.29.2

Re: [PATCH nixpkgs 3/3] taskwarrior-tui: 0.10.3 -> 0.10.4

sternenseemann
Details
Message ID
<5459d50f-192d-030b-caa3-6bb1a871713b@systemli.org>
In-Reply-To
<20210221183940.30049-1-mail@beyermatthias.de> (view parent)
DKIM signature
pass
Download raw message
Has been merged into nixpkgs/master:

31688e5ce9a taskwarrior-tui: 0.9.15 -> 0.10.4
27a35cba249 taskwarrior-tui: 0.9.10 -> 0.9.15

(Patches 2 and 3 were squashed together)

On 2/21/21 7:39 PM, Matthias Beyer wrote:
> Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
> ---
>  pkgs/applications/misc/taskwarrior-tui/default.nix | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/pkgs/applications/misc/taskwarrior-tui/default.nix b/pkgs/applications/misc/taskwarrior-tui/default.nix
> index 5deb68f07eb..9c1e778bdf3 100644
> --- a/pkgs/applications/misc/taskwarrior-tui/default.nix
> +++ b/pkgs/applications/misc/taskwarrior-tui/default.nix
> @@ -5,19 +5,19 @@
>  
>  rustPlatform.buildRustPackage rec {
>    pname = "taskwarrior-tui";
> -  version = "0.10.3";
> +  version = "0.10.4";
>  
>    src = fetchFromGitHub {
>      owner = "kdheepak";
>      repo = "taskwarrior-tui";
>      rev = "v${version}";
> -    sha256 = "03fsvhxah6bcyip7b8m8cna4frv7vr4js9d7fl1l8f2yq2il1ysf";
> +    sha256 = "1rs6xpnmqzp45jkdzi8x06i8764gk7zl86sp6s0hiirbfqf7vwsy";
>    };
>  
>    # Because there's a test that requires terminal access
>    doCheck = false;
>  
> -  cargoSha256 = "0dfw0n6g56qxv899s6hg14sgvnyjaxzi9h4sg5mhfwxn696npv5r";
> +  cargoSha256 = "0xblxsp7jgqbb3kr5k7yy6ziz18a8wlkrhls0vz9ak2n0ngddg3r";
>  
>    meta = with lib; {
>      description = "A terminal user interface for taskwarrior ";
> 
Reply to thread Export thread (mbox)