On Sun, Apr 18, 2021 at 08:22:56PM -0400, Ben Sima wrote:
>The usual wemux.conf location is /usr/local/etc, but that directory doesn't>exist, so we patch the script to look in /etc.>--->I forgot I had manually created /usr/local/etc, but we can't assume the user>will know to do that. qyliss on #nixos said to put it in /etc.
I think he might have meant $out/etc? I don't believe /etc is a valid
build output location...
>>Other comments were addressed.>> pkgs/tools/misc/wemux/default.nix | 36 +++++++++++++++++++++++++++++++> pkgs/top-level/all-packages.nix | 2 ++> 2 files changed, 38 insertions(+)> create mode 100644 pkgs/tools/misc/wemux/default.nix>>diff --git a/pkgs/tools/misc/wemux/default.nix b/pkgs/tools/misc/wemux/default.nix>new file mode 100644>index 00000000000..63a91b7a678>--- /dev/null>+++ b/pkgs/tools/misc/wemux/default.nix>@@ -0,0 +1,36 @@>+{ stdenv, lib, fetchFromGitHub, tmux, installShellFiles }:>+>+stdenv.mkDerivation rec {
nit: it doesn't seem like rec is needed
On Mon, Apr 19, 2021 at 06:36:40AM -0700, William Casarin wrote:
>On Sun, Apr 18, 2021 at 08:22:56PM -0400, Ben Sima wrote:>>The usual wemux.conf location is /usr/local/etc, but that directory doesn't>>exist, so we patch the script to look in /etc.>>--->>I forgot I had manually created /usr/local/etc, but we can't assume the user>>will know to do that. qyliss on #nixos said to put it in /etc.>>I think he* might have meant $out/etc? I don't believe /etc is a valid>build output location...
she* (°ー°〃)
On Mon, Apr 19, 2021 at 06:36:40AM -0700, William Casarin wrote:
>On Sun, Apr 18, 2021 at 08:22:56PM -0400, Ben Sima wrote:>>The usual wemux.conf location is /usr/local/etc, but that directory doesn't>>exist, so we patch the script to look in /etc.>>--->>I forgot I had manually created /usr/local/etc, but we can't assume the user>>will know to do that. qyliss on #nixos said to put it in /etc.>>I think he might have meant $out/etc? I don't believe /etc is a valid>build output location...
I probably shouldn't do review before I had coffee. I see that this is
only patching the script to look in that location instead of installing
anything. so this comment is incorrect.