I agree, I have merged in your patch. Thank you!

--
w:] www.momi.ca
pgp:] https://momi.ca/publickey.txt

Thanks!

To git@git.sr.ht:~mil/sxmo-utils
   55aac86..17e4e91  master -> master
--
w:] www.momi.ca
pgp:] https://momi.ca/publickey.txt

"Willow Barraco" <contact@willowbarraco.fr> writes:

> I confess I have to change the rest of the script cause atm this is a
> bit confusing. I'll also clarify how SXMO_DEVICE_NAME is computed.
>
> But yes, the goal is to fallback to "desktop", when there is no
> /proc/device-tree/compatible. Is that a problem to you?

Ideally, if there is no deviceprofile written for Sxmo for a given
device, I want to disable suspend and give the user a warning.

Is there no /proc/device-tree/compatible on desktop always?

This change:

> +
> +	if [ -z "$SXMO_DEVICE_NAME" ]; then
> +		SXMO_DEVICE_NAME=desktop
> +	fi
> +
> +	export SXMO_DEVICE_NAME
> +	deviceprofile="$(command -v "sxmo_deviceprofile_$SXMO_DEVICE_NAME.sh")"
> +	# shellcheck disable=SC1090
> +	if [ -f "$deviceprofile" ]; then
> +		. "$deviceprofile"
> +		printf "deviceprofile file %s loaded.\n" "$deviceprofile"

Thanks!

To git@git.sr.ht:~mil/sxmo-utils
   ef82546..c95f3d9  master -> master
--
w:] www.momi.ca
pgp:] https://momi.ca/publickey.txt

Thanks!

To git@git.sr.ht:~mil/sxmo-utils
   ee180f6..ef82546  master -> master
--
w:] www.momi.ca
pgp:] https://momi.ca/publickey.txt

Hi!

I like how much this simplifies our shell script. However, this patch
also adds one more dependency.

I would be willing to merge this if:

1. We can support rgb multi-intensity devices via brightnessctl https://lists.sr.ht/~mil/sxmo-devel/patches/44149
2.  We can fix https://gitlab.com/postmarketOS/pmbootstrap/-/issues/2257

I think we can fix 2 if we use Ellie's suggestion from that issue:

> I guess an alternate approach would be to use setuid and make sure it
> runs as its own user that is in the input group, even when launched by

Hi!

Thank you for your patch. However, I wonder if supporting rgb
multi-intensity devices would be simpler using brightnessctl as
suggested here:

https://lists.sr.ht/~mil/sxmo-devel/patches/44136

I am not sure about the patch that adds brightnessctl but if
adding one more dependency allows us to support the one plus 6, I would
recommend merging in brightnessctl.

Thank you!
--

Thanks!

To git@git.sr.ht:~mil/sxmo-utils
   e2b2c51..e6c02e3  master -> master
--
w:] www.momi.ca
pgp:] https://momi.ca/publickey.txt

Hi!

I really like this patch. Can you please send a v2 that I can apply via
git am? It seems even the CI has issue applying this patch.

Thanks!
Anjan
--
w:] www.momi.ca
pgp:] https://momi.ca/publickey.txt