Hi,

Sorry for responding so late, I've been beyond busy lately...

NRK <nrk@disroot.org> writes:

> On Thu, Feb 02, 2023 at 11:02:27AM +0100, Arsen Arsenović wrote:
>> Does breaking on __assert_fail do the trick for you?  Technically, it's
>> still a frame higher, but IMO that's worth it over adding unnecessary
>> platform-specifics and worse runtime behavior.
>>
>> You can't assume you're running in a debugger when designing software,
>
> It's a bit better, but still not quite there. But perhaps that can be

---
Hi,

Here's the patch we discussed in the permalink breadcrumb thread,
specifically, <CQJBSCL907MD.XXNPR8GBC72G@taiga>.

Apologies for the inconvenience.

 srht/flask.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srht/flask.py b/srht/flask.py
index 8ac0012..fee67de 100644
--- a/srht/flask.py
[message trimmed]

Morning Drew,

"Drew DeVault" <sir@cmpwn.com> writes:

> I took 1/2 but 2/2 was not adequately tested, it causes repo pages to
> 500. Test your patches before sending them, please.

Thanks for the merge.

The second patch definitely worked locally.  I assume you see:

  jinja2.exceptions.TemplateSyntaxError: Encountered unknown tag
  'do'. Jinja was looking for the following tags: 'endmacro'. The
  innermost block that needs to be closed is 'macro'.

Morning,

NRK <nrk@disroot.org> writes:

> On Wed, Feb 01, 2023 at 08:12:54PM +0100, Arsen Arsenović wrote:
>> There's also no need to ``up'' many times, as the author suggests,
>> instead, you can ``select-frame'' or ``up N''.
>
> I personally use `f $N` to jump to a frame. But with `__builtin_trap`
> there's no need to do that at all as it will break right where the
> assertion failed - which is less friction than having to `bt + f $n`
> (unless you happen to know something I don't that can make standard C
> assertions have the same effect).

Hi,

NRK <nrk@disroot.org> writes:

> Hi Arsen,
>
> Just read the article and am quite pleased with it. It's short and sweet
> and gets to the point quickly - I think this will be my go to reference
> the next time I need to explain assertions to someone.
>
> It's unfortunate that the education around `assert` is so poor, it has
> been a very valuable tool in my experience (especially in early
> development where things can change rapidly).
>

Evening,

"Drew DeVault" <sir@cmpwn.com> writes:

> Screenshot?

Looks like my previous email got filtered.  Here's a directory
containing the four screenshots I tried to send:
https://www.aarsen.me/~arsen/screenshots/drew/

They depict the download key and permalinks in three different contexts.

Thanks in advance, have a great night.
--

---
 gitsrht/templates/blame.html | 2 +-
 gitsrht/templates/blob.html  | 2 +-
 gitsrht/templates/log.html   | 2 +-
 gitsrht/templates/tree.html  | 2 +-
 gitsrht/templates/utils.html | 8 +++++++-
 5 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/gitsrht/templates/blame.html b/gitsrht/templates/blame.html
index 35fa71b..2c09ea5 100644
--- a/gitsrht/templates/blame.html
+++ b/gitsrht/templates/blame.html
@@ -18,7 +18,7 @@ pre, body {
 <div class="header-extension" style="margin-bottom: 0;">
[message trimmed]

---
 gitsrht/templates/commit.html | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gitsrht/templates/commit.html b/gitsrht/templates/commit.html
index b3af682..3956e72 100644
--- a/gitsrht/templates/commit.html
+++ b/gitsrht/templates/commit.html
@@ -30,6 +30,13 @@
             ref=commit.id.hex)}}"
           class="btn btn-default btn-block"
         >browse {{icon("caret-right")}}</a>
+        <a
+          href="{{url_for("repo.archive",
[message trimmed]

Hi there,

This patchset adds a "Permalink" button to all pages with breadcrumbs as
well as a "download" button to a commit page, to allow people to more
easily download specific revisions of repositories.

The new breadcrumb required a Jinja extension to implement fully
generically, but I don't think this is too bad.

Arsen Arsenović (2):
  commit.html: Add button to download .tar.gz
  utils.html: Add a permalink breadcrumb

 gitsrht/templates/blame.html  | 2 +-

Detected on Tinderbox with FORTIFY_SOURCE=3.

Bug: https://bugs.gentoo.org/882295
---
Hey there,

The Tinderbox spotted a potential error in determine_target_build_name while
running tests.  I traced it back to a bad concat, fix included.

Tested on x86_64-pc-linux-gnu, though I'm unsure if I got all the
configurations or if the contract of the function is still fulfilled following
this change (but it appears to be to me).

Thanks in advance, and have a great night!
[message trimmed]