~athorp96

North Carolina, United States

https://thorp.dev

Software Engineer at Nexhealth

~athorp96/sourcehut-issue-mirror-github-action

Last active 2 months ago
View more

Recent activity

Re: getting "failed to get key 0 from from" on paste.sr.ht when creating a new simple paste 5 months ago

From Andrew Thorp to ~sircmpwn/sr.ht-discuss

Actually, it appears that attachments aren't allowed on the mailing list.
Perhaps uploading it to an image hosting site and sharing a link would work.

Cheers,

Andrew

Re: getting "failed to get key 0 from from" on paste.sr.ht when creating a new simple paste 5 months ago

From Andrew Thorp to ~sircmpwn/sr.ht-discuss

Hi Przemysław,

I believe you may have forgotten to attach the screenshot.

- Andrew

[PATCH] scheduler: define documented types for Future's input 5 months ago

From Andrew Thorp to ~gioverse/chat

This commit adds WorkFunc and AndThenFunc generic types which are used
as input to Future(). This allows more explicit and nuanced
documentation for using Future() without having a novel of docs for a
single function. For example: specifying that the WorkFunc doesn't block
the event loop but AndThenFunc does is a useful detail but isn't as
relevant to the Future() function as much as it is to the closures
themselves.

Signed-off-by: Andrew Thorp <andrew.thorp.dev@gmail.com>
---
 scheduler/scheduler.go | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/scheduler/scheduler.go b/scheduler/scheduler.go
[message trimmed]

Re: [WIP][PATCH] Gray out reply list when drafting a conversation 5 months ago

From Andrew Thorp to ~whereswaldon/arbor-dev

I believe I've found the issue. I was using 
`theme.Background.Default.Bg` when
I should have been using `c.Theme().Current().Bg`. I'll have the patch 
ready soon.

Cheers,

Andrew Thorp

On Wed, Jun 15, 2022 at 11:12 PM, Andrew Thorp 
<andrew.thorp.dev@gmail.com> wrote:
> Hey fellas,
> 
> I implemented a feature where the message lists gets grayed out a bit 

[WIP][PATCH] Gray out reply list when drafting a conversation 5 months ago

From Andrew Thorp to ~whereswaldon/arbor-dev

Hey fellas,

I implemented a feature where the message lists gets grayed out a bit when
composing a conversation, as opposed to a reply. It seems to work well, however
it doesn't seem to work at all in dark mode; there doens't appear to be any
rectangle appearing at all... I've been looking through and I can't find out
why it wouldn't work in dark mode. Any advice would be appreciated.

Thanks!

Andrew Thorp

---
 reply-view.go            | 24 +++++++++++++++++++++---
[message trimmed]

[PATCH 2/2] Update build script to use 'go install' instead of 'go get' 6 months ago

From Andrew Thorp to ~whereswaldon/arbor-dev

---
 .builds/debian.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.builds/debian.yml b/.builds/debian.yml
index 5bba6fe..95374fa 100644
--- a/.builds/debian.yml
+++ b/.builds/debian.yml
@@ -42,7 +42,7 @@ tasks:
 - mirror: |
    # mirror to github while we wait for android
    ssh-keyscan github.com > "$HOME"/.ssh/known_hosts && cd sprig && git push --mirror "$github_mirror" || echo "failed mirroring"
 - install_mage: go get github.com/magefile/mage
 - install_mage: go install github.com/magefile/mage@latest
[message trimmed]

[PATCH 1/2] Add dynamic composer prompt. Use different prompts for new replies and conversations 6 months ago

From Andrew Thorp to ~whereswaldon/arbor-dev

---
Good morning,

This patch fixes the misleading prompt when starting a new conversation "Compose your reply".
Once applied, the prompt will remain the same for replying to messages but when creating a
new conversation the composer will prompt with "Start a new conversation".

Please let me know if you have any feedback.

Thanks,

Andrew
[message trimmed]

Re: [PATCH] fix: replace references to renamed struct attribute 6 months ago

From Andrew Thorp to ~whereswaldon/arbor-dev

Apologies for the formatted patch. Its been a minute since Ive used
git-send-email, and I thought text went below the `---`. Please let me 
know if
you need another copy of the patch. I can supply it directly as an 
attachment.

Best,

Andrew Thorp

[PATCH] fix: replace references to renamed struct attribute 6 months ago

From Andrew Thorp to ~whereswaldon/arbor-dev

---

Hello!

It seems there is a bug in `main` right now. Recently the `ReplyListView` had
its `States` attribute renamed to `ReplyStates`. Some of the attribute
references didn't get updated. This commit addresses that. I have confirmed it
builds on Linux(Ubuntu).

Please let me know if you have any questions of feedback.

Best,

Andrew Thorp
[message trimmed]

Re: TLS Failure at gemini://srht.site 8 months ago

From Andrew Thorp to ~sircmpwn/sr.ht-discuss

Hi Eugen,

Self signing is a tenet of Gemini TLS. That shouldn’t be a blocker to
accessing the capsule. I don’t know about this particular case but in
general I wouldn’t consider that a red flag. It is one of the primary
reasons TOFU certificate validation is recommended.

See section 4.2: https://gemini.circumlunar.space/docs/specification.gmi

Cheers,

Andrew