~athorp96

North Carolina, United States

https://keybase.io/awildthorp

Graduate DevOps Software Engineer at Inmar Intelligence

Recent activity

Re: [PATCH forest-go v3 2/2] Use twig key parser 21 hours ago

From Andrew Thorp to ~whereswaldon/arbor-dev

That’s what code review is for ;) 

Sent from my iPhone

> On Jul 12, 2020, at 12:02 PM, Chris Waldon <christopher.waldon.dev@gmail.com> wrote:
> 
> Thanks, this is applied! I appreciate your patience on the
> multiple revisions.

[PATCH arborchat] Add Sprig to project list a day ago

From Andrew Thorp to ~whereswaldon/arbor-dev

---
 index.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/index.md b/index.md
index ba4dfd4..4dbd0af 100644
--- a/index.md
+++ b/index.md
@@ -22,7 +22,7 @@ Arbor messages track what you were responding to when you wrote them. Every mess

If you think about it, most things you say in a conversation are a response to what someone else just said. Arbor simply captures that information and uses it to help you make sense of very large conversations. Ever get confused when many people respond to a message at around the same time? Arbor makes that situation coherent.

![visualisation of some Arbor nodes](./diagrams/Simple_Forest_Light.png)
![visualization of some Arbor nodes](./diagrams/Simple_Forest_Light.png)
[message trimmed]

[PATCH forest-go v3 2/2] Use twig key parser 2 days ago

From Andrew Thorp to ~whereswaldon/arbor-dev

---
 cmd/forest/main.go | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/cmd/forest/main.go b/cmd/forest/main.go
index bb2e7df..1b57c50 100644
--- a/cmd/forest/main.go
+++ b/cmd/forest/main.go
@@ -8,8 +8,6 @@ import (
	"io"
	"io/ioutil"
	"os"
	"strconv"
	"strings"
[message trimmed]

[PATCH forest-go v3 1/2] Add metadata handling 2 days ago

From Andrew Thorp to ~whereswaldon/arbor-dev

Add twig read/write functionality to node creation

Address feedback

Fix struct accessibility

Address some feedback

Use valid key string

Add Contains and Get functions to sprig data

Use <key>/<version> to add metadata
Update docs
[message trimmed]

Re: README.md preview on sub-directories 2 days ago

From Andrew Thorp to ~sircmpwn/sr.ht-discuss

I agree as well. I would love to see this as a feature in Source Hut.

Thanks,

Andrew Thorp
@athorp96

Re: [PATCH sprig] Add install script and resources to linux build 8 days ago

From Andrew Thorp to ~whereswaldon/arbor-dev

That sounds good to me. I'll update the script and send out a new
patch set. :+1:

Re: [PATCH sprig] Add install script and resources to linux build 8 days ago

From Andrew Thorp to ~whereswaldon/arbor-dev

> > +LINUX_FILES = $(LINUX_BIN) ./desktop-assets ./install-linux.sh
> > ./appicon.png
>
> I wonder whether we shouldn't also include the license? Eventually, I'd like
> to bundle together the licenses of all of our dependencies as well, but that's
> sufficiently complex that it can wait.

That's a good idea. I'll add that in.

> > +PREFIX=${PREFIX:-${XDG_DATA_HOME:-$HOME/.local/share}}
> > +BIN_PREFIX=/usr/local/bin
>
> Why not install into $PREFIX/bin? I think that's the conventional behavior.
> I can understand why you might be reluctant to do that because ~/.local/bin

[Wisteria] Failed to send message: Too Many Open Files 2 months ago

From Andrew Thorp to ~whereswaldon/arbor-dev

Good morning, everyone.

I’ve had Wisteria fail to send messages the last few days. I looked at
the log when it occurred today, and the error I see there is
```
2020/05/04 11:20:09 history_widget.go:371: Failed finalizing reply:
failed creating reply: Error starting gpg command: pipe: too many open
files
```
It seems that there is a soft limit on the forest size, given the
current method for reading the forrest.
It may be time to rethink the way which wisteria stores/handles nodes.
This probably warrants a more in-depth discussion, but I’d be happy to
help out with this fix.

Re: [PATCH] Nodes marked as invisible no longer rendered 4 months ago

From Andrew Thorp to ~whereswaldon/arbor-dev

Thanks for taking a look!

Migrating to a more robust metadata check was my intention, I wasn’t sure if it belonged in the initial patch though. 

I didnt go with status in particular because my next plan was to check for an expire-time. Though I’m not dead set on that feature path. 

Andrew 

> On Mar 9, 2020, at 4:45 PM, Chris Waldon <christopher.waldon.dev@gmail.com> wrote:
> 
> I was able to confirm that this is working as expected! I do have
> some questions though.
> 
> After looking at this in practice, I'm left wondering whether we

[PATCH] Nodes marked as invisible no longer rendered 4 months ago

From Andrew Thorp to ~whereswaldon/arbor-dev

This patch prevents wisteria from rendering nodes that contain a twig entry with the key "invisible/1".

I felt it was necessary to put this check in its own function as there are plans to extend the scope of what makes a node invisible.
Thoughts and feedback appreciated. 

Cheers,

Andrew Thorp

---
 render.go | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/render.go b/render.go
[message trimmed]