Make sure that links placed verbatim inside HTML elements' bodies are
not parsed along with adjacent HTML tags as illustrated in the new test
case.

Also change the existing code to use the idiomatic Go way to get a
set-like functionality.

Changelog-fixed: Parsed links in HTML message parts now do not include
 trailing HTML tags.
Signed-off-by: Karel Balej <balejk@matfyz.cz>
---
 app/msgviewer.go             |  2 +-
 lib/parse/hyperlinks.go      | 17 +++++++++++------
 lib/parse/hyperlinks_test.go | 14 +++++++++++++-
[message trimmed]

Add a command to copy links to the system clipboard. This can be useful
for instance when the URL should be handled in some other way than
opened (e. g. resent via some other communication channel or saved to a
file). It also improves security for situations where it's not desirable
for the URL to be visible on the process command line, such as when it
contains sensitive information such as an access token.

Adapted from open-link.

Changelog-added: If supported by the terminal, links from a message can
 now be copied to the system clipboard with the :copy-link command of the
 message viewer.
Signed-off-by: Karel Balej <balejk@matfyz.cz>
---
[message trimmed]

Add a command to copy links to the system clipboard. This can be useful
for instance when the URL should be handled in some other way than
opened (e. g. resent via some other communication channel or saved to a
file). It also improves security for situations where it's not desirable
for the URL to be visible on the process command line, such as when it
contains sensitive information such as an access token.

Adapted from open-link.

Changelog-added: If supported by the terminal, links from a message can
 now be copied to the system clipboard with the :copy-link command of the
 message viewer.
Signed-off-by: Karel Balej <balejk@matfyz.cz>
---
[message trimmed]

Threaded directories were never marked as loaded and thus the terminal
bell was never rung when a new message arrived in them. Add the missing
directive to mark them as loaded when appropriate.

Fixes: 8d4704775b1e ("msgstore: do not trigger notification on initial load")
Changelog-fixed: The new-message bell is now rung again for threaded
 directories as well.
Cc: Remko Tronçon <remko@el-tramo.be>
Signed-off-by: Karel Balej <balejk@matfyz.cz>
---
Thank you for the original patch by the way, it is great not having to
clear the bell every time I start aerc :-)

 lib/msgstore.go | 1 +
[message trimmed]

Robin Jarry, 2025-01-21T11:25:24+01:00:
> Error, success and warning messages are dimmed as well making them
> unreadable on that light gray background.
>
> Remove the gray background for the status line. Make error, success and
> warning messages more visible by using bright colors, disabling dimmed
> and enabling bold attributes.
>
> Changelog-fixed: The `default` styleset status line background has
>  been reset to the default color (light or dark, depending on your
>  terminal color scheme) in order to make error, warning or success
>  messages more readable.
> Cc: Karel Balej <balejk@matfyz.cz>
> Signed-off-by: Robin Jarry <robin@jarry.cc>

Robin Jarry, 2025-01-21T09:32:23+01:00:
> Hi Karel,
>
> Karel Balej, Jan 21, 2025 at 09:10:
>> I imagined that you would keep the background for all of the messages,
>> including errors etc. It would probably seem more natural to me and at
>> least the error messages are still very well legible on the background
>> with the bright shade of red you have picked.
>
> The issue is that it depends on the color scheme. On some themes, color
> number 8 is completely black (same as color 0), on some other themes, it
> is a medium gray, making the text very hard to read because of the low
> contrast with the foreground color.
>

Hi, Robin,

thanks for Cc'ing me.

Robin Jarry, 2025-01-20T23:14:25+01:00:
> Error, success and warning messages are dimmed as well making them
> unreadable on that light gray background.
>
> Remove the dimmed attribute on the status line. Only keep the light gray
> background for default messages. Make error, success and warning
> messages more visible by using bright and bold colors on default
> background color.

I imagined that you would keep the background for all of the messages,

When composing a message, the location of the popovers was not offset by
the location of the field that was being completed (To, Cc,...)
resulting in them appearing always at the same position near the top
left corner of the window. Restore the offset to have them appear right
underneath the active field again.

Fixes: 787cfbd9a90a ("ui: remove screen and viewports")
Changelog-fixed: The address-book completion popovers now again appear
 under the field being completed.
Signed-off-by: Karel Balej <balejk@matfyz.cz>
---
 lib/ui/context.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
[message trimmed]

Lee Jones, 2024-10-15T09:36:03+01:00:
> On Sat, 12 Oct 2024, Karel Balej wrote:
>
> > Add a MFD cell for the chip's real-time clock.
> > 
> > Signed-off-by: Karel Balej <balejk@matfyz.cz>
> > ---
> > 
> > Notes:
> >     RFC v2:
> >     - Break out the register definitions and reword the commit message
> >       accordingly.
> >     - RFC v1: https://lore.kernel.org/r/20240920161518.32346-1-balejk@matfyz.cz/
> > 

This sets the likely usually desired From address when replying to a
previously sent email and does not compose To the alias instead (unless
reply-to-self is enabled).

Changelog-fixed: Aliases are now taken into account correctly when
 replying to own messages such as from the Sent folder or via a mailing
 list.
Signed-off-by: Karel Balej <balejk@matfyz.cz>
---

Notes:
    v2:
    - Make non-RFC so the CI runs.
    - Rebase on current master.
[message trimmed]