~bearbin

United Kingdom

https://bearbin.net/blog/

Recent activity

Outdated openring binary 1 year, 1 month ago

From Alexander Harkness to ~sircmpwn/public-inbox

The openring binary hosted on yukari.sr.ht is currently outdated, and
causes the default template to fail with an error:

    panic: template: template:13: function "datef" not defined

    goroutine 1 [running]:
    main.main()
    	/home/sircmpwn/sources/openring/openring.go:82 +0x105e

It would be good to get it updated or removed from the docs to avoid any
confusion.

Re: [PATCH v3] Add missing argument to scrolling-commands (prev,next,etc.) 1 year, 1 month ago

From Alexander Harkness to ~sircmpwn/aerc

Don't merge this just yet, I discovered an issue where mouse-scrolling
does not work with the new code. For some reason it works if I put an
extra ml.Invalidate() inside MouseEvent() even though
ml.ScrollToSelected() is already called, which itself calls
ml.Invalidate().

Double-invalidation should have no effect, right? Any suggestions as to
what could be going on here would be appreciated.

[PATCH] Do not open message when clicking on msglist scrollbar 1 year, 1 month ago

From Alexander Harkness to ~sircmpwn/aerc

Also remove potential nil-dereference, and rename percent to
portion, as the values represented were not percents.
---
 widgets/msglist.go | 49 ++++++++++++++++++++++++----------------------
 1 file changed, 26 insertions(+), 23 deletions(-)

diff --git a/widgets/msglist.go b/widgets/msglist.go
index 626f4c9..bccb719 100644
--- a/widgets/msglist.go
+++ b/widgets/msglist.go
@@ -20,6 +20,7 @@ type MessageList struct {
	conf          *config.AercConfig
	logger        *log.Logger
	height        int
[message trimmed]

[PATCH v3] Add missing argument to scrolling-commands (prev,next,etc.) 1 year, 1 month ago

From Alexander Harkness to ~sircmpwn/aerc

Allows scrolling away from the cursor. There is no change to
behaviour on moving the cursor, the scroll position will be reset.
---
This means ripping out most of the patch by ~jeffas that was just
merged, but the behaviour should be the same except in one case:
resizing the window will not scroll so the selected item is visible.
If we allow scrolling decoupled from the selected message, then it
makes more sense to do this when resizing; and avoiding this would
mean a brittle heuristic.

 commands/account/next-result.go |  4 +--
 commands/account/next.go        | 62 ++++++++++++++++++++-------------
 commands/account/search.go      |  2 +-
 commands/msgview/next.go        |  4 +--
[message trimmed]

[PATCH] Fix missing escape in aerc-config manpage 1 year, 1 month ago

From Alexander Harkness to ~sircmpwn/aerc

Underscores were being elided by scdoc when they should have been
rendered verbatim in the output.
---
 doc/aerc-config.5.scd | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/aerc-config.5.scd b/doc/aerc-config.5.scd
index eb88849..2bd3076 100644
--- a/doc/aerc-config.5.scd
+++ b/doc/aerc-config.5.scd
@@ -584,8 +584,8 @@ following special keys are supported:
:  Ctrl+[
|  c-^
:  Ctrl+^
[message trimmed]

[PATCH v2] Add missing argument to scrolling-commands (prev,next,etc.) 1 year, 1 month ago

From Alexander Harkness to ~sircmpwn/aerc

Allows scrolling away from the cursor. There is no change to
behaviour on moving the cursor, the scroll position will be reset.
---
 commands/account/next.go | 62 ++++++++++++++++++++++++----------------
 commands/msgview/next.go |  4 +--
 doc/aerc.1.scd           |  8 ++++--
 widgets/msglist.go       | 20 ++++++++++++-
 4 files changed, 65 insertions(+), 29 deletions(-)

diff --git a/commands/account/next.go b/commands/account/next.go
index 5e4838e..5bcf25f 100644
--- a/commands/account/next.go
+++ b/commands/account/next.go
@@ -7,6 +7,7 @@ import (
[message trimmed]

[PATCH] fixup! Add missing argument to scrolling-commands (prev,next,etc.) 1 year, 1 month ago

From Alexander Harkness to ~sircmpwn/aerc

---
 doc/aerc.1.scd | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/aerc.1.scd b/doc/aerc.1.scd
index 61e35bb..66055cf 100644
--- a/doc/aerc.1.scd
+++ b/doc/aerc.1.scd
@@ -184,11 +184,13 @@ message list, the message in the message viewer, etc).
*mkdir* <name>
	Creates a new folder for this account and changes to that folder.

*next* <n>[%], *prev* <n>[%]
*next* [-s] <n>[%], *prev* [-s] <n>[%]
[message trimmed]

[PATCH] Add missing argument to scrolling-commands (prev,next,etc.) 1 year, 1 month ago

From Alexander Harkness to ~sircmpwn/aerc

Allows scrolling away from the cursor. There is no change to
behaviour on moving the cursor, the scroll position will be reset.
---
This was the simplest solution I thought of, it would be nice if
the cursor did not get too far away when scrolling, or alternatively
implementing a secondary 'scroll cursor' but both of those seemed
complicated with lots of edge cases. 

 commands/account/next.go | 62 ++++++++++++++++++++++++----------------
 commands/msgview/next.go |  4 +--
 widgets/msglist.go       | 20 ++++++++++++-
 3 files changed, 59 insertions(+), 27 deletions(-)

diff --git a/commands/account/next.go b/commands/account/next.go
[message trimmed]

Re: [PATCH] Remove nonexistent argument from default pagedown keybind 1 year, 1 month ago

From Alexander Harkness to ~sircmpwn/aerc

On Thu, 11 Jun 2020 10:14:42 -0400
"Drew DeVault" <sir@cmpwn.com> wrote:

> The correct solution is to implement this argument.

Without any documentation, I have no idea what this mystery argument is
supposed to do. And I can't implement a feature described only by `-s`.

Is it meant to scroll the view without affecting the cursor?