Last active 4 years ago


Last active 4 years ago


Last active 5 years ago
View more

Recent activity

Re: Relicensing aerc to GPL 1 year, 3 months ago

From Ben Burwell to ~rjarry/aerc-devel

I accept the change from MIT to GPLv3.

Re: [pages] ssl error in safari (iPad) 3 years ago

From Ben Burwell to ~sircmpwn/sr.ht-discuss

> I have an issue with my
> site at (https://phi1_h.srht.site/posts/uebersicht-antraege/). If I try
> to load it on my iPad (both safari and chrome) I get an ssl certificate
> error("Can't establish a secure connection to this server").

I tried loading your URL on my iDevice (iOS 14.4.2) and got the same connection error. I am able to load other srht pages without issue though.

I am not positive, but I have a strong hunch that this is due to the underscore in your URL. Underscores iirc are not permitted in hostnames per RFC, so it would not surprise me if implementations vary in their support/adherence.

Re: [pages] Behaviour of Links 3 years ago

From Ben Burwell to ~sircmpwn/sr.ht-discuss

It looks like the issue with the relative links is that when you navigate to /example, when the browser fetches astyle.css it will load /astyle.css instead of /example/astyle.css.

If you navigate instead to /example/ your page works as expected (other than the CSP issue).

It looks like the nearly free speech site is redirecting /example to /example/, so thats why its working correctly there.

Re: Users interested in git-lfs support; build caches 4 years ago

From Ben Burwell to ~sircmpwn/sr.ht-discuss

It appears you're already using docker for your build. I didn't look
very closely at what you're doing, but something that might help is to
build a custom docker image that's already set up with your
dependencies, then start your CI build by just pulling the image and
working from there.

I recognize that this isn't quite the same thing as caching
dependencies, but it might help speed up your build in the meantime.

Re: [PATCH] worker/lib/parse: be more tolerant with parsing email addresses 4 years ago

From Ben Burwell to ~sircmpwn/aerc

I was talking about aerc's parseAddressList function in
worker/lib/parse.go, which calls Header.AddressList from emersion's
go-message library, which in turn calls AddressParser.ParseList from the
standard library.

Both the standard library and emersion's go-message are pretty strict in
their adherence to the RFC 5322. Aerc's parseAddressList function is
meant to attempt parsing with go-message, but if an unparsable address
list is found for whatever reason, it should still return something
useful for the UI.

So I think the solution is 2-fold:

1) update aerc's parseAddressList to fix the err == nil check and remove

Re: [PATCH] worker/lib/parse: be more tolerant with parsing email addresses 4 years ago

From Ben Burwell to ~sircmpwn/aerc

On Thu Jan 30, 2020 at 08:53, Simon Ser wrote:
> I think this is already supposed to be handled by parseAddressList.

That is correct.

> if hdr, err := h.Text(key); err == nil && strings.Contains(hdr, "@") {

The strings.Contains also was inverted in
baa70469c3b25e1b937c9c2a9e0b16762a227bca, it should be
!strings.Contains. Which won't actually solve the problem for the
message you're seeing; perhaps we can drop the strings.Contains

In any case, parseAddressList is meant to be lenient.

Re: Discussion: Add color configuration 4 years ago

From Ben Burwell to ~sircmpwn/aerc

Awesome! This seems like a reasonable design to me.

Re: [PATCH v2] Contextual UI Configuration 4 years ago

From Ben Burwell to ~sircmpwn/aerc

On Thu Jan 23, 2020 at 13:56, Srivathsan Murali wrote:
> + Adds parsing of contextual ui sections to aerc config.
> + Add GetUiConfig method for AercConfig that is used to get the
>   specialized UI config.
> + Add UiConfig method to AccountView to get specialized UI Config.
> + Modifies Aerc codebase to use specialized UIConfig instead.
> + Adds documentation for Contextual UI Configuration
> ---
> Finaly got time to work on v2 of this patch, made changes according
> to Drew's feedback from the last version.
> Also added subject context to have specific index-format for patches.
> Happy new year folks :D

[PATCH] Fix handling of multiple template-dirs 4 years ago

From Ben Burwell to ~sircmpwn/aerc

Before, while the docs stated that template-dirs was a colon-separated
list, a delimiter was not specified in the struct tag, so it was falling
back to the default for the ini library (a comma). Also added a note to
the docs to clarify that templates are configured in the [templates]
 config/config.go      | 6 +++---
 doc/aerc-config.5.scd | 4 +++-
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/config/config.go b/config/config.go
index e5f7395..fe548ff 100644
--- a/config/config.go
+++ b/config/config.go
[message trimmed]

Re: [PATCH] imap: emit messageinfo when changing read state. 4 years ago

From Ben Burwell to ~sircmpwn/aerc

On Thu Jan 23, 2020 at 08:17, Reto Brunner wrote:
> -	imapw.worker.PostMessage(&types.Done{types.RespondTo(msg)}, nil)
> +	imapw.worker.PostAction(&types.FetchMessageHeaders{
> +		Uids: msg.Uids,
> +	}, func(msg types.WorkerMessage) {
> +		switch m := msg.(type) {
> +		case *types.Error:
> +			err := fmt.Errorf("handleReadMessages: %v", m.Error)
> +			imapw.worker.Logger.Printf("could not fetch headers: %s", err)
> +			emitErr(err)
> +		case *types.Done:
> +			imapw.worker.PostMessage(&types.Done{types.RespondTo(msg)}, nil)

Note that the msg parameter from the callback is shadowing here, so the