~bouncepaw

Russia

https://garden.bouncepaw.com

Mycoverse inceptor.

~bouncepaw/betula

Last active 3 months ago

~bouncepaw/mycorrhiza-devel

Last active 10 months ago

~bouncepaw/mycomarkup-devel

Last active 1 year, 4 months ago
View more

Recent activity

Re: [PATCH] Use betula user agent when sending outgoing requests 3 months ago

From Timur Ismagilov to ~bouncepaw/betula

Thank you! Applied.

Re: [PATCH] Use betula user agent when sending outgoing requests 3 months ago

From Timur Ismagilov to ~bouncepaw/betula

Thanks for the contribution, arne!

Having a User-agent is something we indeed want to have. We have a
ticket [1] for that!

I can't accept the patch in its current form though. The way User
agent is implemented is perfectly fine, I don't like the version
related stuff. You can split this patch in two parts: one user
agent related, one version related, and maybe just ditch the latter
one.

What I don't like about the version:

1) The file storing the version is called .version_string.txt. I do

Re: [PATCH betula v3] Migrate from gorilla/feeds 7 months ago

From Timur Ismagilov to ~bouncepaw/betula

Took the closest look at the timestamp. It is different from what it was
before, but turns out to be fully standards-compilant! Applying the
patch, thank you!

Re: [PATCH betula] Migrate from gorilla/feeds. 7 months ago

From Timur Ismagilov to ~bouncepaw/betula

Wonderful, thank you! I especially like how you bumped x/crypto and
x/net dependencies.

There is an issue with timestamps though.


> +		PubDate:     now.String(),

You turn it into string with String, which ends up with a timestamp like
2024-02-20 10:23:30.466972 +0300 MSK m=+65.648189751, but previously it
was Tue, 20 Feb 2024 07:23:19 +0000. I suppose this format is called
RFC-822. Use the Format function instead.

Meanwhile I'll fix the tests...

Re: [PATCH 0/4] implement changing password 10 months ago

From Timur Ismagilov to ~bouncepaw/mycorrhiza-devel

Thank you! Ran a quick test, seems to work as expected. Applying. I will provide
the translation myself.

Re: [PATCH v2] Better URL cleaning for display 10 months ago

From Timur Ismagilov to ~bouncepaw/betula

LGTM. Thanks!

Re: [RFC PATCH] WIP: add /query page 10 months ago

From Timur Ismagilov to ~bouncepaw/betula

Cool feature!

> It works, but the UI is sorely lacking: columns (and the table overall) is too
> thin. `SELECT * FROM Posts` type of queries would probably also benefit
> from displaying them as post feed instead of a table.

Yeah, this is true. In the body block of template, maybe move the <table>
outside of <main>, so it can be as wide as the page is? Or make it horizontally
scrollable? Displaying as posts would be great, but it would be fine to
implement it later, in a different patch. Looking at column names, and deducing
if the result can be shown as a post by that? Sounds doable.

Some logging would also be nice. Also, running an empty query results in Betula
hanging. The database gets locked, maybe?

Re: [PATCH] Better URL cleaning for display 10 months ago

From Timur Ismagilov to ~bouncepaw/betula

Thanks! Kudos for writing the test.

I have found a bug though, I think you should fix it and write an additional test
for it. If you save a mailto: link such as betula@example.org, it gets
displayed as mailto://.

I expect a similar problem to happen with schemes like tel: and others that do
not have a slash after the colon.

Re: [PATCH] Fix migration from empty database 10 months ago

From Timur Ismagilov to ~bouncepaw/betula

LGTM. Applied. Thanks!

Re: [PATCH betula] Fix wrong number of posts when unauthorized 1 year, 1 month ago

From Timur Ismagilov to ~bouncepaw/betula

LGTM. Applied. Thanks!