Let me know how it looks on other browsers and I'll try again!
Rosie K Languet (1):
center search bar with standard flexbox
static/default.css | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
--
2.34.5
Rosie, thank you for the contribution!
I have tested it in WebKit and Chromium. It looks the
same and is centered vertically well.
There is an issue: the search bar is no longer centered
horizontally! I think it should retain its horizontal
position, while being improved vertically. So, waiting
for improvements for now.
As for your other patch, I am looking forward to review
it. I will get to it as soon as possible. Probably this
week.
Umar, thank you for the detailed instruction! I did not
know of cover letters before, as I am new to email
myself. Would you mind making this instruction a hypha
so that it can be easily referenced later? We probably
need a generic email contribution guide anyway.
Here's what could be a correct version of this patch, by the way.
diff --git a/static/default.css b/static/default.css
index 8d09d53..ee946cc 100644
--- a/static/default.css+++ b/static/default.css
@@ -686,10 +686,13 @@ a.btn_destructive:visited,
.top-bar__search-bar {
border: 0;
- vertical-align: -webkit-baseline-middle; /* You have no idea how sorry I am. This is a non-standard value. Seems to work in Safari, Opera and mobile Chrome. We need a jedi and a knight in shiny armor to replace it with something more standard. */ width: 100%;
}
+.top-bar__section_search {+ align-self: center;+}+@media (prefers-color-scheme: dark) {
.top-bar a {
color: #ddd;
[PATCH mycorrhiza 1/1] center search bar with standard flexbox
Export this patch
From: Rosie K Languet <rkl@rosiesworkshop.net>
---
static/default.css | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/static/default.css b/static/default.css
index 0cc496f..9c985fe 100644
--- a/static/default.css+++ b/static/default.css
@@ -685,9 +685,13 @@ a.btn_destructive:visited,
padding: 0 .5rem;
}
+.top-bar__section_search {+ display: flex;+ align-items: center;+}+.top-bar__search-bar {
border: 0;
- vertical-align: -webkit-baseline-middle; /* You have no idea how sorry I am. This is a non-standard value. Seems to work in Safari, Opera and mobile Chrome. We need a jedi and a knight in shiny armor to replace it with something more standard. */ width: 100%;
}
--
2.34.5