~brettgilio

Missouri, USA

~brettgilio/org-webring

Last active 3 years ago

~brettgilio/blog-discussion

Last active 3 years ago
View more

Recent activity

Re: [PATCH v2] Add strikethrough support to SrhtRenderer 1 year, 10 months ago

From Brett Gilio to ~sircmpwn/sr.ht-dev

On 7/22/2022 1:04 PM, jack gleeson wrote:

> ---
> This patch adds del to the html sanitize
> whitelist, allowing strikethroughs.
>   srht/markdown.py | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/srht/markdown.py b/srht/markdown.py
> index 5005542..4b8431b 100644
> --- a/srht/markdown.py
> +++ b/srht/markdown.py
> @@ -12,7 +12,7 @@ import mistletoe as m
>   from mistletoe.span_token import SpanToken, RawText

Re: [PATCH core.sr.ht] Add strikethrough support to SrhtRenderer 1 year, 10 months ago

From Brett Gilio to ~sircmpwn/sr.ht-dev

On 7/22/2022 3:05 AM, Drew DeVault wrote:
> On Fri Jul 22, 2022 at 1:38 AM CEST, Jack Gleeson wrote:
>>>> I'm not seeing where in this patch it is recognizing the ~~ notation.
>> That's something built in to the mistletoe library. It also includes
>> support for tables - also not in CommonMark. I'm just providing a
>> function to render the existing strikethrough tokens
>> as strikethroughs.
> Ugh, that's annoying. The whole point of commonmark was to put a stop to
> all of these private vendor extensions.
So, to clarify, is this patch dead?

Re: [PATCH core.sr.ht] Add strikethrough support to SrhtRenderer 1 year, 10 months ago

From Brett Gilio to ~sircmpwn/sr.ht-dev

On 7/21/2022 6:38 PM, Jack Gleeson wrote:
>
>
>>> I'm not seeing where in this patch it is recognizing the ~~ notation.
> That's something built in to the mistletoe library.
> It also includes support for tables - also not in CommonMark.
> I'm just providing a function to render the existing strikethrough tokens
> as strikethroughs.
>
>

Understood, thank you.

Re: [PATCH core.sr.ht] Add strikethrough support to SrhtRenderer 1 year, 10 months ago

From Brett Gilio to ~sircmpwn/sr.ht-dev

On 7/21/2022 6:30 PM, Jack Gleeson wrote:

> This patch works with the ~~ notation and recognises it as strikethrough.
>
> Use of <del> in place of <s> was just personal preference, I'm agnostic
> on which is more suitable.
>
> I didn't realise CommonMark still hadn't agreed on including
> strikethrough in the specification. I see the value in including them,
> but recognise that it is not in the standard. In which case, it's fair
> to call this out of scope and ddevault can ignore this patch.
>
>
>

Re: [PATCH core.sr.ht] Add strikethrough support to SrhtRenderer 1 year, 10 months ago

From Brett Gilio to ~sircmpwn/sr.ht-dev

On 7/21/2022 4:13 PM, Drew DeVault wrote:
>
> We use CommonMark, so it would have to be standardized there first.


In that case, I am totally fine with omitting <del> from the sanitizer.

Re: [PATCH core.sr.ht] Add strikethrough support to SrhtRenderer 1 year, 10 months ago

From Brett Gilio to ~sircmpwn/sr.ht-dev

Hello Jack

On 7/20/2022 9:14 PM, jack gleeson wrote:
> @@ -181,7 +186,7 @@ _sanitizer = bleach.sanitizer.Cleaner(
>           "q",
>           "h1", "h2", "h3", "h4", "h5", "h6",
>           "details", "summary",
> -        "abbr", "dfn",
> +        "abbr", "dfn", "del"
>       ],
>       attributes={**bleach.sanitizer.ALLOWED_ATTRIBUTES, **_sanitizer_attrs},
>       protocols=[

Re: Optionally pre-populate tickets. 1 year, 10 months ago

From Brett Gilio to ~sircmpwn/sr.ht-discuss

Hello Liele

On 7/18/2022 8:57 AM, Liele Zerau wrote:
>> Is that functionality already implemented, or is that something which
>> is being proposed?
> Already implemented – see here:
>
>      https://man.sr.ht/git.sr.ht/#referencing-tickets-in-git-commit-messages

Thank you for that information. Good to know. Drew is not fond of the 
idea I proposed, but I learned a good bit.

Brett

Re: Optionally pre-populate tickets. 1 year, 10 months ago

From Brett Gilio to ~sircmpwn/sr.ht-discuss

Hello Akspecs

On 7/17/2022 7:26 PM, akspecs wrote:
> and then, the linked todo will automatically be marked as fixed on the
> tracker if the patch is merged upstream.


Is that functionality already implemented, or is that something which is 
being proposed? If it is already implemented, then it would be 
imperative that data be retained in trackers as pre-populated information.

Brett Gilio

Optionally pre-populate tickets. 1 year, 10 months ago

From Brett Gilio to ~sircmpwn/sr.ht-discuss

Hello all,

This is a feature suggestion that has bounced into my head. It could be 
beneficial for novices to patch-based development browsing ticket 
trackers to have a handy method for queuing and sending their 
contributions. The method I took is to provide a template for 
git-send-email commands in the tickets themselves. An example of such 
can be seen at [0]. The idea I have is for this to be optionally enabled 
in the TODO service, taking care to populate the commit messages with 
the snippet ID and title, as well as linking to the preferred 
development mailing list.

This idea may have no merit, but I wanted to make sure it was at least 
put out there.

Re: Matrix instead of IRC? 3 years ago

From Brett Gilio to ~sircmpwn/sr.ht-discuss

Jonn <jonn@doma.dev> writes:


> Re: bells and whistles such as history —
> Yes, IRC is for casual communication, but so is any other chat. Chats are at
> most full-text-searchable. If you care about for searchability, use a weechat
> in tmux, or attach your GUI IRC client to a server running an IRC client.
>
> Or use an IRC indexer, of which there are plenty.
>

I'd also like to note that Freenode and OFTC are implementing a ircv3
compliant server forked from charybdis which will probably come with
HistServ playback. So the issue of history for Freenode will soon be a