they/them
From Cadence Ember to ~cadence/tube-devel
Resolved in 8486517 using user-agent sniffing. Not perfect, but it should cover the _vast_ majority of cases.
From Cadence Ember to ~cadence/tube-devel
> + let remoteURL = url.searchParams.get("url") To aid readability, let's use `const`. Naming the variables, e.g., `path` instead of `URL` would also help, when it is a path. > + statusCode: 401, > + content: "Unauthorized" You need a `contentType`. Would `application/json` be appropriate? `text/plain` would be acceptable too. Might be useful to make the message something like `CloudTube: Unauthorised` to indicate to humans that this response didn't hit the proxy. Otherwise it would be ambiguous whether CT or NL gave this response.
From Cadence Ember to ~cadence/tube-devel
You made a fair argument. Patch applied.
From Cadence Ember to ~cadence/tube-devel
Thanks, I got this all sorted and working. I hacked at your commits a bit to fix up a couple of issues, change the route, and add auto-caption stuff. Hope you don't mind!
From Cadence Ember to ~cadence/tube-devel
I agree that this would be useful for computers, but some mobile devices, when there is an autofocus field, will also bring up the keyboard automatically, which I find disorientating. Ideally I'd like it to autofocus for computers only, and I'm not sure how I'd do that. Cadence
From Cadence Ember to ~cadence/bibliogram-devel
Patch applied, thanks.
From Cadence Ember to ~cadence/bibliogram-devel
Thanks for this. Your patch didn't apply cleanly, but I believe I have made the required changes by hand. Let me know if it's all correct!
From Cadence Ember to ~cadence/tube-devel
Okay, wow, that's really interesting and I do agree with those decisions. I'll give this a check to see how it works in practice, then I think this is good to be merged.
From Cadence Ember to ~cadence/tube-devel
Hi, I'm finally getting to look at this. Thank you so much for your patience. > +/configuration.py Did you mean to put the main configuration file in dockerignore? > +COPY ./requirements.txt /workdir/requirements.txt > + > +RUN pip install -r requirements.txt > + > +COPY . /workdir Is there a reason why you don't `COPY .` straight away? Why 2 copy
From Cadence Ember to ~cadence/tube-devel
Thanks so much for this! Tomorrow I can properly review it, but taking a peek at the code now, there's a couple of things that stand out to me: - kind should be `captions` since it is a transcription of audio, not a translation; see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/track - should put the result of `getSettingsOrDefaults` in a variable to make it easier to extract other settings in the future - should validate the `lang` query parameter somehow I can deal with these notes on my own tomorrow, as well as doing my full review, but if you want make these changes yourself, you're free to submit an updated patch.