~cadence/bibliogram-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2 2

[PATCH 1/2 V2] Fix the rtl problem in the settings page.

Details
Message ID
<AM9P191MB15225D8A2CA82DED75A23D4CDFED9@AM9P191MB1522.EURP191.PROD.OUTLOOK.COM>
DKIM signature
pass
Download raw message
Patch: +7 -4
---
 src/site/pug/settings.pug          | 8 ++++----
 src/site/sass/includes/_forms.sass | 3 +++
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/site/pug/settings.pug b/src/site/pug/settings.pug
index 2649f0d..088b3f7 100644
--- a/src/site/pug/settings.pug
+++ b/src/site/pug/settings.pug
@@ -10,7 +10,7 @@ mixin fieldset(name)
mixin input(id, description, placeholder, disabled, list)
	.field-row
		label.description(for=id)= description
		input(type="text" id=id name=id value=settings[id] placeholder=placeholder disabled=disabled list=`${id}-list`)
		input(type="text" dir='ltr' id=id name=id value=settings[id] placeholder=placeholder disabled=disabled list=`${id}-list`)
		if list
			datalist(id=`${id}-list`)
				each item in list
@@ -21,7 +21,7 @@ mixin checkbox(id, description, label, disabled)
		label.description(for=id)= description
		input.checkbox(type="checkbox" id=id name=id checked=(settings[id] !== 0) disabled=disabled autocomplete="off")
		label.pill(for=id tabindex=(disabled ? null : 0) onkeypress=`[" ", "Enter"].includes(event.key) && this.click()`)= label
			span.fake-checkbox
			span.fake-checkbox(class=ll.meta_direction)

mixin select(id, description, disabled, options)
	.field-row
@@ -31,7 +31,7 @@ mixin select(id, description, disabled, options)
				option(value=option.value selected=(option.value === settings[id]))= option.text

doctype html
html
html(dir=ll.meta_direction)
	head
		title= `${ll.t_settings} | Bibliogram`
		include includes/head
@@ -47,7 +47,7 @@ html

				+fieldset(ll.t_features)
					+select("language", ll.t_language, false, [
						{value: "ar", text: "اَلْعَرَبِيَّةُ‎"},
						{value: "ar", text: "العربية"},
						{value: "bg", text: "Български"},
						{value: "de", text: "Deutsch"},
						{value: "en", text: "English (International)"},
diff --git a/src/site/sass/includes/_forms.sass b/src/site/sass/includes/_forms.sass
index 56219cc..27bb713 100644
--- a/src/site/sass/includes/_forms.sass
+++ b/src/site/sass/includes/_forms.sass
@@ -136,6 +136,9 @@ button
		margin-left: 8px
		position: relative
		outline: none
		.rtl
			margin-left: 0px
			margin-right: 8px

	.checkbox
		display: none
-- 
2.25.1
Details
Message ID
<20210731234333.8949d15a4f9367aa1b1eec15@disroot.org>
In-Reply-To
<AM9P191MB15225D8A2CA82DED75A23D4CDFED9@AM9P191MB1522.EURP191.PROD.OUTLOOK.COM> (view parent)
DKIM signature
pass
Download raw message
Thank you for your work! Patch applied (with a couple of tiny fixes.)
Details
Message ID
<AM9P191MB152287C0531A24F2CE8CB893DFEE9@AM9P191MB1522.EURP191.PROD.OUTLOOK.COM>
In-Reply-To
<20210731234333.8949d15a4f9367aa1b1eec15@disroot.org> (view parent)
DKIM signature
pass
Download raw message
  👍
Reply to thread Export thread (mbox)