~cadence/bibliogram-devel

1

Re: [PATCH] Add a(href=`#`) links around gallery images

Details
Message ID
<CDEC4AUO4OMR.2RYNQXBGSKM5N@ace>
DKIM signature
missing
Download raw message
> I implemented some focus handling through JavaScript, which is now
> live on bibliogram.art. Can you tell me if this solves your problem?

It works for me. I can now scroll just fine with Vimium keys.

There seems to be a brief (1s) moment just after loading a profile page
where clicking on a post and opening a gallery does not change the
focus. I imagine the JavaScript takes a moment to load fully. I'm not
too bothered by it.

It would have been great if there was some kind of pure declarative html
solution, but I don't plan on blocking JS on bibliogram instances
anyway, so it doesn't matter.

I agree with your overall approach of simplicity. I'm content with this
change. Thank you.

(Apologies for the address mix up.)

Re: [PATCH] Add a(href=`#`) links around gallery images

Details
Message ID
<bf6875c1-e22f-4811-bee9-1acaa13b13d1@disroot.org>
In-Reply-To
<CDEC4AUO4OMR.2RYNQXBGSKM5N@ace> (view parent)
DKIM signature
pass
Download raw message
> It would have been great if there was some kind of pure declarative 
> html
> solution, but I don't plan on blocking JS on bibliogram instances
> anyway, so it doesn't matter.

If JS is disabled, the post is shown on its own, not as an overlay, so 
there's no possibility for focus mixups and things will work fine.

> (Apologies for the address mix up.)

It happens, no worries!
Reply to thread Export thread (mbox)