~cadence/tube-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
1

[PATCH] add thumbnail on videos

bopol
Details
Message ID
<20210111164551.22545-1-bopol@e.email>
DKIM signature
pass
Download raw message
Patch: +1 -1
---
 pug/video.pug | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pug/video.pug b/pug/video.pug
index 74a9049..6749df6 100644
--- a/pug/video.pug
+++ b/pug/video.pug
@@ -21,7 +21,7 @@ block content
        .video-container
          - const format = sortedFormatStreams[0]
          if format
            video(controls preload="auto" width=format.second__width height=format.second__height data-itag=format.itag)#video.video
            video(controls preload="auto" poster=video.videoThumbnails[0].url width=format.second__width height=format.second__height data-itag=format.itag)#video.video
              source(src=format.url type=format.type)
          else
            video(src="")#video.video
-- 
2.29.2
Details
Message ID
<20210112144010.2f8a9000255b3dc87fc3bff2@disroot.org>
In-Reply-To
<20210111164551.22545-1-bopol@e.email> (view parent)
DKIM signature
pass
Download raw message
I know Invidious uses this but I'm not sure if I personally like the
aesthetics of this or not. Still, we can try it out for a while, or
maybe make it into a setting eventually.

For this to be added, though, you should use the local thumbnail URL
`/vi/${video.videoId}/maxresdefault.jpg`. Yes, the CloudTube frontend
has a thumbnail proxy, and it's used in this way for all other
thumbnails in the app. Compare to this section from
`pug/includes/video-list-item.pug`:

    a(href=link tabindex="-1").thumbnail
      img(src=`/vi/${video.videoId}/mqdefault.jpg` width=320 height=180
alt="").image

You could change this yourself, or I can just do it on my own by
applying and then editing your commit. Let me know what you'd like to
do, and thanks for the patch.
Reply to thread Export thread (mbox)