~cadence/tube-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
1

[PATCH] add theme color property

bopol
Details
Message ID
<20210211170058.39099-1-bopol@e.email>
DKIM signature
pass
Download raw message
Patch: +1 -0
---
 pug/includes/layout.pug | 1 +
 1 file changed, 1 insertion(+)

diff --git a/pug/includes/layout.pug b/pug/includes/layout.pug
index df8ba9f..5f5b3df 100644
--- a/pug/includes/layout.pug
+++ b/pug/includes/layout.pug
@@ -3,6 +3,7 @@ html
  head
    meta(charset="utf-8")
    meta(name="viewport" content="width=device-width, initial-scale=1")
    meta(name="theme-color" content="#4f5359")
    link(rel="stylesheet" type="text/css" href=getStaticURL("sass", "/main.sass"))
    script(type="module" src=getStaticURL("html", "/static/js/focus.js"))
    block head
-- 
2.27.0
Details
Message ID
<20210219013900.274f34a43316978b24db07e3@disroot.org>
In-Reply-To
<20210211170058.39099-1-bopol@e.email> (view parent)
DKIM signature
pass
Download raw message
From reading the documentation, "theme-color" appears to be used to
style the browser's chrome, which is done by some Android browsers and
also Vivaldi. This is most useful when the site actually _has_ a
colour. If you look at the homepage of Bibliogram, it has a
distinctive red theme. If you look at CloudTube, everything is greys.
I'd prefer if the user or user-agents gets to decide their favourite
colour, rather than us forcing a rather boring grey on them, so I'll
reject this patch. Thanks anyway though, I really do appreciate the
efforts!

As always, let me know if you disagree with my assessment.
Reply to thread Export thread (mbox)