Date: Sun, 14 Mar 2021 13:10:43 +0000 (UTC)
From: Cadence Ember <cadence@disroot.org>
To: ~cadence/tube-devel@lists.sr.ht
Message-ID: <e0d52657-510f-4da3-9115-f808f84b9bf7@disroot.org>
In-Reply-To: <20210314064924.21503-1-sir@hacktivista.com>
References: <20210314064924.21503-1-sir@hacktivista.com>
Subject: [PATCH] Captions support
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Thanks so much for this! Tomorrow I can properly review it, but taking a 
peek at the code now, there's a couple of things that stand out to me:

- kind should be `captions` since it is a transcription of audio, not a 
translation; see 
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/track
- should put the result of `getSettingsOrDefaults` in a variable to make 
it easier to extract other settings in the future
- should validate the `lang` query parameter somehow

I can deal with these notes on my own tomorrow, as well as doing my full 
review, but if you want make these changes yourself, you're free to 
submit an updated patch.