From Conner Bondurant to ~ntietz/isabella-db-devel
--- bitmap/src/dense.rs | 12 +++++++++++- bitmap/src/sparse.rs | 14 +++++++++++++- isabella/src/db/mod.rs | 11 +++++++++++ isabella/src/game/mod.rs | 2 +- isabella/src/index/unique_fixed.rs | 11 +++++++++++ isabella/src/strings.rs | 10 ++++++++++ 6 files changed, 57 insertions(+), 3 deletions(-) diff --git a/bitmap/src/dense.rs b/bitmap/src/dense.rs index cd4dec2..1aaeb51 100644 --- a/bitmap/src/dense.rs @@ -1,3 +1,4 @@ [message trimmed]
From Conner Bondurant to ~cbondurant/lipuma-devel
I am going to consider this patch finalized thanks to an additional commit I have written removing the noise dependency and improving noise speed as a result. - Conner Bondurant
From Conner Bondurant to ~cbondurant/lipuma-devel
--- src/draw_tools/fractal_line_tool.rs | 8 +++- src/draw_tools/selection_tool.rs | 62 +++++++++++++++++++++++----- src/render_objects/drawable.rs | 3 +- src/render_objects/fractal_line.rs | 26 ++++++++++-- src/render_objects/render_object.rs | 21 ++++++++-- src/render_objects/selection_rect.rs | 5 +++ 6 files changed, 105 insertions(+), 20 deletions(-) diff --git a/src/draw_tools/fractal_line_tool.rs b/src/draw_tools/fractal_line_tool.rs index f78679f..ea09f81 100644 --- a/src/draw_tools/fractal_line_tool.rs +++ b/src/draw_tools/fractal_line_tool.rs @@ -28,7 +28,9 @@ impl FractalLineTool { [message trimmed]
From Conner Bondurant to ~cbondurant/lipuma-devel
--- Cargo.lock | 29 ------------- Cargo.toml | 2 - src/draw_tools/fractal_line_tool.rs | 14 +++--- src/draw_tools/mod.rs | 1 + src/draw_tools/selection_tool.rs | 65 ++++++++++++++++++++++++++++ src/draw_tools/tool.rs | 11 ++--- src/main.rs | 45 ++++++++++++------- src/render_objects/drawable.rs | 8 ++-- src/render_objects/fractal_line.rs | 12 ++--- src/render_objects/mod.rs | 1 + src/render_objects/render_object.rs | 2 +- src/render_objects/selection_rect.rs | 43 ++++++++++++++++++ src/widgets/graphics_data.rs | 5 ++- [message trimmed]
From Conner Bondurant to ~cbondurant/lipuma-devel
--- src/graphics_scene_widget.rs | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/src/graphics_scene_widget.rs b/src/graphics_scene_widget.rs index 4fdd32f..0c9edcf 100644 --- a/src/graphics_scene_widget.rs +++ b/src/graphics_scene_widget.rs @@ -2,7 +2,6 @@ use std::rc::Rc; use druid::im::OrdSet; use druid::im::Vector; use druid::Affine; use druid::Color; [message trimmed]
From Conner Bondurant to ~cbondurant/lipuma-devel
--- Patch change to now utilize a match statement within tool, reducing the amount of exposed trait information src/draw_tools/fractal_line_tool.rs | 129 ++++++++++++++++++++++++++++ src/draw_tools/mod.rs | 2 + src/draw_tools/tool.rs | 11 +++ src/graphics_scene_widget.rs | 74 ++++------------ src/main.rs | 1 + src/renderobject.rs | 8 ++ 6 files changed, 170 insertions(+), 55 deletions(-) create mode 100644 src/draw_tools/fractal_line_tool.rs create mode 100644 src/draw_tools/mod.rs create mode 100644 src/draw_tools/tool.rs [message trimmed]
From Conner Bondurant to ~cbondurant/lipuma-devel
> Right now you have to implement a bunch of methods on each struct that > is Tool, even if it won't use them. If you add another method to the > trait, it'll have to also be added on all the Tools. > > Did you consider instead creating one handler method, something like > `on_event`, and an `Event` enum that wraps around the other events? > Then Tool impls could switch on Event and choose which which events to > match on, and ignore the other ones. That could make some of the Tool > implementations simpler if they're not going to all use all the events. I had definitely thought about using one big match statement, though it felt a little bit messy to do it that way. Messy in that I wouldn't be able to hop as easily to a specific handler in the tool.
From Conner Bondurant to ~cbondurant/lipuma-devel
--- Had to add some more clippy suggestions I missed last time src/draw_tools/fractal_line_tool.rs | 14 +++++--------- src/graphics_scene_widget.rs | 21 --------------------- 2 files changed, 5 insertions(+), 30 deletions(-) diff --git a/src/draw_tools/fractal_line_tool.rs b/src/draw_tools/fractal_line_tool.rs index 944ea0a..6948d8c 100644 --- a/src/draw_tools/fractal_line_tool.rs +++ b/src/draw_tools/fractal_line_tool.rs @@ -53,7 +53,7 @@ impl Tool for FractalLineTool { &mut self, event: &druid::MouseEvent, ctx: &mut druid::EventCtx, [message trimmed]
From Conner Bondurant to ~cbondurant/lipuma-devel
--- src/draw_tools/fractal_line_tool.rs | 152 ++++++++++++++++++++++++++++ src/draw_tools/mod.rs | 2 + src/draw_tools/tool.rs | 17 ++++ src/graphics_scene_widget.rs | 69 ++++--------- src/main.rs | 1 + src/renderobject.rs | 8 ++ 6 files changed, 199 insertions(+), 50 deletions(-) create mode 100644 src/draw_tools/fractal_line_tool.rs create mode 100644 src/draw_tools/mod.rs create mode 100644 src/draw_tools/tool.rs diff --git a/src/draw_tools/fractal_line_tool.rs b/src/draw_tools/fractal_line_tool.rs new file mode 100644 [message trimmed]
From Conner Bondurant to ~cbondurant/lipuma-devel
--- src/draw_tools/fractal_line_tool.rs | 10 +++++----- src/graphics_scene_widget.rs | 21 --------------------- 2 files changed, 5 insertions(+), 26 deletions(-) diff --git a/src/draw_tools/fractal_line_tool.rs b/src/draw_tools/fractal_line_tool.rs index 944ea0a..aa4b371 100644 --- a/src/draw_tools/fractal_line_tool.rs +++ b/src/draw_tools/fractal_line_tool.rs @@ -53,7 +53,7 @@ impl Tool for FractalLineTool { &mut self, event: &druid::MouseEvent, ctx: &mut druid::EventCtx, data: &mut crate::graphics_scene_widget::GraphicsData, [message trimmed]