From: Philip Kaludercic <philipk@posteo.net>
To: Gregory Chamberlain <greg@cosine.blue>
Cc: Gregory Chamberlain's Public Inbox <~chambln/public-inbox@lists.sr.ht>
Subject: Re: Adding the Aircon theme to NonGNU ELPA
References: <87wnf5bqv5.fsf@posteo.net> <877d6scgyz.fsf@cosine.blue>
	<87pmkjyig7.fsf@posteo.net> <87mtflh3hm.fsf@cosine.blue>
	<87bkv7vv7p.fsf@posteo.net> <87wndtj8w9.fsf@cosine.blue>
Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata=
 mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo
 aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0
 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ
 CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh
 io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF
 AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo
 Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS
 g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB
Date: Tue, 07 Jun 2022 08:05:55 +0000
In-Reply-To: <87wndtj8w9.fsf@cosine.blue> (Gregory Chamberlain's message of
	"Tue, 07 Jun 2022 07:16:22 +0100")
Message-ID: <87ee0099uk.fsf@posteo.net>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="

--=-=-=
Content-Type: text/plain

Gregory Chamberlain <greg@cosine.blue> writes:

> Philip Kaludercic <philipk@posteo.net> writes:
>
>>>> Unless you have already signed the FSF copyright assignment, you should
>>>> fill it out and send it to the right address:
>>>>
>>>> Other than that, I can take care of all the remaining stuff.  If you
>>>> decide against wanting to sign the CA, I can also add the package to
>>>> NonGNU ELPA.
>>>
>>> Thanks, I've now sent the CA.
>>
>> Have you received any update?
>
> Yes, the copyright assignment was completed yesterday. You can add the
> Aircon theme to GNU ELPA now.
>
> I am still improving the theme from time to time, pushing updates to the
> repository at the URL below.
>
> https://git.sr.ht/~chambln/aircon-theme.el
>
> Occasionally I tag a commit as a new version, but these "releases" are
> somewhat arbitrary. Although changes have been incremental for a while
> now, I'm reluctant to call it stable just yet.
>
> What is the process of a new release making its way to GNU ELPA? How
> closely do GNU ELPA packages follow upstream releases?

Also could you apply these changes:


--=-=-=
Content-Type: text/plain
Content-Disposition: inline

diff --git a/aircon-theme.el b/aircon-theme.el
index 0eac8cf..2558eef 100644
--- a/aircon-theme.el
+++ b/aircon-theme.el
@@ -1,14 +1,15 @@
 ;;; aircon-theme.el --- Cool and legible light theme  -*- lexical-binding: t; -*-
 
-;; Copyright (C) 2022 Gregory Chamberlain.
+;; Copyright (C) 2022  Free Software Foundation, Inc.
 
 ;; Version: 0.0.3
 ;; Author: Gregory Chamberlain <greg@cosine.blue>
+;; Maintainer: Gregory Chamberlain <~chambln/public-inbox@lists.sr.ht>
 ;; URL: https://git.sr.ht/~chambln/aircon-theme.el
 ;; Keywords: faces
 ;; Package-Requires: ((emacs "24.4"))
 
-;; This file is NOT part of GNU Emacs.
+;; This file is part of GNU Emacs.
 
 ;; This program is free software; you can redistribute it and/or modify
 ;; it under the terms of the GNU General Public License as published by
@@ -25,14 +26,19 @@
 
 ;;; Commentary:
 
-;; Aircon is a clean and high contrast custom theme for Emacs. It
+;; Aircon is a clean and high contrast custom theme for Emacs.  It
 ;; consists of a white (#ffffff) background and mostly blues, purples
-;; and greens. Highlights are subtle but easily visible. The active
+;; and greens.  Highlights are subtle but easily visible.  The active
 ;; mode-line is white on blue to distinguish it from inactive
 ;; mode-lines which are dark blue on light grey.
 
 ;;; Code:
 
+(defgroup aircon nil
+  "Cool and legible light theme."
+  :prefix "aircon-"
+  :group 'faces)
+
 (deftheme aircon "Cool and legible light theme.")
 
 (defconst aircon-brick     "#8d2934")   ; error
@@ -118,17 +124,17 @@
  '(fringe  ((t (:inherit (default)))))
 
  `(mode-line                  ((t (:inherit (variable-pitch aircon-fjord)
-                                   :foreground "#ffffff"
-                                   :box ,aircon-midnight))))
+					    :foreground "#ffffff"
+					    :box ,aircon-midnight))))
  `(mode-line-inactive         ((t (:inherit (aircon-header mode-line)
-                                   :box ,aircon-ghost))))
+					    :box ,aircon-ghost))))
  '(mode-line-highlight        ((t (:inherit (mode-line)))))
 
  '(compilation-mode-line-fail ((t (:inherit error))))
  '(compilation-error          ((t (:inherit error))))
 
  `(help-key-binding ((t (:inherit (aircon-header)
-                         :box (:color ,aircon-ghost (1 . -1) :line-width)))))
+				  :box (:color ,aircon-ghost (1 . -1) :line-width)))))
 
  '(shadow       ((t (:inherit (aircon-scorpion)))))
  '(error        ((t (:inherit (bold aircon-brick)))))

--=-=-=
Content-Type: text/plain


The first and third change are the most important, since ELPA packages
are officially part of Emacs.

The other ones are just recommendations.

--=-=-=--