Ulsan, South Korea
Vietnamese free software enthusiast
From Nguyễn Gia Phong to ~mil/sxmo-user
On 2024-12-09 at 02:49+00:00, Fredrik Salomonsson wrote: > https://sxmo.org/deviceprofile [...] I'm getting 404 > when clicking on the link [...] "our manual’s > section on writing a device profile" [...] that takes me > to sxmo.org/docs/sxmo.7.html#DEVICES. It's now under https://sxmo.org/docs/user/sxmo.7.html#DEVICES, I've just sent out https://lists.sr.ht/~mil/sxmo-devel/patches/56352 to correct it.
From Nguyễn Gia Phong to ~mil/sxmo-devel
Fixes: https://lists.sr.ht/~mil/sxmo-user/%3C87o71lr2ou.fsf@posteo.net%3E Fixes: 5a07e0b26759a ("Website documentation overhaul") --- src/deviceprofile/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/deviceprofile/index.md b/src/deviceprofile/index.md index 36fb2708b4f1..d11e1ac22175 100644 --- a/src/deviceprofile/index.md +++ b/src/deviceprofile/index.md @@ -53,7 +53,7 @@ A mainlined device will have support for many years to come, receive security up Sxmo may require some configuration for a devices that are supported in postmarketOS but not listed in the **devices with the best Sxmo support section** above. Please see [our manual's section on writing a device [message trimmed]
From Nguyễn Gia Phong to ~mil/mepo-devel
--- src/Mepo.zig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Mepo.zig b/src/Mepo.zig index 3b4e371bbf20..d8c28d6a360d 100644 --- a/src/Mepo.zig +++ b/src/Mepo.zig @@ -326,9 +326,8 @@ pub fn event_quit(mepo: *Self, _: sdl.SDL_Event) types.Pending { return .None; } fn event_unhandled(_: *Self, e: sdl.SDL_Event) types.Pending { fn event_unhandled(_: *Self, _: sdl.SDL_Event) types.Pending {[message trimmed]
From Nguyễn Gia Phong to ~mil/mepo-devel
--- On 2024-08-13 at 19:06-04:00, Miles Alan wrote: > My only caveat would be that the token for the struct we use in > this pattern should be consistent (e.g. both 'Self' in the case of > EvictionHashMap is used but then 'Mepo' and 'TileCache' are used for > Mepo/TileCache). We should follow one pattern or the other for naming. > I'd say using 'Self' in all instances would be a bit better? I think that's reasonable. I've accordingly updated the type names to Self. src/Mepo.zig | 71 ++++++++++++++------------- src/TileCache.zig | 41 ++++++++-------- src/datastructure/EvictionHashMap.zig | 19 +++---- [message trimmed]
From Nguyễn Gia Phong to ~mil/mepo-devel
On 2024-08-08 at 11:26-04:00, Miles Alan wrote: > Seems like it no longer applies cleanly > > Curious what the benefit of using the name over @This() would be? > From the @This() perspective it would make things easier to update > in the future if a particular file was renamed. Is @This() planned > to be deprecated or is repeated use of @This() not best practice > from Zig's perspective? Personally I find @This() to introduce additional mental overhead to read over a single symbol like a struct's name. There's no technical difference since the result of @This() would be memoized. In Zig's std library, it's more common to call @This() once
From Nguyễn Gia Phong to ~mil/mepo-devel
--- README.md | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index fcdfb557fcf0..f6555bebd25e 100644 --- a/README.md +++ b/README.md @@ -11,12 +11,12 @@ API to allow the user to change & add functionality such as adding their own search & routing scripts, add arbitrary buttons/keybindings to the UI, and more. - [Documentation Website](http://mepo.milesalan.com) - [Demo Video on postmarketOS phone](http://mepo.milesalan.com/demos.html#mobile-demo-major-features)[message trimmed]
From Nguyễn Gia Phong to ~mil/mepo-devel
The line with only 4 spaces can be rendered as a code block which is rather distracting to read. --- README.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index d6f383b30089..fcdfb557fcf0 100644 --- a/README.md +++ b/README.md @@ -22,7 +22,7 @@ UI, and more. - **Fast & usable in resource-constrained environments**: - Mepo **launches quickly and runs quickly** on the PinePhone and other [message trimmed]
From Nguyễn Gia Phong to ~mil/mepo-devel
References: dac55b5c8456 ("Remove doc folder - moved to mepo_website repo") --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 4e34920483ab..d6f383b30089 100644 --- a/README.md +++ b/README.md @@ -86,7 +86,7 @@ NLnet for accepting our application and making this development possible! Mepo is surely welcome to contributors who have experience or interest in mobile Linux, OSM, and/or Zig. - **Development Guide**: [here](doc/developguide.md)[message trimmed]
From Nguyễn Gia Phong to ~mil/mepo-devel
Nguyễn Gia Phong (3): Update link to development guide Remove trailing whitespaces in README Prefer HTTPS where possible README.md | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) -- 2.45.2
From Nguyễn Gia Phong to ~mil/mepo-devel
If killed when the pipe is still open, the process could turn into a zombie. --- On 2024-08-05 at 16:44+09:00, Nguyễn Gia Phong wrote: > The file is not closed if readToEndAlloc return an error. > [...] I will send out a v2 addressing this I forgot to do it so here goes the patch on top of that d-; src/util/utilprocess.zig | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/util/utilprocess.zig b/src/util/utilprocess.zig index 45346a3cd93d..4e73504b83d3 100644 [message trimmed]